| Message ID | 20250204110640.570823-2-cassel@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Krzysztof Wilczyński |
| Headers | show |
| Series | [v2] misc: pci_endpoint_test: Fix pci_endpoint_test_bars_read_bar() error handling | expand |
On Tue, Feb 04, 2025 at 12:06:41PM +0100, Niklas Cassel wrote: > Commit f26d37ee9bda ("misc: pci_endpoint_test: Fix IOCTL return value") > changed the return value of pci_endpoint_test_bars_read_bar() from false > to -EINVAL on error, however, it failed to update the error handling. > > Fixes: f26d37ee9bda ("misc: pci_endpoint_test: Fix IOCTL return value") > Signed-off-by: Niklas Cassel <cassel@kernel.org> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> - Mani > --- > Changes since v1: > -Changed the type of the variable ret to int to match the new return type. > > drivers/misc/pci_endpoint_test.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/misc/pci_endpoint_test.c b/drivers/misc/pci_endpoint_test.c > index d5ac71a49386..7584d1876859 100644 > --- a/drivers/misc/pci_endpoint_test.c > +++ b/drivers/misc/pci_endpoint_test.c > @@ -382,7 +382,7 @@ static int pci_endpoint_test_bars_read_bar(struct pci_endpoint_test *test, > static int pci_endpoint_test_bars(struct pci_endpoint_test *test) > { > enum pci_barno bar; > - bool ret; > + int ret; > > /* Write all BARs in order (without reading). */ > for (bar = 0; bar < PCI_STD_NUM_BARS; bar++) > @@ -398,7 +398,7 @@ static int pci_endpoint_test_bars(struct pci_endpoint_test *test) > for (bar = 0; bar < PCI_STD_NUM_BARS; bar++) { > if (test->bar[bar]) { > ret = pci_endpoint_test_bars_read_bar(test, bar); > - if (!ret) > + if (ret) > return ret; > } > } > -- > 2.48.1 >
On Tue, Feb 04, 2025 at 12:06:41PM +0100, Niklas Cassel wrote: > Commit f26d37ee9bda ("misc: pci_endpoint_test: Fix IOCTL return value") > changed the return value of pci_endpoint_test_bars_read_bar() from false > to -EINVAL on error, however, it failed to update the error handling. > > Fixes: f26d37ee9bda ("misc: pci_endpoint_test: Fix IOCTL return value") > Signed-off-by: Niklas Cassel <cassel@kernel.org> > --- > Changes since v1: > -Changed the type of the variable ret to int to match the new return type. > > drivers/misc/pci_endpoint_test.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/misc/pci_endpoint_test.c b/drivers/misc/pci_endpoint_test.c > index d5ac71a49386..7584d1876859 100644 > --- a/drivers/misc/pci_endpoint_test.c > +++ b/drivers/misc/pci_endpoint_test.c > @@ -382,7 +382,7 @@ static int pci_endpoint_test_bars_read_bar(struct pci_endpoint_test *test, > static int pci_endpoint_test_bars(struct pci_endpoint_test *test) > { > enum pci_barno bar; > - bool ret; > + int ret; > > /* Write all BARs in order (without reading). */ > for (bar = 0; bar < PCI_STD_NUM_BARS; bar++) > @@ -398,7 +398,7 @@ static int pci_endpoint_test_bars(struct pci_endpoint_test *test) > for (bar = 0; bar < PCI_STD_NUM_BARS; bar++) { > if (test->bar[bar]) { > ret = pci_endpoint_test_bars_read_bar(test, bar); > - if (!ret) > + if (ret) > return ret; > } > } > -- > 2.48.1 > Ping. Because of this bug, if this test fails, it will be reported as success, so quite bad. Kind regards, Niklas
On Tue, Feb 04, 2025 at 12:06:41PM +0100, Niklas Cassel wrote: > Commit f26d37ee9bda ("misc: pci_endpoint_test: Fix IOCTL return value") > changed the return value of pci_endpoint_test_bars_read_bar() from false > to -EINVAL on error, however, it failed to update the error handling. > > Fixes: f26d37ee9bda ("misc: pci_endpoint_test: Fix IOCTL return value") > Signed-off-by: Niklas Cassel <cassel@kernel.org> Applied to pci/endpoint! - Mani > --- > Changes since v1: > -Changed the type of the variable ret to int to match the new return type. > > drivers/misc/pci_endpoint_test.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/misc/pci_endpoint_test.c b/drivers/misc/pci_endpoint_test.c > index d5ac71a49386..7584d1876859 100644 > --- a/drivers/misc/pci_endpoint_test.c > +++ b/drivers/misc/pci_endpoint_test.c > @@ -382,7 +382,7 @@ static int pci_endpoint_test_bars_read_bar(struct pci_endpoint_test *test, > static int pci_endpoint_test_bars(struct pci_endpoint_test *test) > { > enum pci_barno bar; > - bool ret; > + int ret; > > /* Write all BARs in order (without reading). */ > for (bar = 0; bar < PCI_STD_NUM_BARS; bar++) > @@ -398,7 +398,7 @@ static int pci_endpoint_test_bars(struct pci_endpoint_test *test) > for (bar = 0; bar < PCI_STD_NUM_BARS; bar++) { > if (test->bar[bar]) { > ret = pci_endpoint_test_bars_read_bar(test, bar); > - if (!ret) > + if (ret) > return ret; > } > } > -- > 2.48.1 >
diff --git a/drivers/misc/pci_endpoint_test.c b/drivers/misc/pci_endpoint_test.c index d5ac71a49386..7584d1876859 100644 --- a/drivers/misc/pci_endpoint_test.c +++ b/drivers/misc/pci_endpoint_test.c @@ -382,7 +382,7 @@ static int pci_endpoint_test_bars_read_bar(struct pci_endpoint_test *test, static int pci_endpoint_test_bars(struct pci_endpoint_test *test) { enum pci_barno bar; - bool ret; + int ret; /* Write all BARs in order (without reading). */ for (bar = 0; bar < PCI_STD_NUM_BARS; bar++) @@ -398,7 +398,7 @@ static int pci_endpoint_test_bars(struct pci_endpoint_test *test) for (bar = 0; bar < PCI_STD_NUM_BARS; bar++) { if (test->bar[bar]) { ret = pci_endpoint_test_bars_read_bar(test, bar); - if (!ret) + if (ret) return ret; } }
Commit f26d37ee9bda ("misc: pci_endpoint_test: Fix IOCTL return value") changed the return value of pci_endpoint_test_bars_read_bar() from false to -EINVAL on error, however, it failed to update the error handling. Fixes: f26d37ee9bda ("misc: pci_endpoint_test: Fix IOCTL return value") Signed-off-by: Niklas Cassel <cassel@kernel.org> --- Changes since v1: -Changed the type of the variable ret to int to match the new return type. drivers/misc/pci_endpoint_test.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)