| Message ID | 20250207-ppcyaml-v2-11-8137b0c42526@posteo.net (mailing list archive) |
|---|---|
| State | Handled Elsewhere |
| Delegated to: | Krzysztof Wilczyński |
| Headers | show |
| Series | YAML conversion of several Freescale/PowerPC DT bindings | expand |
On Fri, 07 Feb 2025 22:30:28 +0100, J. Neuschäfer wrote: > Formalize the binding already supported by the fsl_elbc_nand.c driver > and used in several device trees in arch/powerpc/boot/dts/. > > Signed-off-by: J. Neuschäfer <j.ne@posteo.net> > --- > > V2: > - split out from fsl,elbc binding patch > - constrain #address-cells and #size-cells > - add a general description > - use unevaluatedProperties=false instead of additionalProperties=false > - fix property order to comply with dts coding style > - include raw-nand-chip.yaml instead of nand-chip.yaml > --- > .../devicetree/bindings/mtd/fsl,elbc-fcm-nand.yaml | 68 ++++++++++++++++++++++ > 1 file changed, 68 insertions(+) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mtd/fsl,elbc-fcm-nand.example.dtb: nand@1,0: $nodename:0: 'nand@1,0' does not match '^nand@[a-f0-9]$' from schema $id: http://devicetree.org/schemas/mtd/fsl,elbc-fcm-nand.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/memory-controllers/fsl,elbc.example.dtb: nand@1,0: $nodename:0: 'nand@1,0' does not match '^nand@[a-f0-9]$' from schema $id: http://devicetree.org/schemas/mtd/fsl,elbc-fcm-nand.yaml# doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250207-ppcyaml-v2-11-8137b0c42526@posteo.net The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
On Fri, Feb 07, 2025 at 10:30:28PM +0100, J. Neuschäfer via B4 Relay wrote: > From: "J. Neuschäfer" <j.ne@posteo.net> > > Formalize the binding already supported by the fsl_elbc_nand.c driver > and used in several device trees in arch/powerpc/boot/dts/. > > Signed-off-by: J. Neuschäfer <j.ne@posteo.net> > --- > > V2: > - split out from fsl,elbc binding patch > - constrain #address-cells and #size-cells > - add a general description > - use unevaluatedProperties=false instead of additionalProperties=false > - fix property order to comply with dts coding style > - include raw-nand-chip.yaml instead of nand-chip.yaml > --- > .../devicetree/bindings/mtd/fsl,elbc-fcm-nand.yaml | 68 ++++++++++++++++++++++ > 1 file changed, 68 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mtd/fsl,elbc-fcm-nand.yaml b/Documentation/devicetree/bindings/mtd/fsl,elbc-fcm-nand.yaml > new file mode 100644 > index 0000000000000000000000000000000000000000..1de97bb24fa4a83e2ea5d94ab822dd0e37baa102 > --- /dev/null > +++ b/Documentation/devicetree/bindings/mtd/fsl,elbc-fcm-nand.yaml > @@ -0,0 +1,68 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/mtd/fsl,elbc-fcm-nand.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: NAND flash attached to Freescale eLBC > + > +description: > + The Freescale Enhanced Local Bus controller (eLBC) contains logic to > + interface with NAND flash, called the NAND Flash Control Machine (FCM). > + This binding describes flash attached to an eLBC using the FCM. > + > +maintainers: > + - J. Neuschäfer <j.ne@posteo.net> > + > +allOf: > + - $ref: raw-nand-chip.yaml# > + > +properties: > + compatible: > + oneOf: > + - items: > + - enum: > + - fsl,mpc8313-fcm-nand > + - fsl,mpc8315-fcm-nand > + - fsl,mpc8377-fcm-nand > + - fsl,mpc8378-fcm-nand > + - fsl,mpc8379-fcm-nand > + - fsl,mpc8536-fcm-nand > + - fsl,mpc8569-fcm-nand > + - fsl,mpc8572-fcm-nand > + - fsl,p1020-fcm-nand > + - fsl,p1021-fcm-nand > + - fsl,p1025-fcm-nand > + - fsl,p2020-fcm-nand > + - const: fsl,elbc-fcm-nand > + - const: fsl,elbc-fcm-nand > + > + reg: > + maxItems: 1 > + > + "#address-cells": > + const: 1 > + > + "#size-cells": > + const: 1 > + > +required: > + - compatible > + - reg > + > +unevaluatedProperties: false > + > +examples: > + - | > + localbus { > + #address-cells = <2>; > + #size-cells = <1>; > + > + nand@1,0 { > + compatible = "fsl,mpc8315-fcm-nand", > + "fsl,elbc-fcm-nand"; > + reg = <0x1 0x0 0x2000>; > + #address-cells = <1>; > + #size-cells = <1>; needn't #address-cells and #size-cells because no children nodes. Reviewed-by: Frank Li <Frank.Li@nxp.com> Frank > + }; > + }; > > -- > 2.48.0.rc1.219.gb6b6757d772 > >
On Fri, Feb 07, 2025 at 10:30:28PM +0100, J. Neuschäfer wrote: > Formalize the binding already supported by the fsl_elbc_nand.c driver > and used in several device trees in arch/powerpc/boot/dts/. > > Signed-off-by: J. Neuschäfer <j.ne@posteo.net> > --- > > V2: > - split out from fsl,elbc binding patch > - constrain #address-cells and #size-cells > - add a general description > - use unevaluatedProperties=false instead of additionalProperties=false > - fix property order to comply with dts coding style > - include raw-nand-chip.yaml instead of nand-chip.yaml Why? Doesn't look like you use anything from it. I think the correct thing to use here is just mtd.yaml to pick up partitions. > --- > .../devicetree/bindings/mtd/fsl,elbc-fcm-nand.yaml | 68 ++++++++++++++++++++++ > 1 file changed, 68 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mtd/fsl,elbc-fcm-nand.yaml b/Documentation/devicetree/bindings/mtd/fsl,elbc-fcm-nand.yaml > new file mode 100644 > index 0000000000000000000000000000000000000000..1de97bb24fa4a83e2ea5d94ab822dd0e37baa102 > --- /dev/null > +++ b/Documentation/devicetree/bindings/mtd/fsl,elbc-fcm-nand.yaml > @@ -0,0 +1,68 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/mtd/fsl,elbc-fcm-nand.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: NAND flash attached to Freescale eLBC > + > +description: > + The Freescale Enhanced Local Bus controller (eLBC) contains logic to > + interface with NAND flash, called the NAND Flash Control Machine (FCM). > + This binding describes flash attached to an eLBC using the FCM. > + > +maintainers: > + - J. Neuschäfer <j.ne@posteo.net> > + > +allOf: > + - $ref: raw-nand-chip.yaml# > + > +properties: > + compatible: > + oneOf: > + - items: > + - enum: > + - fsl,mpc8313-fcm-nand > + - fsl,mpc8315-fcm-nand > + - fsl,mpc8377-fcm-nand > + - fsl,mpc8378-fcm-nand > + - fsl,mpc8379-fcm-nand > + - fsl,mpc8536-fcm-nand > + - fsl,mpc8569-fcm-nand > + - fsl,mpc8572-fcm-nand > + - fsl,p1020-fcm-nand > + - fsl,p1021-fcm-nand > + - fsl,p1025-fcm-nand > + - fsl,p2020-fcm-nand > + - const: fsl,elbc-fcm-nand > + - const: fsl,elbc-fcm-nand > + > + reg: > + maxItems: 1 > + > + "#address-cells": > + const: 1 > + > + "#size-cells": > + const: 1 > + > +required: > + - compatible > + - reg > + > +unevaluatedProperties: false > + > +examples: > + - | > + localbus { > + #address-cells = <2>; > + #size-cells = <1>; > + > + nand@1,0 { > + compatible = "fsl,mpc8315-fcm-nand", > + "fsl,elbc-fcm-nand"; > + reg = <0x1 0x0 0x2000>; > + #address-cells = <1>; > + #size-cells = <1>; > + }; > + }; > > -- > 2.48.0.rc1.219.gb6b6757d772 >
On Mon, Feb 10, 2025 at 06:01:57PM -0600, Rob Herring wrote: > On Fri, Feb 07, 2025 at 10:30:28PM +0100, J. Neuschäfer wrote: > > Formalize the binding already supported by the fsl_elbc_nand.c driver > > and used in several device trees in arch/powerpc/boot/dts/. > > > > Signed-off-by: J. Neuschäfer <j.ne@posteo.net> > > --- > > > > V2: > > - split out from fsl,elbc binding patch > > - constrain #address-cells and #size-cells > > - add a general description > > - use unevaluatedProperties=false instead of additionalProperties=false > > - fix property order to comply with dts coding style > > - include raw-nand-chip.yaml instead of nand-chip.yaml > > Why? Doesn't look like you use anything from it. I think the correct > thing to use here is just mtd.yaml to pick up partitions. There is one example of properties from nand-chip.yaml being used on an fsl,elbc-fcm-nand node: arch/powerpc/boot/dts/turris1x.dts uses nand-ecc-mode and nand-ecc-algo. Thanks, J. Neuschäfer
diff --git a/Documentation/devicetree/bindings/mtd/fsl,elbc-fcm-nand.yaml b/Documentation/devicetree/bindings/mtd/fsl,elbc-fcm-nand.yaml new file mode 100644 index 0000000000000000000000000000000000000000..1de97bb24fa4a83e2ea5d94ab822dd0e37baa102 --- /dev/null +++ b/Documentation/devicetree/bindings/mtd/fsl,elbc-fcm-nand.yaml @@ -0,0 +1,68 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/mtd/fsl,elbc-fcm-nand.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: NAND flash attached to Freescale eLBC + +description: + The Freescale Enhanced Local Bus controller (eLBC) contains logic to + interface with NAND flash, called the NAND Flash Control Machine (FCM). + This binding describes flash attached to an eLBC using the FCM. + +maintainers: + - J. Neuschäfer <j.ne@posteo.net> + +allOf: + - $ref: raw-nand-chip.yaml# + +properties: + compatible: + oneOf: + - items: + - enum: + - fsl,mpc8313-fcm-nand + - fsl,mpc8315-fcm-nand + - fsl,mpc8377-fcm-nand + - fsl,mpc8378-fcm-nand + - fsl,mpc8379-fcm-nand + - fsl,mpc8536-fcm-nand + - fsl,mpc8569-fcm-nand + - fsl,mpc8572-fcm-nand + - fsl,p1020-fcm-nand + - fsl,p1021-fcm-nand + - fsl,p1025-fcm-nand + - fsl,p2020-fcm-nand + - const: fsl,elbc-fcm-nand + - const: fsl,elbc-fcm-nand + + reg: + maxItems: 1 + + "#address-cells": + const: 1 + + "#size-cells": + const: 1 + +required: + - compatible + - reg + +unevaluatedProperties: false + +examples: + - | + localbus { + #address-cells = <2>; + #size-cells = <1>; + + nand@1,0 { + compatible = "fsl,mpc8315-fcm-nand", + "fsl,elbc-fcm-nand"; + reg = <0x1 0x0 0x2000>; + #address-cells = <1>; + #size-cells = <1>; + }; + };