| Message ID | 20250211192444.2292833-12-terry.bowman@amd.com (mailing list archive) |
|---|---|
| State | Handled Elsewhere |
| Headers | show |
| Series | Enable CXL PCIe port protocol error handling and logging | expand |
On 2/11/25 12:24 PM, Terry Bowman wrote: > CXL PCIe Port Protocol Error support will be added in the future. This > requires searching for a CXL PCIe Port device in the CXL topology as > provided by find_cxl_port(). But, find_cxl_port() is defined static > and as a result is not callable outside of this source file. > > Update the find_cxl_port() declaration to be non-static. > > Signed-off-by: Terry Bowman <terry.bowman@amd.com> > Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> > Reviewed-by: Ira Weiny <ira.weiny@intel.com> > Reviewed-by: Gregory Price <gourry@gourry.net> Reviewed-by: Dave Jiang <dave.jiang@intel.com> I think this could've went with the same patch that's doing the calling of this function. > --- > drivers/cxl/core/core.h | 2 ++ > drivers/cxl/core/port.c | 4 ++-- > 2 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/cxl/core/core.h b/drivers/cxl/core/core.h > index a20ea2b7d1a4..796334f2ad6c 100644 > --- a/drivers/cxl/core/core.h > +++ b/drivers/cxl/core/core.h > @@ -118,5 +118,7 @@ int cxl_port_get_switch_dport_bandwidth(struct cxl_port *port, > struct access_coordinate *c); > > int cxl_gpf_port_setup(struct device *dport_dev, struct cxl_port *port); > +struct cxl_port *find_cxl_port(struct device *dport_dev, > + struct cxl_dport **dport); > > #endif /* __CXL_CORE_H__ */ > diff --git a/drivers/cxl/core/port.c b/drivers/cxl/core/port.c > index f9501a16b390..ae6471e4ebff 100644 > --- a/drivers/cxl/core/port.c > +++ b/drivers/cxl/core/port.c > @@ -1352,8 +1352,8 @@ static struct cxl_port *__find_cxl_port(struct cxl_find_port_ctx *ctx) > return NULL; > } > > -static struct cxl_port *find_cxl_port(struct device *dport_dev, > - struct cxl_dport **dport) > +struct cxl_port *find_cxl_port(struct device *dport_dev, > + struct cxl_dport **dport) > { > struct cxl_find_port_ctx ctx = { > .dport_dev = dport_dev,
Terry Bowman wrote: > CXL PCIe Port Protocol Error support will be added in the future. This > requires searching for a CXL PCIe Port device in the CXL topology as > provided by find_cxl_port(). But, find_cxl_port() is defined static > and as a result is not callable outside of this source file. > > Update the find_cxl_port() declaration to be non-static. > > Signed-off-by: Terry Bowman <terry.bowman@amd.com> > Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> > Reviewed-by: Ira Weiny <ira.weiny@intel.com> > Reviewed-by: Gregory Price <gourry@gourry.net> > --- > drivers/cxl/core/core.h | 2 ++ > drivers/cxl/core/port.c | 4 ++-- > 2 files changed, 4 insertions(+), 2 deletions(-) Looks ok, but this tiny patch has no justification by itself and should be squashed with the first consumer.
diff --git a/drivers/cxl/core/core.h b/drivers/cxl/core/core.h index a20ea2b7d1a4..796334f2ad6c 100644 --- a/drivers/cxl/core/core.h +++ b/drivers/cxl/core/core.h @@ -118,5 +118,7 @@ int cxl_port_get_switch_dport_bandwidth(struct cxl_port *port, struct access_coordinate *c); int cxl_gpf_port_setup(struct device *dport_dev, struct cxl_port *port); +struct cxl_port *find_cxl_port(struct device *dport_dev, + struct cxl_dport **dport); #endif /* __CXL_CORE_H__ */ diff --git a/drivers/cxl/core/port.c b/drivers/cxl/core/port.c index f9501a16b390..ae6471e4ebff 100644 --- a/drivers/cxl/core/port.c +++ b/drivers/cxl/core/port.c @@ -1352,8 +1352,8 @@ static struct cxl_port *__find_cxl_port(struct cxl_find_port_ctx *ctx) return NULL; } -static struct cxl_port *find_cxl_port(struct device *dport_dev, - struct cxl_dport **dport) +struct cxl_port *find_cxl_port(struct device *dport_dev, + struct cxl_dport **dport) { struct cxl_find_port_ctx ctx = { .dport_dev = dport_dev,