From patchwork Sat Mar 15 20:15:43 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bjorn Helgaas X-Patchwork-Id: 14018212 X-Patchwork-Delegate: kw@linux.com Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D80BB205517; Sat, 15 Mar 2025 20:16:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742069769; cv=none; b=mSIDm1IV6QK0iFvec1f3bvqpWmgCO11S0Lt0d9ESh5x4HNHhCuwxBv5lA51L2wBjyskcZ+oZ+FPAk1LXHCjbrPbbuPNcHXSa39sF0mffrHlW4bR831Chlf7fbGgFxuuFeuuZJu13NH/d/yTrCP26q2I8vJ2JETnOMTFw+UxGzi8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742069769; c=relaxed/simple; bh=yxt53pJS4LPQZZrMvULyJRtF3Mxw2qD3s3q527wIweA=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=sQKLoo7HHk+qPOxkKWhdEMeqL+ZFIuM/EkvRVlr4F3x53VrGLnl0Tulh2SWJSvgyX4YwUlv/DoCe7LIWhK0e9YONyPE+I7hYM9IVZsFcm4sUqprHQ5Ciauhy/smuhSOPtOWNCb8si6Rq7k2ZWFYUQ2jDsLr1frVnwGTe6sTdwSU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=JDiS+o2V; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="JDiS+o2V" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 25EC9C4CEE5; Sat, 15 Mar 2025 20:16:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1742069768; bh=yxt53pJS4LPQZZrMvULyJRtF3Mxw2qD3s3q527wIweA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=JDiS+o2VA6dvEjyUCWHUgJVtTZMxCiJKSKIs555J67zRmOwxkO0/8fjNv5SMBxRln 8c/kNjeX14+Hqn2cR4gyXmMLUjvFg8IBYl0gXMrOvzVbPZFC/pDgtbyfG9pqCNon6g FaKmNSX2C61vK0my7c1zdlyA6JmGs/LEIxnvaCSjbBQDNPNMHJs3EZnuNA8o3U9L+z oSoBsRKwmkj+V7Pt+OCNmX0+YeCM2hcgre0jmek/ZdBGjVAsnPbabT8itNnfYmfDGY 0Cv0SY8DIqJ5r9dsAAbPDOedItN3LY5ULYon8ODOCmTuxBy8DaJ/jiMYPgzUTEy4Fj iaJqOSOY/FT8w== From: Bjorn Helgaas To: Frank Li Cc: Rob Herring , Saravana Kannan , Jingoo Han , Manivannan Sadhasivam , Lorenzo Pieralisi , =?utf-8?q?Krzysztof_Wilczy=C5=84?= =?utf-8?q?ski?= , Richard Zhu , Lucas Stach , Shawn Guo , Sascha Hauer , Fabio Estevam , Niklas Cassel , Pengutronix Kernel Team , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev, Bjorn Helgaas Subject: [PATCH v12 08/13] PCI: dwc: ep: Call epc_create() early in dw_pcie_ep_init() Date: Sat, 15 Mar 2025 15:15:43 -0500 Message-Id: <20250315201548.858189-9-helgaas@kernel.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250315201548.858189-1-helgaas@kernel.org> References: <20250315201548.858189-1-helgaas@kernel.org> Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: Bjorn Helgaas Move devm_pci_epc_create() to the beginning of dw_pcie_ep_init(). devm_pci_epc_create() is generic code that doesn't depend on any DWC resource, so moving it earlier keeps all the subsequent devicetree-related code together. Signed-off-by: Bjorn Helgaas Reviewed-by: Frank Li --- .../pci/controller/dwc/pcie-designware-ep.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/pci/controller/dwc/pcie-designware-ep.c b/drivers/pci/controller/dwc/pcie-designware-ep.c index 80ac2f9e88eb..100d26466f05 100644 --- a/drivers/pci/controller/dwc/pcie-designware-ep.c +++ b/drivers/pci/controller/dwc/pcie-designware-ep.c @@ -904,6 +904,15 @@ int dw_pcie_ep_init(struct dw_pcie_ep *ep) INIT_LIST_HEAD(&ep->func_list); + epc = devm_pci_epc_create(dev, &epc_ops); + if (IS_ERR(epc)) { + dev_err(dev, "Failed to create epc device\n"); + return PTR_ERR(epc); + } + + ep->epc = epc; + epc_set_drvdata(epc, ep); + ret = dw_pcie_get_resources(pci); if (ret) return ret; @@ -918,15 +927,6 @@ int dw_pcie_ep_init(struct dw_pcie_ep *ep) if (ep->ops->pre_init) ep->ops->pre_init(ep); - epc = devm_pci_epc_create(dev, &epc_ops); - if (IS_ERR(epc)) { - dev_err(dev, "Failed to create epc device\n"); - return PTR_ERR(epc); - } - - ep->epc = epc; - epc_set_drvdata(epc, ep); - ret = of_property_read_u8(np, "max-functions", &epc->max_functions); if (ret < 0) epc->max_functions = 1;