| Message ID | 20250417074607.2281010-1-vidyas@nvidia.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [V3] PCI: dwc: tegra194: Broaden architecture dependency | expand |
+CC PHY maintainer. On Thu, Apr 17, 2025 at 01:16:07PM +0530, Vidya Sagar wrote: > Replace ARCH_TEGRA_194_SOC dependency with a more generic ARCH_TEGRA > check, allowing the PCIe controller to be built on Tegra platforms > beyond Tegra194. Additionally, ensure compatibility by requiring > ARM64 or COMPILE_TEST. > > Link: https://patchwork.kernel.org/project/linux-pci/patch/20250128044244.2766334-1-vidyas@nvidia.com/ > Signed-off-by: Vidya Sagar <vidyas@nvidia.com> > --- > v3: > * Addressed warning from kernel test robot > > v2: > * Addressed review comments from Niklas Cassel and Manivannan Sadhasivam > > drivers/pci/controller/dwc/Kconfig | 4 ++-- > drivers/phy/tegra/Kconfig | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/pci/controller/dwc/Kconfig b/drivers/pci/controller/dwc/Kconfig > index d9f0386396ed..815b6e0d6a0c 100644 > --- a/drivers/pci/controller/dwc/Kconfig > +++ b/drivers/pci/controller/dwc/Kconfig > @@ -226,7 +226,7 @@ config PCIE_TEGRA194 > > config PCIE_TEGRA194_HOST > tristate "NVIDIA Tegra194 (and later) PCIe controller (host mode)" > - depends on ARCH_TEGRA_194_SOC || COMPILE_TEST > + depends on ARCH_TEGRA && (ARM64 || COMPILE_TEST) > depends on PCI_MSI > select PCIE_DW_HOST > select PHY_TEGRA194_P2U > @@ -241,7 +241,7 @@ config PCIE_TEGRA194_HOST > > config PCIE_TEGRA194_EP > tristate "NVIDIA Tegra194 (and later) PCIe controller (endpoint mode)" > - depends on ARCH_TEGRA_194_SOC || COMPILE_TEST > + depends on ARCH_TEGRA && (ARM64 || COMPILE_TEST) > depends on PCI_ENDPOINT > select PCIE_DW_EP > select PHY_TEGRA194_P2U > diff --git a/drivers/phy/tegra/Kconfig b/drivers/phy/tegra/Kconfig > index f30cfb42b210..342fb736da4b 100644 > --- a/drivers/phy/tegra/Kconfig > +++ b/drivers/phy/tegra/Kconfig > @@ -13,7 +13,7 @@ config PHY_TEGRA_XUSB > > config PHY_TEGRA194_P2U > tristate "NVIDIA Tegra194 PIPE2UPHY PHY driver" > - depends on ARCH_TEGRA_194_SOC || ARCH_TEGRA_234_SOC || COMPILE_TEST > + depends on ARCH_TEGRA || COMPILE_TEST > select GENERIC_PHY > help > Enable this to support the P2U (PIPE to UPHY) that is part of Tegra 19x > -- > 2.25.1 >
On 17-04-25, 09:51, Niklas Cassel wrote: > +CC PHY maintainer. > > On Thu, Apr 17, 2025 at 01:16:07PM +0530, Vidya Sagar wrote: > > Replace ARCH_TEGRA_194_SOC dependency with a more generic ARCH_TEGRA > > check, allowing the PCIe controller to be built on Tegra platforms > > beyond Tegra194. Additionally, ensure compatibility by requiring > > ARM64 or COMPILE_TEST. > > > > Link: https://patchwork.kernel.org/project/linux-pci/patch/20250128044244.2766334-1-vidyas@nvidia.com/ > > Signed-off-by: Vidya Sagar <vidyas@nvidia.com> > > --- > > v3: > > * Addressed warning from kernel test robot > > > > v2: > > * Addressed review comments from Niklas Cassel and Manivannan Sadhasivam > > > > drivers/pci/controller/dwc/Kconfig | 4 ++-- > > drivers/phy/tegra/Kconfig | 2 +- can phy and pci be two different patches? > > 2 files changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/pci/controller/dwc/Kconfig b/drivers/pci/controller/dwc/Kconfig > > index d9f0386396ed..815b6e0d6a0c 100644 > > --- a/drivers/pci/controller/dwc/Kconfig > > +++ b/drivers/pci/controller/dwc/Kconfig > > @@ -226,7 +226,7 @@ config PCIE_TEGRA194 > > > > config PCIE_TEGRA194_HOST > > tristate "NVIDIA Tegra194 (and later) PCIe controller (host mode)" > > - depends on ARCH_TEGRA_194_SOC || COMPILE_TEST > > + depends on ARCH_TEGRA && (ARM64 || COMPILE_TEST) > > depends on PCI_MSI > > select PCIE_DW_HOST > > select PHY_TEGRA194_P2U > > @@ -241,7 +241,7 @@ config PCIE_TEGRA194_HOST > > > > config PCIE_TEGRA194_EP > > tristate "NVIDIA Tegra194 (and later) PCIe controller (endpoint mode)" > > - depends on ARCH_TEGRA_194_SOC || COMPILE_TEST > > + depends on ARCH_TEGRA && (ARM64 || COMPILE_TEST) > > depends on PCI_ENDPOINT > > select PCIE_DW_EP > > select PHY_TEGRA194_P2U > > diff --git a/drivers/phy/tegra/Kconfig b/drivers/phy/tegra/Kconfig > > index f30cfb42b210..342fb736da4b 100644 > > --- a/drivers/phy/tegra/Kconfig > > +++ b/drivers/phy/tegra/Kconfig > > @@ -13,7 +13,7 @@ config PHY_TEGRA_XUSB > > > > config PHY_TEGRA194_P2U > > tristate "NVIDIA Tegra194 PIPE2UPHY PHY driver" > > - depends on ARCH_TEGRA_194_SOC || ARCH_TEGRA_234_SOC || COMPILE_TEST > > + depends on ARCH_TEGRA || COMPILE_TEST > > select GENERIC_PHY > > help > > Enable this to support the P2U (PIPE to UPHY) that is part of Tegra 19x > > -- > > 2.25.1 > >
On Thu, Apr 17, 2025 at 01:16:07PM +0530, Vidya Sagar wrote: > Replace ARCH_TEGRA_194_SOC dependency with a more generic ARCH_TEGRA > check, allowing the PCIe controller to be built on Tegra platforms > beyond Tegra194. Additionally, ensure compatibility by requiring > ARM64 or COMPILE_TEST. > > Link: https://patchwork.kernel.org/project/linux-pci/patch/20250128044244.2766334-1-vidyas@nvidia.com/ > Signed-off-by: Vidya Sagar <vidyas@nvidia.com> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> - Mani > --- > v3: > * Addressed warning from kernel test robot > > v2: > * Addressed review comments from Niklas Cassel and Manivannan Sadhasivam > > drivers/pci/controller/dwc/Kconfig | 4 ++-- > drivers/phy/tegra/Kconfig | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/pci/controller/dwc/Kconfig b/drivers/pci/controller/dwc/Kconfig > index d9f0386396ed..815b6e0d6a0c 100644 > --- a/drivers/pci/controller/dwc/Kconfig > +++ b/drivers/pci/controller/dwc/Kconfig > @@ -226,7 +226,7 @@ config PCIE_TEGRA194 > > config PCIE_TEGRA194_HOST > tristate "NVIDIA Tegra194 (and later) PCIe controller (host mode)" > - depends on ARCH_TEGRA_194_SOC || COMPILE_TEST > + depends on ARCH_TEGRA && (ARM64 || COMPILE_TEST) > depends on PCI_MSI > select PCIE_DW_HOST > select PHY_TEGRA194_P2U > @@ -241,7 +241,7 @@ config PCIE_TEGRA194_HOST > > config PCIE_TEGRA194_EP > tristate "NVIDIA Tegra194 (and later) PCIe controller (endpoint mode)" > - depends on ARCH_TEGRA_194_SOC || COMPILE_TEST > + depends on ARCH_TEGRA && (ARM64 || COMPILE_TEST) > depends on PCI_ENDPOINT > select PCIE_DW_EP > select PHY_TEGRA194_P2U > diff --git a/drivers/phy/tegra/Kconfig b/drivers/phy/tegra/Kconfig > index f30cfb42b210..342fb736da4b 100644 > --- a/drivers/phy/tegra/Kconfig > +++ b/drivers/phy/tegra/Kconfig > @@ -13,7 +13,7 @@ config PHY_TEGRA_XUSB > > config PHY_TEGRA194_P2U > tristate "NVIDIA Tegra194 PIPE2UPHY PHY driver" > - depends on ARCH_TEGRA_194_SOC || ARCH_TEGRA_234_SOC || COMPILE_TEST > + depends on ARCH_TEGRA || COMPILE_TEST > select GENERIC_PHY > help > Enable this to support the P2U (PIPE to UPHY) that is part of Tegra 19x > -- > 2.25.1 >
diff --git a/drivers/pci/controller/dwc/Kconfig b/drivers/pci/controller/dwc/Kconfig index d9f0386396ed..815b6e0d6a0c 100644 --- a/drivers/pci/controller/dwc/Kconfig +++ b/drivers/pci/controller/dwc/Kconfig @@ -226,7 +226,7 @@ config PCIE_TEGRA194 config PCIE_TEGRA194_HOST tristate "NVIDIA Tegra194 (and later) PCIe controller (host mode)" - depends on ARCH_TEGRA_194_SOC || COMPILE_TEST + depends on ARCH_TEGRA && (ARM64 || COMPILE_TEST) depends on PCI_MSI select PCIE_DW_HOST select PHY_TEGRA194_P2U @@ -241,7 +241,7 @@ config PCIE_TEGRA194_HOST config PCIE_TEGRA194_EP tristate "NVIDIA Tegra194 (and later) PCIe controller (endpoint mode)" - depends on ARCH_TEGRA_194_SOC || COMPILE_TEST + depends on ARCH_TEGRA && (ARM64 || COMPILE_TEST) depends on PCI_ENDPOINT select PCIE_DW_EP select PHY_TEGRA194_P2U diff --git a/drivers/phy/tegra/Kconfig b/drivers/phy/tegra/Kconfig index f30cfb42b210..342fb736da4b 100644 --- a/drivers/phy/tegra/Kconfig +++ b/drivers/phy/tegra/Kconfig @@ -13,7 +13,7 @@ config PHY_TEGRA_XUSB config PHY_TEGRA194_P2U tristate "NVIDIA Tegra194 PIPE2UPHY PHY driver" - depends on ARCH_TEGRA_194_SOC || ARCH_TEGRA_234_SOC || COMPILE_TEST + depends on ARCH_TEGRA || COMPILE_TEST select GENERIC_PHY help Enable this to support the P2U (PIPE to UPHY) that is part of Tegra 19x
Replace ARCH_TEGRA_194_SOC dependency with a more generic ARCH_TEGRA check, allowing the PCIe controller to be built on Tegra platforms beyond Tegra194. Additionally, ensure compatibility by requiring ARM64 or COMPILE_TEST. Link: https://patchwork.kernel.org/project/linux-pci/patch/20250128044244.2766334-1-vidyas@nvidia.com/ Signed-off-by: Vidya Sagar <vidyas@nvidia.com> --- v3: * Addressed warning from kernel test robot v2: * Addressed review comments from Niklas Cassel and Manivannan Sadhasivam drivers/pci/controller/dwc/Kconfig | 4 ++-- drivers/phy/tegra/Kconfig | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-)