From patchwork Fri Dec 30 01:40:45 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Rafael J. Wysocki" X-Patchwork-Id: 9491693 X-Patchwork-Delegate: bhelgaas@google.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 907AC60488 for ; Fri, 30 Dec 2016 01:45:06 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 729181FE82 for ; Fri, 30 Dec 2016 01:45:06 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 642EB200F5; Fri, 30 Dec 2016 01:45:06 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 548481FE82 for ; Fri, 30 Dec 2016 01:45:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752946AbcL3Bov (ORCPT ); Thu, 29 Dec 2016 20:44:51 -0500 Received: from cloudserver094114.home.net.pl ([79.96.170.134]:44690 "EHLO cloudserver094114.home.net.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751579AbcL3Bov (ORCPT ); Thu, 29 Dec 2016 20:44:51 -0500 Received: from adkt146.ipv4.supernova.orange.pl (79.184.253.146) (HELO aspire.rjw.lan) by serwer1319399.home.pl (79.96.170.134) with SMTP (IdeaSmtpServer 0.81.1) id 50449b9ad0becbad; Fri, 30 Dec 2016 02:44:51 +0100 From: "Rafael J. Wysocki" To: Kilian Singer Cc: Lukas Wunner , Bjorn Helgaas , linux-pci , Mika Westerberg , "Rafael J. Wysocki" Subject: Re: PCI: Revert "PCI: Add runtime PM support for PCIe ports" Date: Fri, 30 Dec 2016 02:40:45 +0100 Message-ID: <2678604.V2vzbbOmVS@aspire.rjw.lan> User-Agent: KMail/4.14.10 (Linux/4.10.0-rc1+; KDE/4.14.9; x86_64; ; ) In-Reply-To: References: <20161227235737.GB24366@bhelgaas-glaptop.roam.corp.google.com> <2589829.sCArIQeDWm@aspire.rjw.lan> MIME-Version: 1.0 Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Friday, December 30, 2016 01:45:53 AM Kilian Singer wrote: > The touchpad and builtin keyboard of laptop fail. > But also connected usb keyboard and usb mouse fail. > > In both cases mouse pointer is still moveable. It may just be too late to turn the ports "on" once they have been suspended at least once on your system. Please check if the appended patch makes any difference. Thanks, Rafael --- drivers/pci/pcie/portdrv_pci.c | 2 -- 1 file changed, 2 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Index: linux-pm/drivers/pci/pcie/portdrv_pci.c =================================================================== --- linux-pm.orig/drivers/pci/pcie/portdrv_pci.c +++ linux-pm/drivers/pci/pcie/portdrv_pci.c @@ -160,7 +160,6 @@ static int pcie_portdrv_probe(struct pci pm_runtime_use_autosuspend(&dev->dev); pm_runtime_mark_last_busy(&dev->dev); pm_runtime_put_autosuspend(&dev->dev); - pm_runtime_allow(&dev->dev); } return 0; @@ -169,7 +168,6 @@ static int pcie_portdrv_probe(struct pci static void pcie_portdrv_remove(struct pci_dev *dev) { if (pci_bridge_d3_possible(dev)) { - pm_runtime_forbid(&dev->dev); pm_runtime_get_noresume(&dev->dev); pm_runtime_dont_use_autosuspend(&dev->dev); }