| Message ID | 2ba22558b5db90740d5833c35570c3e7cc1e359e.1394128952.git.agordeev@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Delegated to: | Bjorn Helgaas |
| Headers | show |
On Thu, Mar 6, 2014 at 12:11 PM, Alexander Gordeev <agordeev@redhat.com> wrote: > As result of deprecation of MSI-X/MSI enablement functions > pci_enable_msix() and pci_enable_msi_block() all drivers > using these two interfaces need to be updated to use the > new pci_enable_msi_range() or pci_enable_msi_exact() > and pci_enable_msix_range() or pci_enable_msix_exact() > interfaces. > > Signed-off-by: Alexander Gordeev <agordeev@redhat.com> > Cc: Dan Williams <dan.j.williams@intel.com> > Cc: Vinod Koul <vinod.koul@intel.com> > Cc: dmaengine@vger.kernel.org > Cc: linux-pci@vger.kernel.org > --- Can you point me to the background for this change. From the changelog I have no idea what this patch does or why I need to apply it. -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Mar 06, 2014 at 01:09:39PM -0800, Dan Williams wrote: > Can you point me to the background for this change. From the > changelog I have no idea what this patch does or why I need to apply > it. Function pci_enable_msix() returns a tri-state value while pci_enable_msi_exact() is a canonical zero/-errno variant. The former is being phased out in favor of the latter. In case of 'ioat' there (should be) no difference. HTH.
On Thu, Mar 6, 2014 at 1:43 PM, Alexander Gordeev <agordeev@redhat.com> wrote: > On Thu, Mar 06, 2014 at 01:09:39PM -0800, Dan Williams wrote: >> Can you point me to the background for this change. From the >> changelog I have no idea what this patch does or why I need to apply >> it. > > Function pci_enable_msix() returns a tri-state value while > pci_enable_msi_exact() is a canonical zero/-errno variant. > The former is being phased out in favor of the latter. > In case of 'ioat' there (should be) no difference. Got it. If you resend with that in the changelog. Acked-by: Dan Williams <dan.j.williams@intel.com> -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/dma/ioat/dma.c b/drivers/dma/ioat/dma.c index 4e3549a..b76c148 100644 --- a/drivers/dma/ioat/dma.c +++ b/drivers/dma/ioat/dma.c @@ -947,7 +947,7 @@ msix: for (i = 0; i < msixcnt; i++) device->msix_entries[i].entry = i; - err = pci_enable_msix(pdev, device->msix_entries, msixcnt); + err = pci_enable_msix_exact(pdev, device->msix_entries, msixcnt); if (err) goto msi;
As result of deprecation of MSI-X/MSI enablement functions pci_enable_msix() and pci_enable_msi_block() all drivers using these two interfaces need to be updated to use the new pci_enable_msi_range() or pci_enable_msi_exact() and pci_enable_msix_range() or pci_enable_msix_exact() interfaces. Signed-off-by: Alexander Gordeev <agordeev@redhat.com> Cc: Dan Williams <dan.j.williams@intel.com> Cc: Vinod Koul <vinod.koul@intel.com> Cc: dmaengine@vger.kernel.org Cc: linux-pci@vger.kernel.org --- drivers/dma/ioat/dma.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)