| Message ID | 49E992C2.4010707@kernel.org (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers | show |
* Yinghai Lu <yinghai@kernel.org> wrote: > e820_all_mapped need end is (addr + size) instead of (addr + size - 1) > > [Impact: fix -1 offset calling] > > Signed-off-by: Yinghai Lu <yinghai@kernel.org> > > --- > arch/x86/pci/mmconfig-shared.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > Index: linux-2.6/arch/x86/pci/mmconfig-shared.c > =================================================================== > --- linux-2.6.orig/arch/x86/pci/mmconfig-shared.c > +++ linux-2.6/arch/x86/pci/mmconfig-shared.c > @@ -375,7 +375,7 @@ static acpi_status __init check_mcfg_res > if (!fixmem32) > return AE_OK; > if ((mcfg_res->start >= fixmem32->address) && > - (mcfg_res->end < (fixmem32->address + > + (mcfg_res->end <= (fixmem32->address + > fixmem32->address_length))) { > mcfg_res->flags = 1; > return AE_CTRL_TERMINATE; > @@ -392,7 +392,7 @@ static acpi_status __init check_mcfg_res > return AE_OK; > > if ((mcfg_res->start >= address.minimum) && > - (mcfg_res->end < (address.minimum + address.address_length))) { > + (mcfg_res->end <= (address.minimum + address.address_length))) { > mcfg_res->flags = 1; > return AE_CTRL_TERMINATE; > } > @@ -439,7 +439,7 @@ static int __init is_mmconf_reserved(che > u64 old_size = size; > int valid = 0; > > - while (!is_reserved(addr, addr + size - 1, E820_RESERVED)) { > + while (!is_reserved(addr, addr + size, E820_RESERVED)) { > size >>= 1; > if (size < (16UL<<20)) > break; good catch. Probably also needed for -stable. Acked-by: Ingo Molnar <mingo@elte.hu> Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Sat, 18 Apr 2009 01:43:46 -0700 Yinghai Lu <yinghai@kernel.org> wrote: > > e820_all_mapped need end is (addr + size) instead of (addr + size - 1) > > [Impact: fix -1 offset calling] > > Signed-off-by: Yinghai Lu <yinghai@kernel.org> Applied, thanks.
Index: linux-2.6/arch/x86/pci/mmconfig-shared.c =================================================================== --- linux-2.6.orig/arch/x86/pci/mmconfig-shared.c +++ linux-2.6/arch/x86/pci/mmconfig-shared.c @@ -375,7 +375,7 @@ static acpi_status __init check_mcfg_res if (!fixmem32) return AE_OK; if ((mcfg_res->start >= fixmem32->address) && - (mcfg_res->end < (fixmem32->address + + (mcfg_res->end <= (fixmem32->address + fixmem32->address_length))) { mcfg_res->flags = 1; return AE_CTRL_TERMINATE; @@ -392,7 +392,7 @@ static acpi_status __init check_mcfg_res return AE_OK; if ((mcfg_res->start >= address.minimum) && - (mcfg_res->end < (address.minimum + address.address_length))) { + (mcfg_res->end <= (address.minimum + address.address_length))) { mcfg_res->flags = 1; return AE_CTRL_TERMINATE; } @@ -439,7 +439,7 @@ static int __init is_mmconf_reserved(che u64 old_size = size; int valid = 0; - while (!is_reserved(addr, addr + size - 1, E820_RESERVED)) { + while (!is_reserved(addr, addr + size, E820_RESERVED)) { size >>= 1; if (size < (16UL<<20)) break;
e820_all_mapped need end is (addr + size) instead of (addr + size - 1) [Impact: fix -1 offset calling] Signed-off-by: Yinghai Lu <yinghai@kernel.org> --- arch/x86/pci/mmconfig-shared.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html