| Message ID | 49E99355.6090609@kernel.org (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers | show |
* Yinghai Lu <yinghai@kernel.org> wrote: > > also print out if it is prefetechable mmio > > [Impact: cleanup] > > Signed-off-by: Yinghai Lu <yinghai@kernel.org> > > --- > drivers/pci/setup-bus.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > Index: linux-2.6/drivers/pci/setup-bus.c > =================================================================== > --- linux-2.6.orig/drivers/pci/setup-bus.c > +++ linux-2.6/drivers/pci/setup-bus.c > @@ -558,11 +558,13 @@ static void pci_bus_dump_res(struct pci_ > > for (i = 0; i < PCI_BUS_NUM_RESOURCES; i++) { > struct resource *res = bus->resource[i]; > - if (!res) > + if (!res || !res->end) > continue; > > dev_printk(KERN_DEBUG, &bus->dev, "resource %d %s %pR\n", i, > - (res->flags & IORESOURCE_IO) ? "io: " : "mem:", res); > + (res->flags & IORESOURCE_IO) ? "io: " : > + ((res->flags & IORESOURCE_PREFETCH)? "pref mem":"mem:"), > + res); 'pref mem' is easily mistaken for 'preferential memory' or something similar. Would printing "prefetchable-mem" still be OK? Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Index: linux-2.6/drivers/pci/setup-bus.c =================================================================== --- linux-2.6.orig/drivers/pci/setup-bus.c +++ linux-2.6/drivers/pci/setup-bus.c @@ -558,11 +558,13 @@ static void pci_bus_dump_res(struct pci_ for (i = 0; i < PCI_BUS_NUM_RESOURCES; i++) { struct resource *res = bus->resource[i]; - if (!res) + if (!res || !res->end) continue; dev_printk(KERN_DEBUG, &bus->dev, "resource %d %s %pR\n", i, - (res->flags & IORESOURCE_IO) ? "io: " : "mem:", res); + (res->flags & IORESOURCE_IO) ? "io: " : + ((res->flags & IORESOURCE_PREFETCH)? "pref mem":"mem:"), + res); } }
also print out if it is prefetechable mmio [Impact: cleanup] Signed-off-by: Yinghai Lu <yinghai@kernel.org> --- drivers/pci/setup-bus.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html