From patchwork Tue Jul 22 16:17:18 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Tony Luck X-Patchwork-Id: 4604121 X-Patchwork-Delegate: bhelgaas@google.com Return-Path: X-Original-To: patchwork-linux-pci@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 1F8A49F295 for ; Tue, 22 Jul 2014 16:17:52 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 35BA32016C for ; Tue, 22 Jul 2014 16:17:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4FAF820158 for ; Tue, 22 Jul 2014 16:17:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755304AbaGVQRp (ORCPT ); Tue, 22 Jul 2014 12:17:45 -0400 Received: from mga11.intel.com ([192.55.52.93]:28288 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756066AbaGVQRa (ORCPT ); Tue, 22 Jul 2014 12:17:30 -0400 Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP; 22 Jul 2014 09:17:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.01,710,1400050800"; d="scan'208";a="565527044" Received: from scymds01.sc.intel.com ([10.82.194.37]) by fmsmga001.fm.intel.com with ESMTP; 22 Jul 2014 09:17:19 -0700 Received: from agluck-desk.sc.intel.com (agluck-desk.sc.intel.com [10.3.52.83]) by scymds01.sc.intel.com with SMTP id s6MGHIJe018710; Tue, 22 Jul 2014 09:17:18 -0700 From: "Luck, Tony" To: Linus Torvalds Cc: Mike Qiu , Randy Dunlap , Bjorn Helgaas , linux-pci@vger.kernel.org In-reply-to: Subject: [PATCH] Fix build warnings in aer.h Date: Tue, 22 Jul 2014 09:17:18 -0700 Message-Id: <53ce8e8e22217dde72@agluck-desk.sc.intel.com> Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Mike Qiu build log: In file included from include/ras/ras_event.h:11:0, from drivers/ras/ras.c:13: include/linux/aer.h:42:129: warning: ‘struct pci_dev’ declared inside parameter list [enabled by default] include/linux/aer.h:42:129: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default] include/linux/aer.h:46:130: warning: ‘struct pci_dev’ declared inside parameter list [enabled by default] include/linux/aer.h:50:136: warning: ‘struct pci_dev’ declared inside parameter list [enabled by default] include/linux/aer.h:57:14: warning: ‘struct pci_dev’ declared inside parameter list [enabled by default] Signed-off-by: Mike Qiu Acked-by: Randy Dunlap Tested-by: Randy Dunlap Acked-by: Bjorn Helgaas Signed-off-by: Tony Luck --- include/linux/aer.h | 2 ++ 1 file changed, 2 insertions(+) Linus: The breakage that this fixes is actually only in linux-next, but the commits that found this gap are already in the tip tree, so hard to rebase to get this fix ahead of them to avoid a bisection gap. But since this is so obvious - perhaps it can go into 3.16? If you don't want it, I'll ask hpa to add it to the right topic branch in tip so it is at least close to the commit that reveals the gap. diff --git a/include/linux/aer.h b/include/linux/aer.h index 4dbaa70..c826d1c 100644 --- a/include/linux/aer.h +++ b/include/linux/aer.h @@ -11,6 +11,8 @@ #define AER_FATAL 1 #define AER_CORRECTABLE 2 +struct pci_dev; + struct aer_header_log_regs { unsigned int dw0; unsigned int dw1;