From patchwork Tue Jul 29 17:49:25 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Tony Luck X-Patchwork-Id: 4641711 X-Patchwork-Delegate: bhelgaas@google.com Return-Path: X-Original-To: patchwork-linux-pci@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id E66389F2B8 for ; Tue, 29 Jul 2014 17:49:30 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 19A7120142 for ; Tue, 29 Jul 2014 17:49:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 123A520127 for ; Tue, 29 Jul 2014 17:49:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751165AbaG2Rt2 (ORCPT ); Tue, 29 Jul 2014 13:49:28 -0400 Received: from mga02.intel.com ([134.134.136.20]:3795 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751066AbaG2Rt1 (ORCPT ); Tue, 29 Jul 2014 13:49:27 -0400 Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP; 29 Jul 2014 10:49:27 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.01,758,1400050800"; d="scan'208";a="580757647" Received: from scymds02.sc.intel.com ([10.82.195.37]) by orsmga002.jf.intel.com with ESMTP; 29 Jul 2014 10:49:27 -0700 Received: from agluck-desk.sc.intel.com (agluck-desk.sc.intel.com [10.3.52.83]) by scymds02.sc.intel.com with SMTP id s6THnOvm009066; Tue, 29 Jul 2014 10:49:24 -0700 From: "Luck, Tony" To: "H. Peter Anvin" Cc: Mike Qiu , Randy Dunlap , Bjorn Helgaas , linux-pci@vger.kernel.org Subject: [PATCH] Fix build warnings in aer.h Date: Tue, 29 Jul 2014 10:49:25 -0700 Message-Id: <53d7dea511471321bb@agluck-desk.sc.intel.com> Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Mike Qiu build log: In file included from include/ras/ras_event.h:11:0, from drivers/ras/ras.c:13: include/linux/aer.h:42:129: warning: ‘struct pci_dev’ declared inside parameter list [enabled by default] include/linux/aer.h:42:129: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default] include/linux/aer.h:46:130: warning: ‘struct pci_dev’ declared inside parameter list [enabled by default] include/linux/aer.h:50:136: warning: ‘struct pci_dev’ declared inside parameter list [enabled by default] include/linux/aer.h:57:14: warning: ‘struct pci_dev’ declared inside parameter list [enabled by default] Signed-off-by: Mike Qiu Acked-by: Randy Dunlap Tested-by: Randy Dunlap Acked-by: Bjorn Helgaas Signed-off-by: Tony Luck --- include/linux/aer.h | 2 ++ 1 file changed, 2 insertions(+) Peter: Can you add this to the x86/ras branch in the tip tree. There's a change in there that is breaking randconfig builds in linux-next because something includes aer.h without including pci.h ... which ought to be legal as aer.h needs to take responsibility for making sure that it resolves dependencies itself. diff --git a/include/linux/aer.h b/include/linux/aer.h index 4dbaa70..c826d1c 100644 --- a/include/linux/aer.h +++ b/include/linux/aer.h @@ -11,6 +11,8 @@ #define AER_FATAL 1 #define AER_CORRECTABLE 2 +struct pci_dev; + struct aer_header_log_regs { unsigned int dw0; unsigned int dw1;