From patchwork Wed Mar 22 03:27:23 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zhou Wang X-Patchwork-Id: 9638063 X-Patchwork-Delegate: bhelgaas@google.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 9AC3C602D6 for ; Wed, 22 Mar 2017 03:27:52 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8BC4628304 for ; Wed, 22 Mar 2017 03:27:52 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 7F3A62830A; Wed, 22 Mar 2017 03:27:52 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D091E28304 for ; Wed, 22 Mar 2017 03:27:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758622AbdCVD1v (ORCPT ); Tue, 21 Mar 2017 23:27:51 -0400 Received: from szxga01-in.huawei.com ([45.249.212.187]:4783 "EHLO dggrg01-dlp.huawei.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1758615AbdCVD1u (ORCPT ); Tue, 21 Mar 2017 23:27:50 -0400 Received: from 172.30.72.55 (EHLO DGGEML402-HUB.china.huawei.com) ([172.30.72.55]) by dggrg01-dlp.huawei.com (MOS 4.4.6-GA FastPath queued) with ESMTP id ALD42604; Wed, 22 Mar 2017 11:27:32 +0800 (CST) Received: from [127.0.0.1] (10.63.139.185) by DGGEML402-HUB.china.huawei.com (10.3.17.38) with Microsoft SMTP Server id 14.3.301.0; Wed, 22 Mar 2017 11:27:23 +0800 Subject: Re: [PATCH] pci: dwc: hisi needs PCI_HOST_COMMON To: Jingoo Han , "'Arnd Bergmann'" , "'Bjorn Helgaas'" , "'Kishon Vijay Abraham I'" References: <20170321143229.3372903-1-arnd@arndb.de> <001801d2a25a$9c742760$d55c7620$@gmail.com> CC: , , "'Joao Pinto'" , "'Gabriele Paoloni'" From: Zhou Wang Message-ID: <58D1EF1B.1080509@hisilicon.com> Date: Wed, 22 Mar 2017 11:27:23 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <001801d2a25a$9c742760$d55c7620$@gmail.com> X-Originating-IP: [10.63.139.185] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A090203.58D1EF25.007E, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0, ip=0.0.0.0, so=2014-11-16 11:51:01, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 6904e8cc9df8b0652b84393d37a19883 Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On 2017/3/21 23:48, Jingoo Han wrote: > (+cc: Joao Pinto, Zhou Wang, Gabriele Paoloni) > > On Tuesday, March 21, 2017 10:32 AM, Arnd Bergmann wrote: >> >> Without PCI_HOST_COMMON support enabled, we get a link error: >> >> drivers/pci/dwc/built-in.o: In function `hisi_pcie_map_bus': >> pcie-hisi.c:(.text+0x8860): undefined reference to `pci_ecam_map_bus' >> drivers/pci/dwc/built-in.o: In function `hisi_pcie_almost_ecam_probe': >> pcie-hisi.c:(.text+0x88b4): undefined reference to `pci_host_common_probe' >> >> This adds an explicit 'select', as the other users have. Hi Arnd, I wonder if we should select PCI_HOST_GENERIC here, like: Thanks, Zhou >> >> Signed-off-by: Arnd Bergmann > > Acked-by: Jingoo Han > > Best regards, > Jingoo Han > >> --- >> drivers/pci/dwc/Kconfig | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/pci/dwc/Kconfig b/drivers/pci/dwc/Kconfig >> index dfb8a69afc28..d2d2ba5b8a68 100644 >> --- a/drivers/pci/dwc/Kconfig >> +++ b/drivers/pci/dwc/Kconfig >> @@ -89,6 +89,7 @@ config PCI_HISI >> depends on PCI_MSI_IRQ_DOMAIN >> select PCIEPORTBUS >> select PCIE_DW_HOST >> + select PCI_HOST_COMMON >> help >> Say Y here if you want PCIe controller support on HiSilicon >> Hip05 and Hip06 SoCs >> -- >> 2.9.0 > > > > . > diff --git a/drivers/pci/dwc/Kconfig b/drivers/pci/dwc/Kconfig index dfb8a69..b25dce4 100644 --- a/drivers/pci/dwc/Kconfig +++ b/drivers/pci/dwc/Kconfig @@ -89,6 +89,7 @@ config PCI_HISI depends on PCI_MSI_IRQ_DOMAIN select PCIEPORTBUS select PCIE_DW_HOST + select PCI_HOST_GENERIC help Say Y here if you want PCIe controller support on HiSilicon Hip05 and Hip06 SoCs diff --git a/drivers/pci/host/Kconfig b/drivers/pci/host/Kconfig index f7c1d4d..e7a24d0 100644 --- a/drivers/pci/host/Kconfig +++ b/drivers/pci/host/Kconfig @@ -151,7 +151,7 @@ config PCI_HOST_THUNDER_PEM bool "Cavium Thunder PCIe controller to off-chip devices" depends on ARM64 depends on OF || (ACPI && PCI_QUIRKS) - select PCI_HOST_COMMON + select PCI_HOST_GENERIC help Say Y here if you want PCIe support for CN88XX Cavium Thunder SoCs. @@ -159,7 +159,7 @@ config PCI_HOST_THUNDER_ECAM bool "Cavium Thunder ECAM controller to on-chip devices on pass-1.x silicon" depends on ARM64 depends on OF || (ACPI && PCI_QUIRKS) - select PCI_HOST_COMMON + select PCI_HOST_GENERIC help Say Y here if you want ECAM support for CN88XX-Pass-1.x Cavium Thunder SoCs.