From patchwork Mon Dec 16 19:18:41 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lukas Wunner X-Patchwork-Id: 13910233 X-Patchwork-Delegate: kw@linux.com Received: from bmailout2.hostsharing.net (bmailout2.hostsharing.net [83.223.78.240]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 50D36207663 for ; Mon, 16 Dec 2024 19:19:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=83.223.78.240 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734376769; cv=none; b=XiqKbof0T0GZhkAcqMnATK0wmGFLO970EBsDh3jWSTfxCbSplGfLssaGN9JPpBQ8kcoIzeNjbbt7Nc21uRJNY4QP/tbjqDsKyzaZAgJPlvf82bTa4VTTJuFyZbxwIFiT2jz7gZIuMqe3fL4w51IiVJIt+tC3gEQtjxr7EP65dUE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734376769; c=relaxed/simple; bh=hqkrGC8unCX44MpjDo3S6+IbaSP0BST/wISUHxRLyBA=; h=Message-Id:From:Date:Subject:MIME-Version:Content-Type:To:Cc; b=luWTt+U+H8d12gIklwnE1b/tbLwoShMdonU1IjpmufuFX3s2Nya02xE8me88jYEVTEu39XwLH0WlGXzF6riA8iSxnKdpRiT58ocw5H4V9799tLkPFfNy8o93FGseBa4l4Ptbbca9iZqn3qHsloelMcyDBgkxjC85Kiq6SYSD4Gg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=wunner.de; spf=pass smtp.mailfrom=wunner.de; arc=none smtp.client-ip=83.223.78.240 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=wunner.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=wunner.de Received: from h08.hostsharing.net (h08.hostsharing.net [83.223.95.28]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "*.hostsharing.net", Issuer "RapidSSL TLS RSA CA G1" (verified OK)) by bmailout2.hostsharing.net (Postfix) with ESMTPS id C199D2800BB3F; Mon, 16 Dec 2024 20:19:16 +0100 (CET) Received: by h08.hostsharing.net (Postfix, from userid 100393) id A6F206320D2; Mon, 16 Dec 2024 20:19:16 +0100 (CET) Message-Id: <6152bd17cbe0876365d5f4624fc317529f4bbc85.1734376438.git.lukas@wunner.de> From: Lukas Wunner Date: Mon, 16 Dec 2024 20:18:41 +0100 Subject: [PATCH v2] PCI: Update code comment on PCI_EXP_LNKCAP_SLS for PCIe r3.0 Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 To: Bjorn Helgaas Cc: linux-pci@vger.kernel.org, Niklas Schnelle , Ilpo Jarvinen Niklas notes that the code comment on the PCI_EXP_LNKCAP_SLS macro is outdated as it reflects the meaning of the field prior to PCIe r3.0. Update it to avoid confusion. Reported-by: Niklas Schnelle Closes: https://lore.kernel.org/r/70829798889c6d779ca0f6cd3260a765780d1369.camel@kernel.org/ Signed-off-by: Lukas Wunner Reviewed-by: Ilpo Järvinen Reviewed-by: Niklas Schnelle --- Only change v1 -> v2: Add closing parenthesis. Seems there's a million ways to botch even the most trivial patch. :( include/uapi/linux/pci_regs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/uapi/linux/pci_regs.h b/include/uapi/linux/pci_regs.h index 1601c7e..02d0ba2 100644 --- a/include/uapi/linux/pci_regs.h +++ b/include/uapi/linux/pci_regs.h @@ -533,7 +533,7 @@ #define PCI_EXP_DEVSTA_TRPND 0x0020 /* Transactions Pending */ #define PCI_CAP_EXP_RC_ENDPOINT_SIZEOF_V1 12 /* v1 endpoints without link end here */ #define PCI_EXP_LNKCAP 0x0c /* Link Capabilities */ -#define PCI_EXP_LNKCAP_SLS 0x0000000f /* Supported Link Speeds */ +#define PCI_EXP_LNKCAP_SLS 0x0000000f /* Max Link Speed (prior to PCIe r3.0: Supported Link Speeds) */ #define PCI_EXP_LNKCAP_SLS_2_5GB 0x00000001 /* LNKCAP2 SLS Vector bit 0 */ #define PCI_EXP_LNKCAP_SLS_5_0GB 0x00000002 /* LNKCAP2 SLS Vector bit 1 */ #define PCI_EXP_LNKCAP_SLS_8_0GB 0x00000003 /* LNKCAP2 SLS Vector bit 2 */