From patchwork Tue Jan 19 13:43:30 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Rafael J. Wysocki" X-Patchwork-Id: 8062631 X-Patchwork-Delegate: bhelgaas@google.com Return-Path: X-Original-To: patchwork-linux-pci@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 97E469F1CC for ; Tue, 19 Jan 2016 13:43:13 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id A2F18203A0 for ; Tue, 19 Jan 2016 13:43:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8BCC120364 for ; Tue, 19 Jan 2016 13:43:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754176AbcASNnJ (ORCPT ); Tue, 19 Jan 2016 08:43:09 -0500 Received: from v094114.home.net.pl ([79.96.170.134]:55655 "HELO v094114.home.net.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S932510AbcASNmt (ORCPT ); Tue, 19 Jan 2016 08:42:49 -0500 Received: from abxw243.neoplus.adsl.tpnet.pl (83.9.16.243) (HELO vostro.rjw.lan) by serwer1319399.home.pl (79.96.170.134) with SMTP (IdeaSmtpServer v0.80) id e62c59afedacef93; Tue, 19 Jan 2016 14:42:47 +0100 From: "Rafael J. Wysocki" To: Chen Fan Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, lenb@kernel.org, izumi.taku@jp.fujitsu.com, wency@cn.fujitsu.com, caoj.fnst@cn.fujitsu.com, Bjorn Helgaas , Linux PCI Subject: Re: [PATCH] pci: fix unavailable irq number 255 reported by BIOS Date: Tue, 19 Jan 2016 14:43:30 +0100 Message-ID: <6239489.QX2A2kAHWp@vostro.rjw.lan> User-Agent: KMail/4.11.5 (Linux/4.4.0; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1453167913-16248-1-git-send-email-chen.fan.fnst@cn.fujitsu.com> References: <1453167913-16248-1-git-send-email-chen.fan.fnst@cn.fujitsu.com> MIME-Version: 1.0 Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Tuesday, January 19, 2016 09:45:13 AM Chen Fan wrote: > In our environment, when enable Secure boot, we found an abnormal > phenomenon as following call trace shows. after investigation, we > found the firmware assigned an irq number 255 which means unknown > or no connection in PCI local spec for i801_smbus, meanwhile the > ACPI didn't configure the pci irq routing. and the 255 irq number > was assigned for megasa msix without IRQF_SHARED. then in this case > during i801_smbus probe, the i801_smbus driver would request irq with > bad irq number 255. but the 255 irq number was assigned for memgasa > with MSIX enable. which will cause request_irq fails, and call trace > shows, actually, we should expose the error early, rather than in request > irq, here we simply fix the problem by return err when find the irq is > 255. > > See the call trace: > > [ 32.459195] ipmi device interface > [ 32.612907] shpchp: Standard Hot Plug PCI Controller Driver version: 0.4 > [ 32.800459] ixgbe: Intel(R) 10 Gigabit PCI Express Network Driver - version 4.0.1-k-rh > [ 32.818319] ixgbe: Copyright (c) 1999-2014 Intel Corporation. > [ 32.844009] lpc_ich 0001:80:1f.0: I/O space for ACPI uninitialized > [ 32.850093] i801_smbus 0000:00:1f.3: enabling device (0140 -> 0143) > [ 32.851134] i801_smbus 0000:00:1f.3: can't derive routing for PCI INT C > [ 32.851136] i801_smbus 0000:00:1f.3: PCI INT C: no GSI > [ 32.851164] genirq: Flags mismatch irq 255. 00000080 (i801_smbus) vs. 00000000 (megasa > [ 32.851168] CPU: 0 PID: 2487 Comm: kworker/0:1 Not tainted 3.10.0-229.el7.x86_64 #1 > [ 32.851170] Hardware name: FUJITSU PRIMEQUEST 2800E2/D3736, BIOS PRIMEQUEST 2000 Serie5 > [ 32.851178] Workqueue: events work_for_cpu_fn > [ 32.851208] ffff88086c330b00 00000000e233a9df ffff88086d57bca0 ffffffff81603f36 > [ 32.851227] ffff88086d57bcf8 ffffffff8110d23a ffff88686fe02000 0000000000000246 > [ 32.851246] ffff88086a9a8c00 00000000e233a9df ffffffffa00ad220 0000000000000080 > [ 32.851247] Call Trace: > [ 32.851261] [] dump_stack+0x19/0x1b > [ 32.851271] [] __setup_irq+0x54a/0x570 > [ 32.851282] [] ? i801_check_pre.isra.5+0xe0/0xe0 [i2c_i801] > [ 32.851289] [] request_threaded_irq+0xcc/0x170 > [ 32.851298] [] i801_probe+0x32f/0x508 [i2c_i801] > [ 32.851308] [] local_pci_probe+0x45/0xa0 > [ 32.851315] [] work_for_cpu_fn+0x14/0x20 > [ 32.851323] [] process_one_work+0x17b/0x470 > [ 32.851330] [] worker_thread+0x293/0x400 > [ 32.851338] [] ? rescuer_thread+0x400/0x400 > [ 32.851346] [] kthread+0xcf/0xe0 > [ 32.851353] [] ? kthread_create_on_node+0x140/0x140 > [ 32.851362] [] ret_from_fork+0x7c/0xb0 > [ 32.851369] [] ? kthread_create_on_node+0x140/0x140 > [ 32.851373] i801_smbus 0000:00:1f.3: Failed to allocate irq 255: -16 > [ 32.851435] i801_smbus: probe of 0000:00:1f.3 failed with error -16 > [ 33.180145] ixgbe 0000:5a:00.0: Multiq[ 33.240538] ixgbe 0000:5a:00.0: (PCI Express:03:e0 > [ 33.280826] ixgbe 0000:5a:00.0: MAC: 3, PHY: 0, PBA No: 000000-000 > > Signed-off-by: Chen Fan > --- > drivers/acpi/pci_irq.c | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) > > diff --git a/drivers/acpi/pci_irq.c b/drivers/acpi/pci_irq.c > index d30184c..d2f47f8 100644 > --- a/drivers/acpi/pci_irq.c > +++ b/drivers/acpi/pci_irq.c > @@ -439,9 +439,17 @@ int acpi_pci_irq_enable(struct pci_dev *dev) > if (acpi_isa_register_gsi(dev)) > dev_warn(&dev->dev, "PCI INT %c: no GSI\n", > pin_name(pin)); > + rc = 0; > + /* > + * Excluding the BIOS report the value 255, which meaning > + * "unknown" or "no connection" in PCI Local Bus Specification > + * Revision 3.0 February 3, 2004, P223. You mean the footnote on page 223 talking about the Interrupt Line values, right? > + */ > + if (dev->irq == 0xFF) > + rc = -EINVAL; > > kfree(entry); > - return 0; > + return rc; > } > > rc = acpi_register_gsi(&dev->dev, gsi, triggering, polarity); > Well, if you look at acpi_isa_register_gsi(), you'll see that it actually does the check you're adding, so maybe the following should be done instead? --- drivers/acpi/pci_irq.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Index: linux-pm/drivers/acpi/pci_irq.c =================================================================== --- linux-pm.orig/drivers/acpi/pci_irq.c +++ linux-pm/drivers/acpi/pci_irq.c @@ -436,12 +436,13 @@ int acpi_pci_irq_enable(struct pci_dev * * driver reported one, then use it. Exit in any case. */ if (gsi < 0) { - if (acpi_isa_register_gsi(dev)) + rc = acpi_isa_register_gsi(dev); + if (rc) dev_warn(&dev->dev, "PCI INT %c: no GSI\n", pin_name(pin)); kfree(entry); - return 0; + return rc; } rc = acpi_register_gsi(&dev->dev, gsi, triggering, polarity);