From patchwork Wed Jul 24 12:58:38 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rafael Wysocki X-Patchwork-Id: 2832681 X-Patchwork-Delegate: bhelgaas@google.com Return-Path: X-Original-To: patchwork-linux-pci@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id D495D9F4E2 for ; Wed, 24 Jul 2013 12:48:39 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 87DBD20209 for ; Wed, 24 Jul 2013 12:48:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4EDD820206 for ; Wed, 24 Jul 2013 12:48:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750957Ab3GXMsg (ORCPT ); Wed, 24 Jul 2013 08:48:36 -0400 Received: from hydra.sisk.pl ([212.160.235.94]:37707 "EHLO hydra.sisk.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750902Ab3GXMsf (ORCPT ); Wed, 24 Jul 2013 08:48:35 -0400 Received: from vostro.rjw.lan (aemg108.neoplus.adsl.tpnet.pl [79.191.58.108]) by hydra.sisk.pl (Postfix) with ESMTPSA id 66AB0E3DC1; Wed, 24 Jul 2013 14:43:59 +0200 (CEST) From: "Rafael J. Wysocki" To: Yinghai Lu Cc: ACPI Devel Maling List , Bjorn Helgaas , LKML , Linux PCI , Jiang Liu , Mika Westerberg , "Kirill A. Shutemov" Subject: Re: [PATCH 0/30] ACPI / hotplug / PCI: Major rework + Thunderbolt workarounds Date: Wed, 24 Jul 2013 14:58:38 +0200 Message-ID: <6958813.eThhpoh5QO@vostro.rjw.lan> User-Agent: KMail/4.9.5 (Linux/3.10.0+; KDE/4.9.5; x86_64; ; ) In-Reply-To: References: <26431283.HJCKsss0rt@vostro.rjw.lan> <3215120.cRBBS5jciE@vostro.rjw.lan> MIME-Version: 1.0 Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Tuesday, July 23, 2013 07:20:53 PM Yinghai Lu wrote: > On Tue, Jul 23, 2013 at 2:39 PM, Rafael J. Wysocki wrote: [...] > [ 102.631369] pci_host_bridge pci0000:00: freeing pci_host_bridge info By the way this looks fishy: > [ 102.633091] ACPI: Device does not support D3cold > [ 102.633915] ACPI: Device does not support D3cold > [ 102.635221] ACPI: Device does not support D3cold > [ 102.636103] ACPI: Device does not support D3cold > [ 102.636902] ACPI: Device does not support D3cold > [ 102.637685] ACPI: Device does not support D3cold > [ 102.638467] ACPI: Device does not support D3cold > [ 102.639631] ACPI: Device does not support D3cold > [ 102.640472] ACPI: Device does not support D3cold > [ 102.641310] ACPI: Device does not support D3cold > [ 102.642105] ACPI: Device does not support D3cold > [ 102.642928] ACPI: Device does not support D3cold > [ 102.643725] ACPI: Device does not support D3cold > [ 102.644544] ACPI: Device does not support D3cold > [ 102.645344] ACPI: Device does not support D3cold > [ 102.646126] ACPI: Device does not support D3cold > [ 102.646902] ACPI: Device does not support D3cold > [ 102.647677] ACPI: Device does not support D3cold > [ 102.648485] ACPI: Device does not support D3cold > [ 102.649269] ACPI: Device does not support D3cold > [ 102.650065] ACPI: Device does not support D3cold > [ 102.650822] ACPI: Device does not support D3cold > [ 102.652483] ACPI: Device does not support D3cold > [ 102.654157] ACPI: Device does not support D3cold > [ 102.655803] ACPI: Device does not support D3cold > [ 102.657419] ACPI: Device does not support D3cold > [ 102.658528] ACPI: Device does not support D3cold > [ 102.659255] ACPI: Device does not support D3cold > [ 102.659973] ACPI: Device does not support D3cold > [ 102.661807] ACPI: Device does not support D3cold > [ 102.661925] ACPI: Device does not support D3cold > [ 102.662047] ACPI: Device does not support D3cold > [ 102.662148] ACPI: Device does not support D3cold > [ 102.662258] ACPI: Device does not support D3cold > [ 102.662374] ACPI: Device does not support D3cold > [ 102.662486] ACPI: Device does not support D3cold > [ 102.662597] ACPI: Device does not support D3cold > [ 102.662711] ACPI: Device does not support D3cold > [ 102.662814] ACPI: Device does not support D3cold > [ 102.662918] ACPI: Device does not support D3cold > [ 102.663019] ACPI: Device does not support D3cold Can you please check if it goes away with the patch below applied? > [ 102.663039] ACPI: \_SB_.PCI0: No _EJ0 support for device --- drivers/acpi/device_pm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Index: linux-pm/drivers/acpi/device_pm.c =================================================================== --- linux-pm.orig/drivers/acpi/device_pm.c +++ linux-pm/drivers/acpi/device_pm.c @@ -159,7 +159,8 @@ int acpi_device_set_power(struct acpi_de int result = 0; bool cut_power = false; - if (!device || (state < ACPI_STATE_D0) || (state > ACPI_STATE_D3_COLD)) + if (!device || !device->flags.power_manageable + || (state < ACPI_STATE_D0) || (state > ACPI_STATE_D3_COLD)) return -EINVAL; /* Make sure this is a valid target state */