| Message ID | 76ec123596e05dcbcd8957f00ad5f8d4627a32d0.1405533479.git.agordeev@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Delegated to: | Bjorn Helgaas |
| Headers | show |
On Wed, Jul 16, 2014 at 08:05:20PM +0200, Alexander Gordeev wrote: > As result of deprecation of MSI-X/MSI enablement functions > pci_enable_msix() and pci_enable_msi_block() all drivers > using these two interfaces need to be updated to use the > new pci_enable_msi_range() or pci_enable_msi_exact() > and pci_enable_msix_range() or pci_enable_msix_exact() > interfaces. Hi Nagalakshmi, Praveen, Sreekanth and Abhijit, Could you please review mpt2/mpt3 patches in this series? Thanks! > Signed-off-by: Alexander Gordeev <agordeev@redhat.com> > Cc: Nagalakshmi Nandigama <Nagalakshmi.Nandigama@lsi.com> > Cc: Sreekanth Reddy <Sreekanth.Reddy@lsi.com> > Cc: support@lsi.com > Cc: DL-MPTFusionLinux@lsi.com > Cc: linux-scsi@vger.kernel.org > Cc: linux-pci@vger.kernel.org > --- > drivers/scsi/mpt3sas/mpt3sas_base.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.c b/drivers/scsi/mpt3sas/mpt3sas_base.c > index 0cf4f70..7b65ec2 100644 > --- a/drivers/scsi/mpt3sas/mpt3sas_base.c > +++ b/drivers/scsi/mpt3sas/mpt3sas_base.c > @@ -1747,10 +1747,10 @@ _base_enable_msix(struct MPT3SAS_ADAPTER *ioc) > for (i = 0, a = entries; i < ioc->reply_queue_count; i++, a++) > a->entry = i; > > - r = pci_enable_msix(ioc->pdev, entries, ioc->reply_queue_count); > + r = pci_enable_msix_exact(ioc->pdev, entries, ioc->reply_queue_count); > if (r) { > dfailprintk(ioc, pr_info(MPT3SAS_FMT > - "pci_enable_msix failed (r=%d) !!!\n", > + "pci_enable_msix_exact failed (r=%d) !!!\n", > ioc->name, r)); > kfree(entries); > goto try_ioapic; > -- > 1.7.7.6 > -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 07/16/2014 08:05 PM, Alexander Gordeev wrote: > As result of deprecation of MSI-X/MSI enablement functions > pci_enable_msix() and pci_enable_msi_block() all drivers > using these two interfaces need to be updated to use the > new pci_enable_msi_range() or pci_enable_msi_exact() > and pci_enable_msix_range() or pci_enable_msix_exact() > interfaces. > > Signed-off-by: Alexander Gordeev <agordeev@redhat.com> > Cc: Nagalakshmi Nandigama <Nagalakshmi.Nandigama@lsi.com> > Cc: Sreekanth Reddy <Sreekanth.Reddy@lsi.com> > Cc: support@lsi.com > Cc: DL-MPTFusionLinux@lsi.com > Cc: linux-scsi@vger.kernel.org > Cc: linux-pci@vger.kernel.org Looks good Reviewed-by: Tomas Henzl <thenzl@redhat.com> > --- > drivers/scsi/mpt3sas/mpt3sas_base.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.c b/drivers/scsi/mpt3sas/mpt3sas_base.c > index 0cf4f70..7b65ec2 100644 > --- a/drivers/scsi/mpt3sas/mpt3sas_base.c > +++ b/drivers/scsi/mpt3sas/mpt3sas_base.c > @@ -1747,10 +1747,10 @@ _base_enable_msix(struct MPT3SAS_ADAPTER *ioc) > for (i = 0, a = entries; i < ioc->reply_queue_count; i++, a++) > a->entry = i; > > - r = pci_enable_msix(ioc->pdev, entries, ioc->reply_queue_count); > + r = pci_enable_msix_exact(ioc->pdev, entries, ioc->reply_queue_count); > if (r) { > dfailprintk(ioc, pr_info(MPT3SAS_FMT > - "pci_enable_msix failed (r=%d) !!!\n", > + "pci_enable_msix_exact failed (r=%d) !!!\n", > ioc->name, r)); > kfree(entries); > goto try_ioapic; -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.c b/drivers/scsi/mpt3sas/mpt3sas_base.c index 0cf4f70..7b65ec2 100644 --- a/drivers/scsi/mpt3sas/mpt3sas_base.c +++ b/drivers/scsi/mpt3sas/mpt3sas_base.c @@ -1747,10 +1747,10 @@ _base_enable_msix(struct MPT3SAS_ADAPTER *ioc) for (i = 0, a = entries; i < ioc->reply_queue_count; i++, a++) a->entry = i; - r = pci_enable_msix(ioc->pdev, entries, ioc->reply_queue_count); + r = pci_enable_msix_exact(ioc->pdev, entries, ioc->reply_queue_count); if (r) { dfailprintk(ioc, pr_info(MPT3SAS_FMT - "pci_enable_msix failed (r=%d) !!!\n", + "pci_enable_msix_exact failed (r=%d) !!!\n", ioc->name, r)); kfree(entries); goto try_ioapic;
As result of deprecation of MSI-X/MSI enablement functions pci_enable_msix() and pci_enable_msi_block() all drivers using these two interfaces need to be updated to use the new pci_enable_msi_range() or pci_enable_msi_exact() and pci_enable_msix_range() or pci_enable_msix_exact() interfaces. Signed-off-by: Alexander Gordeev <agordeev@redhat.com> Cc: Nagalakshmi Nandigama <Nagalakshmi.Nandigama@lsi.com> Cc: Sreekanth Reddy <Sreekanth.Reddy@lsi.com> Cc: support@lsi.com Cc: DL-MPTFusionLinux@lsi.com Cc: linux-scsi@vger.kernel.org Cc: linux-pci@vger.kernel.org --- drivers/scsi/mpt3sas/mpt3sas_base.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)