diff mbox

PCI / PM: Add dev_dbg() to print device suspend power states

Message ID 8776535.A6PtrVU7Ea@aspire.rjw.lan (mailing list archive)
State New, archived
Delegated to: Bjorn Helgaas
Headers show

Commit Message

Rafael J. Wysocki Sept. 29, 2017, 11:31 p.m. UTC
From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

It sometimes is useful to know what power states the kernel thinks
it puts PCI devices into during system suspend, so add a dev_dbg()
statement for that.

Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
---
 drivers/pci/pci-driver.c |    3 +++
 1 file changed, 3 insertions(+)

Comments

Bjorn Helgaas Oct. 2, 2017, 11:29 p.m. UTC | #1
On Sat, Sep 30, 2017 at 01:31:15AM +0200, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> 
> It sometimes is useful to know what power states the kernel thinks
> it puts PCI devices into during system suspend, so add a dev_dbg()
> statement for that.
> 
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

Acked-by: Bjorn Helgaas <bhelgaas@google.com>

I think you have other pending changes in this path, so can you take
this one as well?

> ---
>  drivers/pci/pci-driver.c |    3 +++
>  1 file changed, 3 insertions(+)
> 
> Index: linux-pm/drivers/pci/pci-driver.c
> ===================================================================
> --- linux-pm.orig/drivers/pci/pci-driver.c
> +++ linux-pm/drivers/pci/pci-driver.c
> @@ -798,6 +798,9 @@ static int pci_pm_suspend_noirq(struct d
>  			pci_prepare_to_sleep(pci_dev);
>  	}
>  
> +	dev_dbg(dev, "PCI PM: Suspend power state: %s\n",
> +		pci_power_name(pci_dev->current_state));
> +
>  	pci_pm_set_unknown_state(pci_dev);
>  
>  	/*
>
Rafael J. Wysocki Oct. 2, 2017, 11:45 p.m. UTC | #2
On Tue, Oct 3, 2017 at 1:29 AM, Bjorn Helgaas <helgaas@kernel.org> wrote:
> On Sat, Sep 30, 2017 at 01:31:15AM +0200, Rafael J. Wysocki wrote:
>> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>>
>> It sometimes is useful to know what power states the kernel thinks
>> it puts PCI devices into during system suspend, so add a dev_dbg()
>> statement for that.
>>
>> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>
> Acked-by: Bjorn Helgaas <bhelgaas@google.com>
>
> I think you have other pending changes in this path, so can you take
> this one as well?

Yes, I can, thanks!
diff mbox

Patch

Index: linux-pm/drivers/pci/pci-driver.c
===================================================================
--- linux-pm.orig/drivers/pci/pci-driver.c
+++ linux-pm/drivers/pci/pci-driver.c
@@ -798,6 +798,9 @@  static int pci_pm_suspend_noirq(struct d
 			pci_prepare_to_sleep(pci_dev);
 	}
 
+	dev_dbg(dev, "PCI PM: Suspend power state: %s\n",
+		pci_power_name(pci_dev->current_state));
+
 	pci_pm_set_unknown_state(pci_dev);
 
 	/*