From patchwork Mon Feb 8 09:59:26 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 8247451 X-Patchwork-Delegate: bhelgaas@google.com Return-Path: X-Original-To: patchwork-linux-pci@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 15FDC9F38B for ; Mon, 8 Feb 2016 10:00:14 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 0DB8520390 for ; Mon, 8 Feb 2016 10:00:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3B4F22025A for ; Mon, 8 Feb 2016 10:00:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751828AbcBHKAI (ORCPT ); Mon, 8 Feb 2016 05:00:08 -0500 Received: from mout.kundenserver.de ([212.227.126.130]:58060 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751600AbcBHKAH (ORCPT ); Mon, 8 Feb 2016 05:00:07 -0500 Received: from wuerfel.localnet ([78.42.132.4]) by mrelayeu.kundenserver.de (mreue005) with ESMTPSA (Nemesis) id 0M7Wjr-1a8iwu3kXv-00xGo0; Mon, 08 Feb 2016 10:59:31 +0100 From: Arnd Bergmann To: Paul Gortmaker Cc: linux-kernel@vger.kernel.org, Murali Karicheri , Bjorn Helgaas , Stanimir Varbanov , Geert Uytterhoeven , Thierry Reding , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 4/5] drivers/pci: make host/pci-keystone-dw.c modular Date: Mon, 08 Feb 2016 10:59:26 +0100 Message-ID: <91848876.ZYig6qgHLq@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1454889644-27830-5-git-send-email-paul.gortmaker@windriver.com> References: <1454889644-27830-1-git-send-email-paul.gortmaker@windriver.com> <1454889644-27830-5-git-send-email-paul.gortmaker@windriver.com> MIME-Version: 1.0 X-Provags-ID: V03:K0:MiLyBZYFrOgViy/R0n9Godb+e8qo7nUqz+++mmAvHOAdrjVeBnU sAc1ebT3rBEjUhHhQECFK7gHFukosGF47cmrROt9nlDJ4QNuzXg7BVlgC0KarN5TAARiuUj r/GQw19g96OJV7LEx9uQxC3IgIXZX36NlTElcFweFfKivjJpdeRs529YPl2TXGPmCzv/2Kf G7c//Py/Qf9WCEy3cC0ig== X-UI-Out-Filterresults: notjunk:1; V01:K0:b2GdsPtwhOw=:5Bw+2p0h3yCwUF3Qhl3fcp CUWBO8vtgriQXHAJK5rqm4LP3rV74wHfnP/gDxmvPfkqaFdrKzzZ70IGWIpT97mh2lUBx5ZYK z0iL4AYbXE2VdW0/j1AQlUaGH2iFKMVLsHGuqmbGxfCog3JZ0DiBuVeS7RhNUIn1ebt+MEbhg Ptr50j+ffgbieSpBWh+vC0H8Z4VI6e7ZCaHJIqksySXTSqEKJPSNppAzJ8pkGuUlUziamHk3m 99a424CvU11+qUDegviPy3kxOVNTIEHeZwfWsnDwwCgVm15gygAdd9AlD7XtU8QRYIVs7LS0y mBtslpypMUpr8gBYQmAFeZZ4qSS/iH9/1WyXZye3K+qnJiePrNajgXwCfWJKeq90ex93bRXvG L3hKV1+lEqhr/trxrtkalixUgEvMQGfoIgWGsvVsiDSvAsIdD0S8eizAPgKuCpkphZW2v2Xmn HnIp1jnnG7NB8SUa8VikE5KkyBHHU14JLvRCtE/ekBPmlrXXzyFRFgXtE1sF0BeiNluyrfhb2 AnSy1eFxJvZiL6+sG2fTEyzCnjFEAN/Uk76BtMoybtKpaHa+wFGwXpcJDzQ34RQ8VG20MLH2g PIX49TYFwOUC5cIZIOm6JhiTO6mIO48pjvcqrtUoAhcD34UhiqSgczUNHVID5WGg8d4lWbaVu mH+GQgLiDZiHB95wgsQ7ld2m/8XTSQxufxx4krDHhaGDZyDsHQdVQlmTqstl+/xN/M7DVsTsk G92Eo6OL81I9GQ41 Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Sunday 07 February 2016 19:00:43 Paul Gortmaker wrote: > Export the symbols that this driver requires in order for it to > be modular. In addition to the one use case of a dw_pci sym, it > has many instances of its own ks_dw_pci syms that need exporting > in order to modpost w/o error. > > Cc: Murali Karicheri > Cc: Bjorn Helgaas > Cc: Stanimir Varbanov > Cc: Geert Uytterhoeven > Cc: Thierry Reding > Cc: Arnd Bergmann > Cc: linux-pci@vger.kernel.org > Cc: linux-arm-kernel@lists.infradead.org > Signed-off-by: Paul Gortmaker > --- Could we just have one module for the driver instead of two? Something like below (untested) Arnd --- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/pci/host/Makefile b/drivers/pci/host/Makefile index 7b2f20c6ccc6..0b472c680348 100644 --- a/drivers/pci/host/Makefile +++ b/drivers/pci/host/Makefile @@ -8,7 +8,8 @@ obj-$(CONFIG_PCI_RCAR_GEN2) += pci-rcar-gen2.o obj-$(CONFIG_PCI_RCAR_GEN2_PCIE) += pcie-rcar.o obj-$(CONFIG_PCI_HOST_GENERIC) += pci-host-generic.o obj-$(CONFIG_PCIE_SPEAR13XX) += pcie-spear13xx.o -obj-$(CONFIG_PCI_KEYSTONE) += pci-keystone-dw.o pci-keystone.o +obj-$(CONFIG_PCI_KEYSTONE) pci-keystone-mod.o +pci-keystone-mod-objs := pci-keystone-dw.o pci-keystone.o obj-$(CONFIG_PCIE_XILINX) += pcie-xilinx.o obj-$(CONFIG_PCI_XGENE) += pci-xgene.o obj-$(CONFIG_PCI_XGENE_MSI) += pci-xgene-msi.o