From patchwork Mon Sep 10 23:43:53 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bjorn Helgaas X-Patchwork-Id: 1434061 X-Patchwork-Delegate: bhelgaas@google.com Return-Path: X-Original-To: patchwork-linux-pci@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id BC085DF28C for ; Mon, 10 Sep 2012 23:44:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758333Ab2IJXoS (ORCPT ); Mon, 10 Sep 2012 19:44:18 -0400 Received: from mail-lb0-f174.google.com ([209.85.217.174]:35597 "EHLO mail-lb0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758235Ab2IJXoR (ORCPT ); Mon, 10 Sep 2012 19:44:17 -0400 Received: by lbbgj3 with SMTP id gj3so1593664lbb.19 for ; Mon, 10 Sep 2012 16:44:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:x-system-of-record; bh=qxJJs102g/WdOgWLK1fuUjqnSWvMliMqNBnGRtUf1nI=; b=OqIVC+ZMsHDX0MKLABlhfFjRoRhNDssuTuWH6H2gwSeBFA3MkyMUKpmTOGgaf7d4Ic lVMp59IF69mVLbUIdX1y52FQjEjbm5pcvP3AOvL2YASnTIcWm3HVfPWjpd3p2WZxhtT5 /tksgEL2+ZQKyQAFGVkMVRf5Xap/DBFB5R5P+o5IZ7J9bTboFpDMHgsBVfaBnEmKZWmi K+5vKgaxfJ3sEUxTv4sd3qL/UgXTmzZgF0yBtOl8UZfJj8rRo2yL2o1VdcmNXcLBGfok hhPqz3wu+jYr+PnTwE8COU5MI3I6ww/+mtFj7BSiRdlAFfj8wAHWw/6CmGo7+EXgMOMF AiCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:x-system-of-record:x-gm-message-state; bh=qxJJs102g/WdOgWLK1fuUjqnSWvMliMqNBnGRtUf1nI=; b=BjIA4xqxaK0QBVJNngOQdcsJPEFqRbcOZ7ZJgDxTfeQRz1PNDCzfn8CbUuo0TCs60F /sKbUUT/FWcYdUPgnXj8HZ7BhQz5ijioxo8CmzhBWXkL4vtsY35Xr+kfSrRiki3alRXB qdLW8ThtjWON++eas/07IqOkOOoGIz/EF3BeDTAwnd7WRr04pzSCz1td9//JJ55G7bqY hiSNr28fst+vAC3HJ4pfygzJjXETNV7HHD/v7vVTQ91IQA9/6jaHVCBU3ETrCimtWK8i Kh8o+n6CDeQusN7nIz0jKmirvbR4igafxKGWLZyo5zj+mGR0P3rIlNImnm0W6RYaWVKB pkBQ== Received: by 10.152.123.206 with SMTP id mc14mr14164887lab.33.1347320655973; Mon, 10 Sep 2012 16:44:15 -0700 (PDT) Received: by 10.152.123.206 with SMTP id mc14mr14164876lab.33.1347320655768; Mon, 10 Sep 2012 16:44:15 -0700 (PDT) MIME-Version: 1.0 Received: by 10.112.132.73 with HTTP; Mon, 10 Sep 2012 16:43:53 -0700 (PDT) In-Reply-To: <20120909082717.63E5011FBF5@bugzilla.kernel.org> References: <20120909082717.63E5011FBF5@bugzilla.kernel.org> From: Bjorn Helgaas Date: Mon, 10 Sep 2012 17:43:53 -0600 Message-ID: Subject: Re: [Bug 18412] Intel DP43BF requires "pci=assign-busses" to discover some devices To: linux-pci@vger.kernel.org, Yinghai Lu Cc: vl.homutov@gmail.com X-System-Of-Record: true X-Gm-Message-State: ALoCoQmFh4gmmk86EmknbldQCUHdv2INt4khKn+OeaCnnECEMw/7GtZ4OFoI5wp11dN73nuI+hx+fs7SDRHuWMyMSe792PH8BKmOTGPhalm4YCpmkFs7PKRK7EsjAeBROSt+GBlw04uIK+kqiIE6nF/Pah9ZKcTai8eogIQHBeqpS2Fks1lwOlsC9V/wI4kQvFXGmp4rHCyz8kGE1PtH1OSizYnOP5Jqqw== Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Sun, Sep 9, 2012 at 2:27 AM, wrote: > https://bugzilla.kernel.org/show_bug.cgi?id=18412 > > --- Comment #14 from VL 2012-09-09 08:27:17 --- >> Given the [bus 20-08] range, I suspect that the patch in comment #9 may fix it, >> and that's something we could apply. Can you try just that patch on top of a >> 3.5 or 3.6-rc4 kernel? > > yes, this patch fixes the problem. Yinghai, you put the following (whitespace damaged) patch in the bugzilla, and VL says it fixes his sytem. He has a P2P bridge with secondary > subordinate: pci 0000:00:1e.0: PCI bridge to [bus 20-08] (subtractive decode) The current kernel doesn't probe behind this bridge, so it doesn't find a couple devices. With the patch below, we reassign the secondary bus number from 20 to 08, so we do find those devices. I'm slightly concerned that if we apply a patch like this, it removes one way a BIOS could hide devices from the OS. But maybe we don't need to worry about that. We have to configure hot-added P2P bridges from scratch, so maybe we should be aggressive about fixing bridges like this, too. Are you comfortable enough with this patch to post it with a Signed-off-by? } --- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c index 3cdba8b..a8f1bf6 100644 --- a/drivers/pci/probe.c +++ b/drivers/pci/probe.c @@ -729,7 +729,8 @@ int __devinit pci_scan_bridge(struct pci_bus *bus, struct pci_dev *dev, int max, /* Check if setup is sensible at all */ if (!pass && - (primary != bus->number || secondary <= bus->number)) { + (primary != bus->number || secondary <= bus->number || + secondary > subordinate)) { dev_dbg(&dev->dev, "bus configuration invalid, reconfiguring\n"); broken = 1;