From patchwork Fri Dec 6 09:06:10 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rui Wang X-Patchwork-Id: 3293941 X-Patchwork-Delegate: bhelgaas@google.com Return-Path: X-Original-To: patchwork-linux-pci@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 9C0A6C0D4A for ; Fri, 6 Dec 2013 09:07:54 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 04F3A2021A for ; Fri, 6 Dec 2013 09:07:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EF90F204EB for ; Fri, 6 Dec 2013 09:07:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757212Ab3LFJHW (ORCPT ); Fri, 6 Dec 2013 04:07:22 -0500 Received: from mail-lb0-f180.google.com ([209.85.217.180]:34615 "EHLO mail-lb0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757209Ab3LFJGM (ORCPT ); Fri, 6 Dec 2013 04:06:12 -0500 Received: by mail-lb0-f180.google.com with SMTP id w6so149675lbh.25 for ; Fri, 06 Dec 2013 01:06:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=kjMAF2rybP0LtbZ16SH9fuQBDkE9xMsTV25Fs1yOp7U=; b=StvZr8Nq3jY1xgkfCJ/k5PcGhY5oCzAVPEiSwVqZKoouvbxzrgU002JRxKiKTJdw8s 05hHRXCXaKEZ6FrpY310GOa3yCpueuJiT6W78TB6Bnngdjq0ya8byNt4jTe8256EpP4/ M906/1o+CAqaQwEgpg9TGTSYtLvXT8Meh/1kb0TbxnphEyS+MgEAiT2qcqmb5juse5JJ 3rxtO3Dkz7W03W0ciOw7I8dEbEBnUQUwta6KfW7YSPVIY8Qb+POh857hcKeN3RvrcjYQ BzL4uZyPl9A/+n3YjPBEm2duynJdfaKhFVe5Ej/u2NnwkzTVcomVRToRvGrI7PFNKT5y qLlA== MIME-Version: 1.0 X-Received: by 10.112.61.162 with SMTP id q2mr13779lbr.85.1386320770197; Fri, 06 Dec 2013 01:06:10 -0800 (PST) Received: by 10.114.66.50 with HTTP; Fri, 6 Dec 2013 01:06:10 -0800 (PST) In-Reply-To: <20131204203837.GA7517@pd.tnic> References: <20130116235102.16015.77379.stgit@grignak.americas.hpqcorp.net> <20131204203837.GA7517@pd.tnic> Date: Fri, 6 Dec 2013 17:06:10 +0800 Message-ID: Subject: Re: [PATCH v10 1/3] aerdrv: Trace Event for AER From: rui wang To: Borislav Petkov Cc: Lance Ortiz , bhelgaas@google.com, lance_ortiz@hotmail.com, jiang.liu@intel.com, tony.luck@intel.com, rostedt@goodmis.org, mchehab@redhat.com, linux-acpi@vger.kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, gong.chen@intel.com Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org X-Spam-Status: No, score=-7.0 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On 12/5/13, Borislav Petkov wrote: > Yes, the AER tracepoint above should use the AER_* defines and not the > HW_EVENT_ERR_* ones which are for memory errors. > > Wanna send a fix? > Yes. Does it translate into something like this? From: Rui Wang Date: Fri, 6 Dec 2013 16:47:46 +0800 Subject: [PATCH] Fix severity usage in aer trace event Signed-off-by: Rui Wang --- include/trace/events/ras.h | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/include/trace/events/ras.h b/include/trace/events/ras.h index 88b8783..e2a17d8 100644 --- a/include/trace/events/ras.h +++ b/include/trace/events/ras.h @@ -5,7 +5,7 @@ #define _TRACE_AER_H #include -#include +#include /* @@ -63,10 +63,10 @@ TRACE_EVENT(aer_event, TP_printk("%s PCIe Bus Error: severity=%s, %s\n", __get_str(dev_name), - __entry->severity == HW_EVENT_ERR_CORRECTED ? "Corrected" : - __entry->severity == HW_EVENT_ERR_FATAL ? + __entry->severity == AER_CORRECTABLE ? "Corrected" : + __entry->severity == AER_FATAL ? "Fatal" : "Uncorrected", - __entry->severity == HW_EVENT_ERR_CORRECTED ? + __entry->severity == AER_CORRECTABLE ? __print_flags(__entry->status, "|", aer_correctable_errors) : __print_flags(__entry->status, "|", aer_uncorrectable_errors)) );