| Message ID | a068e858f5e115ebb3a841e4564aec8523a154f6.1464694724.git.jthumshirn@suse.de (mailing list archive) |
|---|---|
| State | New, archived |
| Delegated to: | Bjorn Helgaas |
| Headers | show |
On Tue, May 31, 2016 at 02:05:09PM +0200, Johannes Thumshirn wrote: > Add helpers to request and release a device's memory or I/O regions. > > With these helpers in place, one does not need to select a device's memory or > I/O regions with pci_select_bars() prior to requesting or releasing them. > > Suggested-by: Christoph Hellwig <hch@infradead.org> > Signed-off-by: Johannes Thumshirn <jthumshirn@suse.de> > --- > include/linux/pci.h | 29 +++++++++++++++++++++++++++++ > 1 file changed, 29 insertions(+) > > diff --git a/include/linux/pci.h b/include/linux/pci.h > index 932ec74..846f4cf 100644 > --- a/include/linux/pci.h > +++ b/include/linux/pci.h > @@ -2007,6 +2007,35 @@ static inline bool pci_is_dev_assigned(struct pci_dev *pdev) > return (pdev->dev_flags & PCI_DEV_FLAGS_ASSIGNED) == PCI_DEV_FLAGS_ASSIGNED; > } > > +static inline int > +pci_request_io_regions(struct pci_dev *pdev, const char *name) > +{ > + return pci_request_selected_regions(pdev, > + pci_select_bars(pdev, IORESOURCE_IO), name); Needs a little indentation tweak to not spill over 80 characters. Two tabs should be plenty indentation for the continuation of function arguments. Ditto for the other functions, Otherwise looks fine: Reviewed-by: Christoph Hellwig <hch@lst.de> -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/include/linux/pci.h b/include/linux/pci.h index 932ec74..846f4cf 100644 --- a/include/linux/pci.h +++ b/include/linux/pci.h @@ -2007,6 +2007,35 @@ static inline bool pci_is_dev_assigned(struct pci_dev *pdev) return (pdev->dev_flags & PCI_DEV_FLAGS_ASSIGNED) == PCI_DEV_FLAGS_ASSIGNED; } +static inline int +pci_request_io_regions(struct pci_dev *pdev, const char *name) +{ + return pci_request_selected_regions(pdev, + pci_select_bars(pdev, IORESOURCE_IO), name); +} + +static inline void +pci_release_io_regions(struct pci_dev *pdev) +{ + return pci_release_selected_regions(pdev, + pci_select_bars(pdev, IORESOURCE_IO)); +} + +static inline int +pci_request_mem_regions(struct pci_dev *pdev, const char *name) +{ + return pci_request_selected_regions(pdev, + pci_select_bars(pdev, IORESOURCE_MEM), name); +} + +static inline void +pci_release_mem_regions(struct pci_dev *pdev) +{ + return pci_release_selected_regions(pdev, + pci_select_bars(pdev, + IORESOURCE_MEM)); +} + /** * pci_ari_enabled - query ARI forwarding status * @bus: the PCI bus
Add helpers to request and release a device's memory or I/O regions. With these helpers in place, one does not need to select a device's memory or I/O regions with pci_select_bars() prior to requesting or releasing them. Suggested-by: Christoph Hellwig <hch@infradead.org> Signed-off-by: Johannes Thumshirn <jthumshirn@suse.de> --- include/linux/pci.h | 29 +++++++++++++++++++++++++++++ 1 file changed, 29 insertions(+)