| Message ID | alpine.LNX.2.00.1303210018430.16237@pobox.suse.cz (mailing list archive) |
|---|---|
| State | New, archived |
| Delegated to: | Bjorn Helgaas |
| Headers | show |
On Thu, Mar 21, 2013 at 12:21:21AM +0100, Jiri Kosina wrote: > On Wed, 20 Mar 2013, Alan Stern wrote: > > > > Ok, so how about this? > > > Daniel, is it enough to make the problem appear on your system (by > > > building this into the kernel and booting with dummy-irq.irq=16)? > > > > > > Thanks. > > > > > > From: Jiri Kosina <jkosina@suse.cz> > > > Subject: [PATCH] dummy-irq: introduce a dummy IRQ handler driver > > > > > > This module accepts a single 'irq' parameter, which it should register for. > > > > > > Its sole purpose is to help with debugging of IRQ sharing problems, by > > > force-enabling IRQ that would otherwise be disabled. > > > > > > Suggested-by: Alan Stern <stern@rowland.harvard.edu> > > > Signed-off-by: Jiri Kosina <jkosina@suse.cz> > > > > This is just what I was thinking of. Three extremely minor > > suggestions... > > Thanks Alan. Updated version below. > > Greg, willing to merge this simple debugging facility? Yes, I'll take it, give me a few days to catch up with my pending queue, don't worry, it's not lost. greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Mar 21, 2013 at 12:21:21AM +0100, Jiri Kosina wrote: > On Wed, 20 Mar 2013, Alan Stern wrote: > > > > Ok, so how about this? > > > Daniel, is it enough to make the problem appear on your system (by > > > building this into the kernel and booting with dummy-irq.irq=16)? > > > > > > Thanks. > > > > > > From: Jiri Kosina <jkosina@suse.cz> > > > Subject: [PATCH] dummy-irq: introduce a dummy IRQ handler driver > > > > > > This module accepts a single 'irq' parameter, which it should register for. > > > > > > Its sole purpose is to help with debugging of IRQ sharing problems, by > > > force-enabling IRQ that would otherwise be disabled. > > > > > > Suggested-by: Alan Stern <stern@rowland.harvard.edu> > > > Signed-off-by: Jiri Kosina <jkosina@suse.cz> > > > > This is just what I was thinking of. Three extremely minor > > suggestions... > > Thanks Alan. Updated version below. > > Greg, willing to merge this simple debugging facility? > > > From: Jiri Kosina <jkosina@suse.cz> > Subject: [PATCH] dummy-irq: introduce a dummy IRQ handler driver > > This module accepts a single 'irq' parameter, which it should register for. > > Its sole purpose is to help with debugging of IRQ sharing problems, by > force-enabling IRQ that would otherwise be disabled. > > Suggested-by: Alan Stern <stern@rowland.harvard.edu> > Signed-off-by: Jiri Kosina <jkosina@suse.cz> Indeed, this is pretty useful and allowed me to quickly reproduce that phantom irq on my gm45. Thanks to module reloading we can even reset the kernel's irq disabling logic and so test different tricks quickly without rebooting. Really useful. Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch> Thanks, Daniel > --- > drivers/misc/Kconfig | 8 ++++++ > drivers/misc/Makefile | 1 + > drivers/misc/dummy-irq.c | 59 ++++++++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 68 insertions(+), 0 deletions(-) > create mode 100644 drivers/misc/dummy-irq.c > > diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig > index e83fdfe..69bb79d 100644 > --- a/drivers/misc/Kconfig > +++ b/drivers/misc/Kconfig > @@ -93,6 +93,14 @@ config ATMEL_TCB_CLKSRC_BLOCK > TC can be used for other purposes, such as PWM generation and > interval timing. > > +config DUMMY_IRQ > + tristate "Dummy IRQ handler" > + default n > + ---help--- > + This module accepts a single 'irq' parameter, which it should register for. > + The sole purpose of this module is to help with debugging of systems on > + which spurious IRQs would happen on disabled IRQ vector. > + > config IBM_ASM > tristate "Device driver for IBM RSA service processor" > depends on X86 && PCI && INPUT > diff --git a/drivers/misc/Makefile b/drivers/misc/Makefile > index 35a1463..28ff261 100644 > --- a/drivers/misc/Makefile > +++ b/drivers/misc/Makefile > @@ -13,6 +13,7 @@ obj-$(CONFIG_ATMEL_TCLIB) += atmel_tclib.o > obj-$(CONFIG_BMP085) += bmp085.o > obj-$(CONFIG_BMP085_I2C) += bmp085-i2c.o > obj-$(CONFIG_BMP085_SPI) += bmp085-spi.o > +obj-$(CONFIG_DUMMY_IRQ) += dummy-irq.o > obj-$(CONFIG_ICS932S401) += ics932s401.o > obj-$(CONFIG_LKDTM) += lkdtm.o > obj-$(CONFIG_TIFM_CORE) += tifm_core.o > diff --git a/drivers/misc/dummy-irq.c b/drivers/misc/dummy-irq.c > new file mode 100644 > index 0000000..7014167 > --- /dev/null > +++ b/drivers/misc/dummy-irq.c > @@ -0,0 +1,59 @@ > +/* > + * Dummy IRQ handler driver. > + * > + * This module only registers itself as a handler that is specified to it > + * by the 'irq' parameter. > + * > + * The sole purpose of this module is to help with debugging of systems on > + * which spurious IRQs would happen on disabled IRQ vector. > + * > + * Copyright (C) 2013 Jiri Kosina > + */ > + > +/* > + * This program is free software; you can redistribute it and/or modify it > + * under the terms of the GNU General Public License version 2 as published by > + * the Free Software Foundation. > + */ > +#include <linux/module.h> > +#include <linux/irq.h> > +#include <linux/interrupt.h> > + > +static int irq; > + > +static irqreturn_t dummy_interrupt(int irq, void *dev_id) > +{ > + static int count = 0; > + > + if (count == 0) { > + printk(KERN_INFO "dummy-irq: interrupt occured on IRQ %d\n", > + irq); > + count++; > + } > + > + return IRQ_NONE; > +} > + > +static int __init dummy_irq_init(void) > +{ > + if (request_irq(irq, &dummy_interrupt, IRQF_SHARED, "dummy_irq", &irq)) { > + printk(KERN_ERR "dummy-irq: cannot register IRQ %d\n", irq); > + return -EIO; > + } > + printk(KERN_INFO "dummy-irq: registered for IRQ %d\n", irq); > + return 0; > +} > + > +static void __exit dummy_irq_exit(void) > +{ > + printk(KERN_INFO "dummy-irq unloaded\n"); > + free_irq(irq, &irq); > +} > + > +module_init(dummy_irq_init); > +module_exit(dummy_irq_exit); > + > +MODULE_LICENSE("GPL"); > +MODULE_AUTHOR("Jiri Kosina"); > +module_param(irq, uint, 0444); > +MODULE_PARM_DESC(irq, "The IRQ to register for"); > > -- > Jiri Kosina > SUSE Labs
On Thu, 21 Mar 2013, Daniel Vetter wrote: > Indeed, this is pretty useful and allowed me to quickly reproduce that > phantom irq on my gm45. Thanks to module reloading we can even reset the > kernel's irq disabling logic and so test different tricks quickly without > rebooting. Really useful. Daniel, out of curiosity, have you been able to make some sense of the phantom legacy IRQs on GM45 systems, or are we just staying with my original bandaid (disabling GMBUS IRQs), declaring GM45 broken in this respect? Thanks,
On Sun, Mar 31, 2013 at 9:55 PM, Jiri Kosina <jkosina@suse.cz> wrote: > On Thu, 21 Mar 2013, Daniel Vetter wrote: > >> Indeed, this is pretty useful and allowed me to quickly reproduce that >> phantom irq on my gm45. Thanks to module reloading we can even reset the >> kernel's irq disabling logic and so test different tricks quickly without >> rebooting. Really useful. > > Daniel, > > out of curiosity, have you been able to make some sense of the phantom > legacy IRQs on GM45 systems, or are we just staying with my original > bandaid (disabling GMBUS IRQs), declaring GM45 broken in this respect? I've played around with dummy-irq on my own gm45 and afaict every gmbus interrupt generates both an msi and a legacy pci interrupt when msi is enabled. Everything else (= other interrupt sources) seems to work as expected, and disabling msi also papers over the issue. There's also scary comments in our gm45 irq handler that we need msi to paper over some other races. So I've decided that I don't want to dwell any longer in this particular dungeon and that your bandaid (of just disabling this mess) is the real fix. Thanks, Daniel
diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig index e83fdfe..69bb79d 100644 --- a/drivers/misc/Kconfig +++ b/drivers/misc/Kconfig @@ -93,6 +93,14 @@ config ATMEL_TCB_CLKSRC_BLOCK TC can be used for other purposes, such as PWM generation and interval timing. +config DUMMY_IRQ + tristate "Dummy IRQ handler" + default n + ---help--- + This module accepts a single 'irq' parameter, which it should register for. + The sole purpose of this module is to help with debugging of systems on + which spurious IRQs would happen on disabled IRQ vector. + config IBM_ASM tristate "Device driver for IBM RSA service processor" depends on X86 && PCI && INPUT diff --git a/drivers/misc/Makefile b/drivers/misc/Makefile index 35a1463..28ff261 100644 --- a/drivers/misc/Makefile +++ b/drivers/misc/Makefile @@ -13,6 +13,7 @@ obj-$(CONFIG_ATMEL_TCLIB) += atmel_tclib.o obj-$(CONFIG_BMP085) += bmp085.o obj-$(CONFIG_BMP085_I2C) += bmp085-i2c.o obj-$(CONFIG_BMP085_SPI) += bmp085-spi.o +obj-$(CONFIG_DUMMY_IRQ) += dummy-irq.o obj-$(CONFIG_ICS932S401) += ics932s401.o obj-$(CONFIG_LKDTM) += lkdtm.o obj-$(CONFIG_TIFM_CORE) += tifm_core.o diff --git a/drivers/misc/dummy-irq.c b/drivers/misc/dummy-irq.c new file mode 100644 index 0000000..7014167 --- /dev/null +++ b/drivers/misc/dummy-irq.c @@ -0,0 +1,59 @@ +/* + * Dummy IRQ handler driver. + * + * This module only registers itself as a handler that is specified to it + * by the 'irq' parameter. + * + * The sole purpose of this module is to help with debugging of systems on + * which spurious IRQs would happen on disabled IRQ vector. + * + * Copyright (C) 2013 Jiri Kosina + */ + +/* + * This program is free software; you can redistribute it and/or modify it + * under the terms of the GNU General Public License version 2 as published by + * the Free Software Foundation. + */ +#include <linux/module.h> +#include <linux/irq.h> +#include <linux/interrupt.h> + +static int irq; + +static irqreturn_t dummy_interrupt(int irq, void *dev_id) +{ + static int count = 0; + + if (count == 0) { + printk(KERN_INFO "dummy-irq: interrupt occured on IRQ %d\n", + irq); + count++; + } + + return IRQ_NONE; +} + +static int __init dummy_irq_init(void) +{ + if (request_irq(irq, &dummy_interrupt, IRQF_SHARED, "dummy_irq", &irq)) { + printk(KERN_ERR "dummy-irq: cannot register IRQ %d\n", irq); + return -EIO; + } + printk(KERN_INFO "dummy-irq: registered for IRQ %d\n", irq); + return 0; +} + +static void __exit dummy_irq_exit(void) +{ + printk(KERN_INFO "dummy-irq unloaded\n"); + free_irq(irq, &irq); +} + +module_init(dummy_irq_init); +module_exit(dummy_irq_exit); + +MODULE_LICENSE("GPL"); +MODULE_AUTHOR("Jiri Kosina"); +module_param(irq, uint, 0444); +MODULE_PARM_DESC(irq, "The IRQ to register for");