From patchwork Sun Feb 5 10:00:41 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hans Ulli Kroll X-Patchwork-Id: 9556035 X-Patchwork-Delegate: bhelgaas@google.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 42AD0602B1 for ; Sun, 5 Feb 2017 10:00:48 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3469D1FF12 for ; Sun, 5 Feb 2017 10:00:48 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 2917126E69; Sun, 5 Feb 2017 10:00:48 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C20891FF12 for ; Sun, 5 Feb 2017 10:00:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752057AbdBEKAr (ORCPT ); Sun, 5 Feb 2017 05:00:47 -0500 Received: from mail-wm0-f67.google.com ([74.125.82.67]:33942 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751774AbdBEKAq (ORCPT ); Sun, 5 Feb 2017 05:00:46 -0500 Received: by mail-wm0-f67.google.com with SMTP id c85so14982582wmi.1 for ; Sun, 05 Feb 2017 02:00:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=dXm/3r/DcLAsVW2ZornIT+pGpL7r8jcxafjbeVigStA=; b=QXI3/l+DrXdUIXWtOvXNFGJesiuDI90WVQIeDIC/+Jq7F/d5xw68Vn4FLVPKbuahoR e6YZPSBml8ThhlutSIaBsvKX7v50SEkESkIfArheiDEFhYUi6uCIsxicLe82G6HUQLgi xO//URuOG7Lvw94kN/YrwQllDsNrfnZbVCS5t29oLuC1eFt5aCEbijIBZyMyeteAPTDj s5u0fWoOajrIClgxVEAcjNO7LqxV/lFlKpFt/+Vi2Mdn6Cm0oC+XbqAalzWX19hhKj5t yWifxMT3vL6hcn7Y7AEVYSWxB/4O/u9PkX19gs+hf1iOiSwN9KNnu0iawRuOcYRHQnRF 7flg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=dXm/3r/DcLAsVW2ZornIT+pGpL7r8jcxafjbeVigStA=; b=FctdNOboY8WRSnmmBj3m6yoazqJpU93g6M0hJCo4M9p1scmB4tyylGL1aDbLk1W9lM 3aDtYK4cgrClE5bUVMDsBVEcGyrdHovrLdw8X4EKHN09/tIh3PzWMhPFWUaJ14f62SWW SwRBZewlsMQMLMRyupG+bZhyKUSaw0NUABq52EPpHe0YHWAXarQxbGfucKNeHrqw17ti dkfLTEJwREW1DFQuthJSyPz1clvpsceDDo8p+JYTmGw59LGdjIglIbyK51ripDTy0WMa xx+oxqvEdwfA/WgAMjxxsEhejY5T8pzd43lQ28dFL+EwIx4az552Xl4uq2dMaKL+9krK H2pw== X-Gm-Message-State: AIkVDXIx7l2C+unMDv1JKnXPIj0YEQORZu/hGE6wHmL0KCEU1Hrayz6nBfJ7OECWcSJIxw== X-Received: by 10.223.146.196 with SMTP id 62mr4603118wrn.199.1486288844672; Sun, 05 Feb 2017 02:00:44 -0800 (PST) Received: from localhost (cable-78-34-25-212.netcologne.de. [78.34.25.212]) by smtp.gmail.com with ESMTPSA id z134sm6652362wmc.20.2017.02.05.02.00.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 05 Feb 2017 02:00:44 -0800 (PST) Date: Sun, 5 Feb 2017 11:00:41 +0100 (CET) From: Hans Ulli Kroll X-X-Sender: elektroman@T420s To: Linus Walleij cc: Hans Ulli Kroll , Florian Fainelli , Bjorn Helgaas , Janos Laube , Paulius Zaleckas , openwrt-devel@openwrt.org, linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org Subject: Re: [PATCH 2/4] PCI: add driver for Cortina Gemini Host Bridge In-Reply-To: <20170128204839.18330-2-linus.walleij@linaro.org> Message-ID: References: <20170128204839.18330-1-linus.walleij@linaro.org> <20170128204839.18330-2-linus.walleij@linaro.org> User-Agent: Alpine 2.00 (LNX 1167 2008-08-23) MIME-Version: 1.0 Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hi Linus while debugging my boot issues on my NAS 4220, I saw this warning irq: type mismatch, failed to map hwirq-26 for /soc/interrupt-controller@48000000! We need to use the use the use the PCI IRQ from gemini as root for the irq domain, not the next one in DT. diff --git a/drivers/pci/host/pci-gemini.c b/drivers/pci/host/pci-gemini.c index 7051dd992114..bb564a8e6379 100644 --- a/drivers/pci/host/pci-gemini.c +++ b/drivers/pci/host/pci-gemini.c @@ -217,7 +217,6 @@ static const struct irq_domain_ops gemini_pci_irqdomain_ops = { static int gemini_pci_setup_irq(struct gemini_pci *p, int irq) { - struct device_node *intc = of_get_next_child(p->dev->of_node, NULL); int i; if (!intc) { @@ -225,7 +224,7 @@ static int gemini_pci_setup_irq(struct gemini_pci *p, int irq) return -EINVAL; } - p->irqdomain = irq_domain_add_linear(intc, 4, + p->irqdomain = irq_domain_add_linear(p->dev->of_node, 4, &gemini_pci_irqdomain_ops, p); if (!p->irqdomain) {