| Message ID | e8cc7988e4b0a38f59d3e854d387c7c0d95b058c.1405533479.git.agordeev@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Delegated to: | Bjorn Helgaas |
| Headers | show |
On Wed, Jul 16, 2014 at 08:05:11PM +0200, Alexander Gordeev wrote: > As result of deprecation of MSI-X/MSI enablement functions > pci_enable_msix() and pci_enable_msi_block() all drivers > using these two interfaces need to be updated to use the > new pci_enable_msi_range() or pci_enable_msi_exact() > and pci_enable_msix_range() or pci_enable_msix_exact() > interfaces. Hi Hiral, Suma, Brian, Could you please review this patch? Thanks! > Signed-off-by: Alexander Gordeev <agordeev@redhat.com> > Cc: Hiral Patel <hiralpat@cisco.com> > Cc: Suma Ramars <sramars@cisco.com> > Cc: Brian Uchino <buchino@cisco.com> > Cc: linux-scsi@vger.kernel.org > Cc: linux-pci@vger.kernel.org > --- > drivers/scsi/fnic/fnic_isr.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/scsi/fnic/fnic_isr.c b/drivers/scsi/fnic/fnic_isr.c > index 7d9b54a..a0dd1b6 100644 > --- a/drivers/scsi/fnic/fnic_isr.c > +++ b/drivers/scsi/fnic/fnic_isr.c > @@ -257,8 +257,8 @@ int fnic_set_intr_mode(struct fnic *fnic) > fnic->raw_wq_count >= m && > fnic->wq_copy_count >= o && > fnic->cq_count >= n + m + o) { > - if (!pci_enable_msix(fnic->pdev, fnic->msix_entry, > - n + m + o + 1)) { > + if (!pci_enable_msix_exact(fnic->pdev, fnic->msix_entry, > + n + m + o + 1)) { > fnic->rq_count = n; > fnic->raw_wq_count = m; > fnic->wq_copy_count = o; > -- > 1.7.7.6 >
Acked-by: "Suma Ramars (sramars)" <sramars@cisco.com> On 26/07/14 1:45 pm, "Alexander Gordeev" <agordeev@redhat.com> wrote: >On Wed, Jul 16, 2014 at 08:05:11PM +0200, Alexander Gordeev wrote: >> As result of deprecation of MSI-X/MSI enablement functions >> pci_enable_msix() and pci_enable_msi_block() all drivers >> using these two interfaces need to be updated to use the >> new pci_enable_msi_range() or pci_enable_msi_exact() >> and pci_enable_msix_range() or pci_enable_msix_exact() >> interfaces. > >Hi Hiral, Suma, Brian, > >Could you please review this patch? > >Thanks! > >> Signed-off-by: Alexander Gordeev <agordeev@redhat.com> >> Cc: Hiral Patel <hiralpat@cisco.com> >> Cc: Suma Ramars <sramars@cisco.com> >> Cc: Brian Uchino <buchino@cisco.com> >> Cc: linux-scsi@vger.kernel.org >> Cc: linux-pci@vger.kernel.org >> --- >> drivers/scsi/fnic/fnic_isr.c | 4 ++-- >> 1 files changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/scsi/fnic/fnic_isr.c b/drivers/scsi/fnic/fnic_isr.c >> index 7d9b54a..a0dd1b6 100644 >> --- a/drivers/scsi/fnic/fnic_isr.c >> +++ b/drivers/scsi/fnic/fnic_isr.c >> @@ -257,8 +257,8 @@ int fnic_set_intr_mode(struct fnic *fnic) >> fnic->raw_wq_count >= m && >> fnic->wq_copy_count >= o && >> fnic->cq_count >= n + m + o) { >> - if (!pci_enable_msix(fnic->pdev, fnic->msix_entry, >> - n + m + o + 1)) { >> + if (!pci_enable_msix_exact(fnic->pdev, fnic->msix_entry, >> + n + m + o + 1)) { >> fnic->rq_count = n; >> fnic->raw_wq_count = m; >> fnic->wq_copy_count = o; >> -- >> 1.7.7.6 >> > >-- >Regards, >Alexander Gordeev >agordeev@redhat.com -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/scsi/fnic/fnic_isr.c b/drivers/scsi/fnic/fnic_isr.c index 7d9b54a..a0dd1b6 100644 --- a/drivers/scsi/fnic/fnic_isr.c +++ b/drivers/scsi/fnic/fnic_isr.c @@ -257,8 +257,8 @@ int fnic_set_intr_mode(struct fnic *fnic) fnic->raw_wq_count >= m && fnic->wq_copy_count >= o && fnic->cq_count >= n + m + o) { - if (!pci_enable_msix(fnic->pdev, fnic->msix_entry, - n + m + o + 1)) { + if (!pci_enable_msix_exact(fnic->pdev, fnic->msix_entry, + n + m + o + 1)) { fnic->rq_count = n; fnic->raw_wq_count = m; fnic->wq_copy_count = o;
As result of deprecation of MSI-X/MSI enablement functions pci_enable_msix() and pci_enable_msi_block() all drivers using these two interfaces need to be updated to use the new pci_enable_msi_range() or pci_enable_msi_exact() and pci_enable_msix_range() or pci_enable_msix_exact() interfaces. Signed-off-by: Alexander Gordeev <agordeev@redhat.com> Cc: Hiral Patel <hiralpat@cisco.com> Cc: Suma Ramars <sramars@cisco.com> Cc: Brian Uchino <buchino@cisco.com> Cc: linux-scsi@vger.kernel.org Cc: linux-pci@vger.kernel.org --- drivers/scsi/fnic/fnic_isr.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)