[v3,0/7] phy-rockchip-inno-usb2: add RK3588 support

Message

Sebastian Reichel May 22, 2023, 5:03 p.m. UTC

Hi,

This adds RK3588 to the Rockchip Inno USB2 PHY driver. The RK3588 has four of
them. Two are used for USB2 and two are used by USB3 controllers (for USB2
fallback mode). All of them can be used with this patchset.

Changes since PATCHv2:
 * https://lore.kernel.org/linux-phy/[e-mail]/
 * Dropped patch adding the syscon compatible to the DT binding (applied by Heiko)
 * Collected Reviewed-by from Rob Herring for DT binding patch (DT binding)
 * Rebased to v6.4-rc1
 * Removed superfluous init found by Vinod Koul
 * Added one additional patch improving the error message for missing phy-config
 * Fixed address_cells=2 code to not break the PHY at offset 0. I didn't notice it with the
   previous versions, since that PHY is used for USB3 on Rockchip evaluation board and I
   only started working on that recently.

Changes since PATCHv1:
 * https://lore.kernel.org/all/[e-mail]/
 * Added patch simplifying phyclk handling
 * Added patch simplifying matchdata handling
 * Added patches for reset handling and PHY tuning; after doing more
   testing I noticed my previous patchset does not support hotplug and
   USB devices need to be plugged in at boot time (more specifically
   in PATCHv1 it had to be plugged before the PHY is suspended). This
   fixes the issue.

-- Sebastian

Sebastian Reichel (7):
  dt-bindings: phy: rockchip,inno-usb2phy: add rk3588
  phy: phy-rockchip-inno-usb2: add rk3588 support
  phy: phy-rockchip-inno-usb2: add reset support
  phy: phy-rockchip-inno-usb2: add rk3588 phy tuning support
  phy: phy-rockchip-inno-usb2: simplify phy clock handling
  phy: phy-rockchip-inno-usb2: simplify getting match data
  phy: phy-rockchip-inno-usb2: improve error message

 .../bindings/phy/rockchip,inno-usb2phy.yaml   |  21 +-
 drivers/phy/rockchip/phy-rockchip-inno-usb2.c | 357 ++++++++++++++++--
 2 files changed, 339 insertions(+), 39 deletions(-)

Comments

Vinod Koul July 11, 2023, 7:44 a.m. UTC | #1

On Mon, 22 May 2023 19:03:17 +0200, Sebastian Reichel wrote:
> This adds RK3588 to the Rockchip Inno USB2 PHY driver. The RK3588 has four of
> them. Two are used for USB2 and two are used by USB3 controllers (for USB2
> fallback mode). All of them can be used with this patchset.
> 
> Changes since PATCHv2:
>  * https://lore.kernel.org/linux-phy/[e-mail]/
>  * Dropped patch adding the syscon compatible to the DT binding (applied by Heiko)
>  * Collected Reviewed-by from Rob Herring for DT binding patch (DT binding)
>  * Rebased to v6.4-rc1
>  * Removed superfluous init found by Vinod Koul
>  * Added one additional patch improving the error message for missing phy-config
>  * Fixed address_cells=2 code to not break the PHY at offset 0. I didn't notice it with the
>    previous versions, since that PHY is used for USB3 on Rockchip evaluation board and I
>    only started working on that recently.
> 
> [...]

Applied, thanks!

[1/7] dt-bindings: phy: rockchip,inno-usb2phy: add rk3588
      commit: 26720f89ee6878ef505812e852a3e914b7cbfe44
[2/7] phy: phy-rockchip-inno-usb2: add rk3588 support
      commit: 52b99b871eb79637342660b46c900642483d4412
[3/7] phy: phy-rockchip-inno-usb2: add reset support
      commit: 44d88aa9ae81c79ccc47ba4ef85aeda968bc4a50
[4/7] phy: phy-rockchip-inno-usb2: add rk3588 phy tuning support
      commit: 7d508a92e4588a59b909e235667d515051dd5955
[5/7] phy: phy-rockchip-inno-usb2: simplify phy clock handling
      commit: f4ca578b9803601074ab0d9e366b5fcda504e5a6
[6/7] phy: phy-rockchip-inno-usb2: simplify getting match data
      commit: 2e5ead8478e8e4a7b3d63a2001c2f0022b2f5e1b
[7/7] phy: phy-rockchip-inno-usb2: improve error message
      commit: e7254a4a7c444fa194440fa8dc73c7728e927162

Best regards,