| Message ID | 20240702180032.207275-1-biju.das.jz@bp.renesas.com |
|---|---|
| Headers | show |
| Series | Add USB VBUS regulator for RZ/G2L | expand |
On Di, 2024-07-02 at 19:00 +0100, Biju Das wrote: > As per RZ/G2L HW manual, VBUS enable can be controlled by the VBOUT bit of > the VBUS Control Register(VBENCTL) register in the USBPHY Control. But > this IP is in the Reset block. > > Reset driver exposes this register as regmap and instantiate the USB VBUS > regulator device. Consumers(phy device) can use regulator APIs to control > VBUS as controlling is done in the atomic context. > > Looks like this patch series can be taken via reset tree, once Geeert > provides Ack for board dtsi patch?? I can pull in https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git tags/regulator-hw-enable-helper and apply the whole series with Geert's ack on patch 4. regards Philipp
As per RZ/G2L HW manual, VBUS enable can be controlled by the VBOUT bit of the VBUS Control Register(VBENCTL) register in the USBPHY Control. But this IP is in the Reset block. Reset driver exposes this register as regmap and instantiate the USB VBUS regulator device. Consumers(phy device) can use regulator APIs to control VBUS as controlling is done in the atomic context. Looks like this patch series can be taken via reset tree, once Geeert provides Ack for board dtsi patch?? v4->v5: * Dropped regulator Patches #3 and #4 as patch#3 is going to be applied in Linux 6.10-rc5 and patch#4 is already in regulator/next tree. * Added Rb tag from Krzysztof for the binding patch. * Rebased and fixed the merge conflicts for patch#2(rzg2l-usbphy-ctrl). * Added Ack from Vinod for phy driver patch#5. * Updated commit description for board dtsi patch. v3->v4: * Fixed example indentation to 4 char spaces in patch#1 * Dropped regulator-{min,max}-microvolt from example. * Updated commit header and description in patch#3 * Replaced regulator_set_hardware_enable_register()->regulator_hardware_enable() * Updated documentation to "must use of regulator_get_exclusive() for consumers" * Enforced exclusive access in regulator_hardware_enable(). * Added generic support regulator_hardware_enable(). * Added check for of_get_child_by_name(). * Released the resource by of_node_put() * Updated commit description with regulator_hardware_enable() * Used devm_regulator_get_exclusive() to get regulator handle. * Dropped regulator-{min,max}-microvolt. v2->v3: * Documented regulator-vbus in the binding file. * Updated commit description and header for patch#2 * Moved regulator device creation and instantiation at the end of probe(). * Introduced new API regulator_set_hardware_enable_register() to enable/disable regulator in atomic context. * Dropped vbus_voltages table from patch#4 * Added support for enabling/disabling regulator through regmap API's * Updated rzg2l_usb_vbus_rdesc with enable_{reg,mask}, fixed_uV and n_voltages * Updated of_node with child node of the parent device. * Replaced regulator's regmap API with newly introduced regulator_set_hardware_enable_register to enable/disable regulator in interrupt context in patch#5 * Dropped using "usb_vbus-supply" in patch#5. * Upated vbus regulator label name in dts file. * Updated node and regulator name that matches with the binding documentation. v1->v2: * Introduced a regulator driver to control VBUS Biju Das (4): dt-bindings: reset: renesas,rzg2l-usbphy-ctrl: Document USB VBUS regulator reset: renesas: Add USB VBUS regulator device as child phy: renesas: phy-rcar-gen3-usb2: Control VBUS for RZ/G2L SoCs arm64: dts: renesas: rz-smarc: Replace fixed regulator for USB VBUS .../reset/renesas,rzg2l-usbphy-ctrl.yaml | 10 ++++++ .../boot/dts/renesas/rz-smarc-common.dtsi | 11 ++----- drivers/phy/renesas/phy-rcar-gen3-usb2.c | 8 ++++- drivers/reset/reset-rzg2l-usbphy-ctrl.c | 31 +++++++++++++++++++ 4 files changed, 51 insertions(+), 9 deletions(-)