From patchwork Wed Feb 26 10:35:58 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wenbin Yao X-Patchwork-Id: 13992025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 93895C021B8 for ; Wed, 26 Feb 2025 10:48:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=20r9X+C5XbMBROzXRv2wiR11wf3mgQIPzfkc16w80jw=; b=QVCdKhBgnF0h65 QRC2roCwXUctNiCnkDCJBMcKLR+IQRSpe1QPHJp/kk954FIJEslPPDUO4bIW4fnaSeZ7fn2cj1b9j fsPFr5OUJlQp6cuSTHcwZzbp+TLAgWuGjsjhvAAfDnyWoz+ibY5pl0FqDy0NQypSlJhzOTsmG1rJ3 yAhHyNnx57Of8kLxp2JTti7My3k1OnP3eS2bEVKuCTDHb7KGBIgChp4bff3KDr0sBOJKkbaKgt+EL DI5CHo6fTqFQgtjkapmOM2iaSpxIlUQlx0pbYoaWS4Lz5AL2V2KxpFNozDpUTzw07fDMWcMeWmd4M vHFhOiUZt/3SY4bkjW+Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tnExr-00000003MIn-19SW; Wed, 26 Feb 2025 10:48:31 +0000 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tnElv-00000003Jqg-1uMR for linux-phy@lists.infradead.org; Wed, 26 Feb 2025 10:36:13 +0000 Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 51Q9s2eX011698; Wed, 26 Feb 2025 10:36:06 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= cc:content-transfer-encoding:date:from:message-id:mime-version :subject:to; s=qcppdkim1; bh=gia87sU3TdGN7wwxbdDe6jcxSYNCi0evg5C 9blwswhc=; b=eAHBHaUkG2qIiTOQSpzJZf9yYPC4RAyJMTxmMPFeQRPhfD1XG8J l2palYZPNPyVP1CElXtkKkyoz40g63orqYOyD/JxZ38PQKfUONyIATC2KwVcrRcA K1x0QPxXUzfyv/m7mWM0E5OPOk+/2n+Td1mpNHqS4aXENl8Ld0SHOKRR9Hq/ah7O 2MAzk5nru2z2GDd/cLU3wjcApnBX6W36syDHY1p1FnFCQAOJEwlMEqoaijv5HfK4 W7JuF8JyQ/BQqaGTETDb4JvUpPXJt813kFegl+H35B4/51Kn9hGz/kklLlyTnOMg NJTGi0OkVWZz1E8yr9lsLiLCERWQGXKIV/w== Received: from aptaippmta02.qualcomm.com (tpe-colo-wan-fw-bordernet.qualcomm.com [103.229.16.4]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 451prk9n7y-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 26 Feb 2025 10:36:06 +0000 (GMT) Received: from pps.filterd (APTAIPPMTA02.qualcomm.com [127.0.0.1]) by APTAIPPMTA02.qualcomm.com (8.18.1.2/8.18.1.2) with ESMTP id 51QAa3xP023967; Wed, 26 Feb 2025 10:36:03 GMT Received: from pps.reinject (localhost [127.0.0.1]) by APTAIPPMTA02.qualcomm.com (PPS) with ESMTPS id 44y7nm1d86-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 26 Feb 2025 10:36:03 +0000 Received: from APTAIPPMTA02.qualcomm.com (APTAIPPMTA02.qualcomm.com [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 51QAa3g5023958; Wed, 26 Feb 2025 10:36:03 GMT Received: from cbsp-sh-gv.ap.qualcomm.com (CBSP-SH-gv.ap.qualcomm.com [10.231.249.68]) by APTAIPPMTA02.qualcomm.com (PPS) with ESMTPS id 51QAa2oI023955 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 26 Feb 2025 10:36:03 +0000 Received: by cbsp-sh-gv.ap.qualcomm.com (Postfix, from userid 4635958) id 5027B40DA1; Wed, 26 Feb 2025 18:36:02 +0800 (CST) From: Wenbin Yao To: vkoul@kernel.org, kishon@kernel.org, p.zabel@pengutronix.de, dmitry.baryshkov@linaro.org, abel.vesa@linaro.org, quic_qianyu@quicinc.com, neil.armstrong@linaro.org, manivannan.sadhasivam@linaro.org, quic_devipriy@quicinc.com, konrad.dybcio@oss.qualcomm.com, linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org Cc: quic_wenbyao@quicinc.com Subject: [PATCH v5 0/2] phy: qcom: qmp-pcie: Add PCIe PHY no_csr reset support Date: Wed, 26 Feb 2025 18:35:58 +0800 Message-Id: <20250226103600.1923047-1-quic_wenbyao@quicinc.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-QCInternal: smtphost X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: O85JKIw47XFGIUuU_7LTqHJVDLu4vrUS X-Proofpoint-ORIG-GUID: O85JKIw47XFGIUuU_7LTqHJVDLu4vrUS X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1057,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-02-26_02,2025-02-26_01,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 mlxscore=0 bulkscore=0 lowpriorityscore=0 phishscore=0 clxscore=1015 malwarescore=0 impostorscore=0 adultscore=0 priorityscore=1501 spamscore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2502100000 definitions=main-2502260084 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250226_023611_714738_F72F55D2 X-CRM114-Status: GOOD ( 10.18 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org The series aims to skip phy register programming and drive PCIe PHY with register setting programmed in bootloader by simply toggling no_csr reset, which once togglled, PHY hardware will be reset while PHY registers are retained. First, determine whether PHY setting can be skipped by checking QPHY_START_CTRL register and the existence of nocsr reset. If it is programmed and no_csr reset is supported, do no_csr reset and skip BCR reset which will reset entire PHY. This series also remove has_nocsr_reset flag in qmp_phy_cfg structure and decide whether the PHY supports nocsr reset by checking the existence of nocsr reset in device tree. The series are tested on X1E80100-QCP and HDK8550. The commit messages of this patchset have been modified based on comments and suggestions. Changes in v5: - Add a check whether the init sequences are exist if the PHY needs to be initialized to Patch 2/2. - Link to v4: https://lore.kernel.org/all/20250220102253.755116-1-quic_wenbyao@quicinc.com/ Changes in v4: - Add Philipp's Reviewed-by tag to Patch 1/2. - Use PHY instead of phy in comments in Patch 2/2. - Use "if (qmp->nocsr_reset)" instead of "if (!qmp->nocsr_reset)" in function qmp_pcie_exit for readability in Patch 2/2. - Use goto statements in function qmp_pcie_power_on and qmp_pcie_power_off for readability in Patch 2/2. - Refine the comment of why not checking qmp->skip_init when reset PHY in function qmp_pcie_power_off in Patch 2/2. - Link to v3: https://lore.kernel.org/all/20250214104539.281846-1-quic_wenbyao@quicinc.com/ Changes in v3: - Replace devm_reset_control_get_exclusive with devm_reset_control_get_optional_exclusive when get phy_nocsr reset control in Patch 1/2. - Do not ignore -EINVAL when get phy_nocsr reset control in Patch 1/2. - Replace phy_initialized with skip_init in struct qmp_pcie in Patch 2/2. - Add a comment to why not check qmp->skip_init in function qmp_pcie_power_off in Patch 2/2. - Link to v2: https://lore.kernel.org/all/20250211094231.1813558-1-quic_wenbyao@quicinc.com/ Changes in v2: - Add Abel's and Manivannan's Reviewed-by tag to Patch 1/2. - Refine commit msg of Patch 2/2. - Link to v1: https://lore.kernel.org/all/20250121094140.4006801-1-quic_wenbyao@quicinc.com/ Konrad Dybcio (1): phy: qcom: pcie: Determine has_nocsr_reset dynamically Qiang Yu (1): phy: qcom: qmp-pcie: Add PHY register retention support drivers/phy/qualcomm/phy-qcom-qmp-pcie.c | 86 +++++++++++++++++------- 1 file changed, 63 insertions(+), 23 deletions(-) base-commit: bcf2acd8f64b0a5783deeeb5fd70c6163ec5acd7