| Message ID | 20210305034931.3237558-1-weiyongjun1@huawei.com |
|---|---|
| State | Accepted |
| Commit | 7e9908d1ab2e76cfb08bc1f602688486b0ed9952 |
| Headers | show |
| Series | [-next] phy: ralink: phy-mt7621-pci: fix return value check in mt7621_pci_phy_probe() | expand |
On Fri, Mar 5, 2021 at 4:40 AM 'Wei Yongjun <weiyongjun1@huawei.com> wrote: > > From: Wei Yongjun <weiyongjun1@huawei.com> > > Fix the return value check which testing the wrong variable > in mt7621_pci_phy_probe(). > > Fixes: d87da32372a0 ("phy: ralink: Add PHY driver for MT7621 PCIe PHY") > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> > --- > drivers/phy/ralink/phy-mt7621-pci.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
On 05-03-21, 03:49, 'Wei Yongjun wrote: > From: Wei Yongjun <weiyongjun1@huawei.com> > > Fix the return value check which testing the wrong variable > in mt7621_pci_phy_probe(). Applied, thanks
diff --git a/drivers/phy/ralink/phy-mt7621-pci.c b/drivers/phy/ralink/phy-mt7621-pci.c index 84ee2b5c2228..753cb5bab930 100644 --- a/drivers/phy/ralink/phy-mt7621-pci.c +++ b/drivers/phy/ralink/phy-mt7621-pci.c @@ -319,9 +319,9 @@ static int mt7621_pci_phy_probe(struct platform_device *pdev) return PTR_ERR(phy->regmap); phy->phy = devm_phy_create(dev, dev->of_node, &mt7621_pci_phy_ops); - if (IS_ERR(phy)) { + if (IS_ERR(phy->phy)) { dev_err(dev, "failed to create phy\n"); - return PTR_ERR(phy); + return PTR_ERR(phy->phy); } phy_set_drvdata(phy->phy, phy);