| Message ID | 20210331131417.15596-1-kishon@ti.com |
|---|---|
| State | Accepted |
| Commit | 36a813839cdee99c87e17a2d52a009b5517d54a9 |
| Headers | show |
| Series | phy: ti: j721e-wiz: Configure 'p_standard_mode' only for DP/QSGMII | expand |
On 31-03-21, 18:44, Kishon Vijay Abraham I wrote: > Configure 'p_standard_mode' only for DP/QSGMII as for other modes > it's not used as per the programming sequence. Add "continue" in the > else to prevent random value from being written to p_standard_mode. Applied, thanks
diff --git a/drivers/phy/ti/phy-j721e-wiz.c b/drivers/phy/ti/phy-j721e-wiz.c index 95905e5c4f3d..fc636233dbd6 100644 --- a/drivers/phy/ti/phy-j721e-wiz.c +++ b/drivers/phy/ti/phy-j721e-wiz.c @@ -340,6 +340,8 @@ static int wiz_mode_select(struct wiz *wiz) mode = LANE_MODE_GEN1; else if (wiz->lane_phy_type[i] == PHY_TYPE_QSGMII) mode = LANE_MODE_GEN2; + else + continue; ret = regmap_field_write(wiz->p_standard_mode[i], mode); if (ret)
Configure 'p_standard_mode' only for DP/QSGMII as for other modes it's not used as per the programming sequence. Add "continue" in the else to prevent random value from being written to p_standard_mode. Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com> --- drivers/phy/ti/phy-j721e-wiz.c | 2 ++ 1 file changed, 2 insertions(+)