| Message ID | 20210603051014.2674744-1-yangyingliang@huawei.com |
|---|---|
| State | Accepted |
| Commit | d1ce245fe409241ed6168c835a5b55ef52bdb6a9 |
| Headers | show |
| Series | [-next] phy: Sparx5 Eth SerDes: check return value after calling platform_get_resource() | expand |
On 03-06-21, 13:10, Yang Yingliang wrote: > It will cause null-ptr-deref if platform_get_resource() returns NULL, > we need check the return value. Applied, thanks
diff --git a/drivers/phy/microchip/sparx5_serdes.c b/drivers/phy/microchip/sparx5_serdes.c index c8a7d0927ced..4076580fc2cd 100644 --- a/drivers/phy/microchip/sparx5_serdes.c +++ b/drivers/phy/microchip/sparx5_serdes.c @@ -2470,6 +2470,10 @@ static int sparx5_serdes_probe(struct platform_device *pdev) priv->coreclock = clock; iores = platform_get_resource(pdev, IORESOURCE_MEM, 0); + if (!iores) { + dev_err(priv->dev, "Invalid resource\n"); + return -EINVAL; + } iomem = devm_ioremap(priv->dev, iores->start, resource_size(iores)); if (IS_ERR(iomem)) { dev_err(priv->dev, "Unable to get serdes registers: %s\n",
It will cause null-ptr-deref if platform_get_resource() returns NULL, we need check the return value. Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> --- drivers/phy/microchip/sparx5_serdes.c | 4 ++++ 1 file changed, 4 insertions(+)