| Message ID | 20211107075646.4366-3-chunfeng.yun@mediatek.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [1/6] dt-bindings: nvmem: mediatek: add support bits property | expand |
On 07/11/2021 07:56, Chunfeng Yun wrote: > In order to support nvmem bits property, should support minimum 1 byte > read stride and minimum 1 byte read granularity at the same time. > > Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com> Applied thanks, --srini > --- > drivers/nvmem/mtk-efuse.c | 13 +++++++------ > 1 file changed, 7 insertions(+), 6 deletions(-) > > diff --git a/drivers/nvmem/mtk-efuse.c b/drivers/nvmem/mtk-efuse.c > index 6a537d959f14..e9a375dd84af 100644 > --- a/drivers/nvmem/mtk-efuse.c > +++ b/drivers/nvmem/mtk-efuse.c > @@ -19,11 +19,12 @@ static int mtk_reg_read(void *context, > unsigned int reg, void *_val, size_t bytes) > { > struct mtk_efuse_priv *priv = context; > - u32 *val = _val; > - int i = 0, words = bytes / 4; > + void __iomem *addr = priv->base + reg; > + u8 *val = _val; > + int i; > > - while (words--) > - *val++ = readl(priv->base + reg + (i++ * 4)); > + for (i = 0; i < bytes; i++, val++) > + *val = readb(addr + i); > > return 0; > } > @@ -45,8 +46,8 @@ static int mtk_efuse_probe(struct platform_device *pdev) > if (IS_ERR(priv->base)) > return PTR_ERR(priv->base); > > - econfig.stride = 4; > - econfig.word_size = 4; > + econfig.stride = 1; > + econfig.word_size = 1; > econfig.reg_read = mtk_reg_read; > econfig.size = resource_size(res); > econfig.priv = priv; >
diff --git a/drivers/nvmem/mtk-efuse.c b/drivers/nvmem/mtk-efuse.c index 6a537d959f14..e9a375dd84af 100644 --- a/drivers/nvmem/mtk-efuse.c +++ b/drivers/nvmem/mtk-efuse.c @@ -19,11 +19,12 @@ static int mtk_reg_read(void *context, unsigned int reg, void *_val, size_t bytes) { struct mtk_efuse_priv *priv = context; - u32 *val = _val; - int i = 0, words = bytes / 4; + void __iomem *addr = priv->base + reg; + u8 *val = _val; + int i; - while (words--) - *val++ = readl(priv->base + reg + (i++ * 4)); + for (i = 0; i < bytes; i++, val++) + *val = readb(addr + i); return 0; } @@ -45,8 +46,8 @@ static int mtk_efuse_probe(struct platform_device *pdev) if (IS_ERR(priv->base)) return PTR_ERR(priv->base); - econfig.stride = 4; - econfig.word_size = 4; + econfig.stride = 1; + econfig.word_size = 1; econfig.reg_read = mtk_reg_read; econfig.size = resource_size(res); econfig.priv = priv;
In order to support nvmem bits property, should support minimum 1 byte read stride and minimum 1 byte read granularity at the same time. Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com> --- drivers/nvmem/mtk-efuse.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-)