| Message ID | 20211215060834.921617-1-vkoul@kernel.org |
|---|---|
| State | Accepted |
| Commit | c8d09c7ebcffcbc734eee45c92f11d6ec8884b92 |
| Headers | show |
| Series | phy: freescale: pcie: explictly add bitfield.h | expand |
> -----Original Message----- > From: Vinod Koul <vkoul@kernel.org> > Sent: Wednesday, December 15, 2021 2:09 PM > To: Kishon Vijay Abraham I <kishon@ti.com>; Hongxing Zhu > <hongxing.zhu@nxp.com> > Cc: linux-phy@lists.infradead.org; Vinod Koul <vkoul@kernel.org>; > linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org; > kernel test robot <lkp@intel.com> > Subject: [PATCH] phy: freescale: pcie: explictly add bitfield.h > > kernel test robot complains about missing FIELD_PREP, so include > bitfield.h for that > > drivers/phy/freescale/phy-fsl-imx8m-pcie.c:41:37: error: implicit > declaration of function 'FIELD_PREP' > [-Werror=implicit-function-declaration] > drivers/phy/freescale/phy-fsl-imx8m-pcie.c:41:41: error: implicit > declaration of function 'FIELD_PREP' > [-Werror=implicit-function-declaration] > > Reported-by: kernel test robot <lkp@intel.com> > Fixes: 1aa97b002258 ("phy: freescale: pcie: Initialize the imx8 pcie > standalone phy driver") > Signed-off-by: Vinod Koul <vkoul@kernel.org> Reviewed-by: Richard Zhu <hongxing.zhu@nxp.com> Thanks a lot for your help to fix it. And I'm sorry about that I didn't capture this error in my local build and tests. Best Regards Richard Zhu > --- > drivers/phy/freescale/phy-fsl-imx8m-pcie.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/phy/freescale/phy-fsl-imx8m-pcie.c > b/drivers/phy/freescale/phy-fsl-imx8m-pcie.c > index f6502463d49a..04b1aafb29f4 100644 > --- a/drivers/phy/freescale/phy-fsl-imx8m-pcie.c > +++ b/drivers/phy/freescale/phy-fsl-imx8m-pcie.c > @@ -3,6 +3,7 @@ > * Copyright 2021 NXP > */ > > +#include <linux/bitfield.h> > #include <linux/clk.h> > #include <linux/io.h> > #include <linux/iopoll.h> > -- > 2.31.1
On 15-12-21, 06:29, Hongxing Zhu wrote: > > -----Original Message----- > > From: Vinod Koul <vkoul@kernel.org> > > Sent: Wednesday, December 15, 2021 2:09 PM > > To: Kishon Vijay Abraham I <kishon@ti.com>; Hongxing Zhu > > <hongxing.zhu@nxp.com> > > Cc: linux-phy@lists.infradead.org; Vinod Koul <vkoul@kernel.org>; > > linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org; > > kernel test robot <lkp@intel.com> > > Subject: [PATCH] phy: freescale: pcie: explictly add bitfield.h > > > > kernel test robot complains about missing FIELD_PREP, so include > > bitfield.h for that > > > > drivers/phy/freescale/phy-fsl-imx8m-pcie.c:41:37: error: implicit > > declaration of function 'FIELD_PREP' > > [-Werror=implicit-function-declaration] > > drivers/phy/freescale/phy-fsl-imx8m-pcie.c:41:41: error: implicit > > declaration of function 'FIELD_PREP' > > [-Werror=implicit-function-declaration] > > > > Reported-by: kernel test robot <lkp@intel.com> > > Fixes: 1aa97b002258 ("phy: freescale: pcie: Initialize the imx8 pcie > > standalone phy driver") > > Signed-off-by: Vinod Koul <vkoul@kernel.org> > Reviewed-by: Richard Zhu <hongxing.zhu@nxp.com> Thanks for quick review, I have pushed this > Thanks a lot for your help to fix it. > And I'm sorry about that I didn't capture this error in my local build and tests. No worries, Do test on different arch's other than yours
diff --git a/drivers/phy/freescale/phy-fsl-imx8m-pcie.c b/drivers/phy/freescale/phy-fsl-imx8m-pcie.c index f6502463d49a..04b1aafb29f4 100644 --- a/drivers/phy/freescale/phy-fsl-imx8m-pcie.c +++ b/drivers/phy/freescale/phy-fsl-imx8m-pcie.c @@ -3,6 +3,7 @@ * Copyright 2021 NXP */ +#include <linux/bitfield.h> #include <linux/clk.h> #include <linux/io.h> #include <linux/iopoll.h>
kernel test robot complains about missing FIELD_PREP, so include bitfield.h for that drivers/phy/freescale/phy-fsl-imx8m-pcie.c:41:37: error: implicit declaration of function 'FIELD_PREP' [-Werror=implicit-function-declaration] drivers/phy/freescale/phy-fsl-imx8m-pcie.c:41:41: error: implicit declaration of function 'FIELD_PREP' [-Werror=implicit-function-declaration] Reported-by: kernel test robot <lkp@intel.com> Fixes: 1aa97b002258 ("phy: freescale: pcie: Initialize the imx8 pcie standalone phy driver") Signed-off-by: Vinod Koul <vkoul@kernel.org> --- drivers/phy/freescale/phy-fsl-imx8m-pcie.c | 1 + 1 file changed, 1 insertion(+)