| Message ID | 20220228123019.382037-2-bhupesh.sharma@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Fix dtbs_check warning(s) for Qualcomm QMP PHY | expand |
On Mon, Feb 28, 2022 at 06:00:12PM +0530, Bhupesh Sharma wrote: > Since '#clock-cells' is not a required property for qmp-phy(s) > (atleast in the '/' node, but is used in 'phy@' subnode), > so mark it as an optional property instead. My understanding is that '#clock-cells' shouldn't be a property of qmp-phy node itself at all (not even optional), but a required property of 'phy' subnode. > > This fixes the following 'make dtbs_check' warning(s): > > sm8350-microsoft-surface-duo2.dt.yaml: phy@1d87000: > '#clock-cells' is a required property > > Also, make the dt-bindings confirm to changes > already made via commit 82d61e19fccb ("arm64: dts: qcom: msm8996: > Move '#clock-cells' to QMP PHY child node"), by moving > '#clock-cells' property from the '/' node to the 'phy@' subnode. > > Cc: Bjorn Andersson <bjorn.andersson@linaro.org> > Cc: Vinod Koul <vkoul@kernel.org> > Cc: Rob Herring <robh+dt@kernel.org> > Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org> > --- > Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml | 8 +++----- > 1 file changed, 3 insertions(+), 5 deletions(-) > > diff --git a/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml > index e417cd667997..48cd6b6171a1 100644 > --- a/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml > +++ b/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml > @@ -63,9 +63,6 @@ properties: > - description: Address and length of PHY's common serdes block. > - description: Address and length of PHY's DP_COM control block. > > - "#clock-cells": > - enum: [ 1, 2 ] > - > "#address-cells": > enum: [ 1, 2 ] > > @@ -109,11 +106,13 @@ patternProperties: > description: > Each device node of QMP phy is required to have as many child nodes as > the number of lanes the PHY has. > + properties: > + "#clock-cells": > + enum: [ 0, 1, 2 ] I'm not sure how to specify this is a required property for the child node. Or is this already the case, @Rob? > > required: > - compatible > - reg > - - "#clock-cells" > - "#address-cells" > - "#size-cells" > - ranges > @@ -461,7 +460,6 @@ examples: > usb_2_qmpphy: phy-wrapper@88eb000 { > compatible = "qcom,sdm845-qmp-usb3-uni-phy"; > reg = <0x088eb000 0x18c>; > - #clock-cells = <1>; These two changes look good to me. Shawn > #address-cells = <1>; > #size-cells = <1>; > ranges = <0x0 0x088eb000 0x2000>; > -- > 2.35.1 >
diff --git a/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml index e417cd667997..48cd6b6171a1 100644 --- a/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml +++ b/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml @@ -63,9 +63,6 @@ properties: - description: Address and length of PHY's common serdes block. - description: Address and length of PHY's DP_COM control block. - "#clock-cells": - enum: [ 1, 2 ] - "#address-cells": enum: [ 1, 2 ] @@ -109,11 +106,13 @@ patternProperties: description: Each device node of QMP phy is required to have as many child nodes as the number of lanes the PHY has. + properties: + "#clock-cells": + enum: [ 0, 1, 2 ] required: - compatible - reg - - "#clock-cells" - "#address-cells" - "#size-cells" - ranges @@ -461,7 +460,6 @@ examples: usb_2_qmpphy: phy-wrapper@88eb000 { compatible = "qcom,sdm845-qmp-usb3-uni-phy"; reg = <0x088eb000 0x18c>; - #clock-cells = <1>; #address-cells = <1>; #size-cells = <1>; ranges = <0x0 0x088eb000 0x2000>;
Since '#clock-cells' is not a required property for qmp-phy(s) (atleast in the '/' node, but is used in 'phy@' subnode), so mark it as an optional property instead. This fixes the following 'make dtbs_check' warning(s): sm8350-microsoft-surface-duo2.dt.yaml: phy@1d87000: '#clock-cells' is a required property Also, make the dt-bindings confirm to changes already made via commit 82d61e19fccb ("arm64: dts: qcom: msm8996: Move '#clock-cells' to QMP PHY child node"), by moving '#clock-cells' property from the '/' node to the 'phy@' subnode. Cc: Bjorn Andersson <bjorn.andersson@linaro.org> Cc: Vinod Koul <vkoul@kernel.org> Cc: Rob Herring <robh+dt@kernel.org> Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org> --- Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-)