diff mbox series

[RESEND,1/2] phy: samsung: Fix missing of_node_put() in exynos_sata_phy_probe

Message ID 20220407091857.230386-1-krzysztof.kozlowski@linaro.org
State Accepted
Commit 388ec8f079f2f20d5cd183c3bc6f33cbc3ffd3ef
Headers show
Series [RESEND,1/2] phy: samsung: Fix missing of_node_put() in exynos_sata_phy_probe | expand

Commit Message

Krzysztof Kozlowski April 7, 2022, 9:18 a.m. UTC 
From: Miaoqian Lin <linmq006@gmail.com>

The device_node pointer is returned by of_parse_phandle() with refcount
incremented. We should use of_node_put() on it when done.

Fixes: bcff4cba41bc ("PHY: Exynos: Add Exynos5250 SATA PHY driver")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 drivers/phy/samsung/phy-exynos5250-sata.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Vinod Koul April 11, 2022, 5:16 p.m. UTC | #1 
On 07-04-22, 11:18, Krzysztof Kozlowski wrote:
> From: Miaoqian Lin <linmq006@gmail.com>
> 
> The device_node pointer is returned by of_parse_phandle() with refcount
> incremented. We should use of_node_put() on it when done.

Applied all, thanks
diff mbox series

Patch

diff --git a/drivers/phy/samsung/phy-exynos5250-sata.c b/drivers/phy/samsung/phy-exynos5250-sata.c
index 9ec234243f7c..6c305a3fe187 100644
--- a/drivers/phy/samsung/phy-exynos5250-sata.c
+++ b/drivers/phy/samsung/phy-exynos5250-sata.c
@@ -187,6 +187,7 @@  static int exynos_sata_phy_probe(struct platform_device *pdev)
 		return -EINVAL;
 
 	sata_phy->client = of_find_i2c_device_by_node(node);
+	of_node_put(node);
 	if (!sata_phy->client)
 		return -EPROBE_DEFER;