| Message ID | 20220716145403.107703-1-u.kleine-koenig@pengutronix.de |
|---|---|
| State | Accepted |
| Commit | 533e13305c16c63915f7cc8a36ed7ef717e15378 |
| Headers | show |
| Series | phy: tegra: xusb: Only warn once reset problems in .remove() | expand |
Hello, $Subject ~= s/once reset/once about reset/ . Should I resend, or can you fixup when applying this patch? (Assuming you're otherwise happy with the change of course.) Best regards Uwe
On 18-07-22, 09:53, Uwe Kleine-König wrote: > Hello, > > $Subject ~= s/once reset/once about reset/ > > . Should I resend, or can you fixup when applying this patch? (Assuming > you're otherwise happy with the change of course.) Applied with updated subject :)
diff --git a/drivers/phy/tegra/xusb.c b/drivers/phy/tegra/xusb.c index aa5237eacd29..d04a80c436c3 100644 --- a/drivers/phy/tegra/xusb.c +++ b/drivers/phy/tegra/xusb.c @@ -1270,7 +1270,7 @@ static int tegra_xusb_padctl_remove(struct platform_device *pdev) padctl->soc->ops->remove(padctl); - return err; + return 0; } static __maybe_unused int tegra_xusb_padctl_suspend_noirq(struct device *dev)
The single difference between returning 0 and returning an error code in a platform remove callback is that in the latter case the platform core emits a warning about the error being ignored. If reset_control_assert() fails there is already a warning, so suppress the more generic (and less helpful) by returning 0 in tegra_xusb_padctl_remove(). This is a preparation for making platform remove callbacks return void. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> --- drivers/phy/tegra/xusb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) base-commit: f2906aa863381afb0015a9eb7fefad885d4e5a56