From patchwork Sat Jul 16 14:54:03 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 12920186 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D646DC433EF for ; Sat, 16 Jul 2022 14:54:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=2NeIAuQEBlNEpeL5tHkKYWNZL+EYd+LmVIG63s35V7Y=; b=qBdLph9VzgxJOU cZV3RTjgAepyUGNx9wZCHJYCRKQUJoNRR6f3jMqTLoOcB3xtKDEKGsEraxEZ6UOYjMLyECUb7eOc9 hujlYzdq66XSsX8uByqxYZxgzm3VHYtoqnc4o8fDcwuMDBdHM2Yq0A5WWjUsPLO0ftic/OQ70IERb jgF8vgC5R6FUk25Li9+5KmvodWzAkASHLhyhIoXE5YKD/wiIgp5Mt0Ngsm0ckyfvCW1IQ8mY7CMGx YHlW2roXVs6eeQcaDmtwW8EJ1BFgDY6hxKs3aWRJpwC2CiTvHzYYd/bcMSOI3fxtBeePlVS/kAZOT YCOcFrLdDg+GbC2o+ZnA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oCjBU-00GeL5-7D; Sat, 16 Jul 2022 14:54:20 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oCjBR-00GeJ5-T9 for linux-phy@lists.infradead.org; Sat, 16 Jul 2022 14:54:19 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oCjBK-0003OV-14; Sat, 16 Jul 2022 16:54:10 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1oCjBI-001Kha-7Y; Sat, 16 Jul 2022 16:54:08 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1oCjBH-005ZBr-Kc; Sat, 16 Jul 2022 16:54:07 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: JC Kuo , Kishon Vijay Abraham I , Vinod Koul , Thierry Reding , Jonathan Hunter , Philipp Zabel Cc: linux-phy@lists.infradead.org, linux-tegra@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH] phy: tegra: xusb: Only warn once reset problems in .remove() Date: Sat, 16 Jul 2022 16:54:03 +0200 Message-Id: <20220716145403.107703-1-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.36.1 MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1075; h=from:subject; bh=+wlILHjFxool2OFqmTfWn6VwhkGltRaqS5h5LpHwcZI=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBi0tEHRUXoJWlLCxORP3UCsI3c7+s+XgZ7b5wxGoh+ NzT8ot2JATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCYtLRBwAKCRDB/BR4rcrsCeFgB/ 9AqumZjLU6uRJER3EbkEiH8uzcO+iJ+Xej/90eJPRFJ+cXHYUBXf85Z2+4yjGusY9NO/oJGXArkPW/ Pp8uuQTLKi6ruFl3l0cjmIGDdbPxdEjdcLk3p+BQvCH+GBtHC3Dwk4yJnOsShn7Rg+0CrxpMIdmaOM XeGhSiuHlMKyDhJbnP0TnSx0tzDPOGPH+Ys5Wc2nNpVsqLT4d3blkKa06wk8AwHZMqo34c31B5hoe3 FAD5s3yUszHJEAwuJ8PqBV4ILOEjzhkIYI1jsKlWdIdxoSEfq1aN4wE0a/OahPslxnQwdhlFJr4NTa NJOqpjwo3jCfoc5Z+0dGBLKeyd9TY1 X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-phy@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220716_075417_961928_C2554DFB X-CRM114-Status: GOOD ( 13.64 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org The single difference between returning 0 and returning an error code in a platform remove callback is that in the latter case the platform core emits a warning about the error being ignored. If reset_control_assert() fails there is already a warning, so suppress the more generic (and less helpful) by returning 0 in tegra_xusb_padctl_remove(). This is a preparation for making platform remove callbacks return void. Signed-off-by: Uwe Kleine-König --- drivers/phy/tegra/xusb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) base-commit: f2906aa863381afb0015a9eb7fefad885d4e5a56 diff --git a/drivers/phy/tegra/xusb.c b/drivers/phy/tegra/xusb.c index aa5237eacd29..d04a80c436c3 100644 --- a/drivers/phy/tegra/xusb.c +++ b/drivers/phy/tegra/xusb.c @@ -1270,7 +1270,7 @@ static int tegra_xusb_padctl_remove(struct platform_device *pdev) padctl->soc->ops->remove(padctl); - return err; + return 0; } static __maybe_unused int tegra_xusb_padctl_suspend_noirq(struct device *dev)