| Message ID | 20230210061713.6449-3-changhuang.liang@starfivetech.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Add JH7110 MIPI DPHY RX support | expand |
On Thu, 09 Feb 2023 22:17:11 -0800, Changhuang Liang wrote: > Starfive SoC like the jh7110 use a MIPI D-PHY RX controller based on > a M31 IP. Add a binding for it. > > Signed-off-by: Changhuang Liang <changhuang.liang@starfivetech.com> > --- > .../bindings/phy/starfive,jh7110-dphy-rx.yaml | 78 +++++++++++++++++++ > 1 file changed, 78 insertions(+) > create mode 100644 Documentation/devicetree/bindings/phy/starfive,jh7110-dphy-rx.yaml > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: Documentation/devicetree/bindings/phy/starfive,jh7110-dphy-rx.example.dts:18:18: fatal error: dt-bindings/clock/starfive,jh7110-crg.h: No such file or directory 18 | #include <dt-bindings/clock/starfive,jh7110-crg.h> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ compilation terminated. make[1]: *** [scripts/Makefile.lib:434: Documentation/devicetree/bindings/phy/starfive,jh7110-dphy-rx.example.dtb] Error 1 make[1]: *** Waiting for unfinished jobs.... make: *** [Makefile:1508: dt_binding_check] Error 2 doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230210061713.6449-3-changhuang.liang@starfivetech.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
On Thu, Feb 09, 2023 at 10:17:11PM -0800, Changhuang Liang wrote: > Starfive SoC like the jh7110 use a MIPI D-PHY RX controller based on > a M31 IP. Add a binding for it. > > Signed-off-by: Changhuang Liang <changhuang.liang@starfivetech.com> > --- > .../bindings/phy/starfive,jh7110-dphy-rx.yaml | 78 +++++++++++++++++++ > 1 file changed, 78 insertions(+) > create mode 100644 Documentation/devicetree/bindings/phy/starfive,jh7110-dphy-rx.yaml > > diff --git a/Documentation/devicetree/bindings/phy/starfive,jh7110-dphy-rx.yaml b/Documentation/devicetree/bindings/phy/starfive,jh7110-dphy-rx.yaml > new file mode 100644 > index 000000000000..1c1e5c7cbee2 > --- /dev/null > +++ b/Documentation/devicetree/bindings/phy/starfive,jh7110-dphy-rx.yaml > @@ -0,0 +1,78 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/phy/starfive,jh7110-dphy-rx.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Starfive SoC MIPI D-PHY Rx Controller > + > +maintainers: > + - Jack Zhu <jack.zhu@starfivetech.com> > + - Changhuang Liang <changhuang.liang@starfivetech.com> > + > +description: | Don't need '|' > + The Starfive SOC has a MIPI CSI D-PHY based on M31 IP use to transfer > + the CSI cameras data. > + > +properties: > + compatible: > + items: > + - const: "starfive,jh7110-dphy-rx" Drop quotes. > + > + reg: > + maxItems: 1 > + > + clocks: > + minItems: 3 > + maxItems: 3 Just maxItems is enough. > + > + clock-names: > + items: > + - const: cfg > + - const: ref > + - const: tx > + > + resets: > + minItems: 2 > + maxItems: 2 Need to define what each reset is. > + > + starfive,aon-syscon: > + $ref: '/schemas/types.yaml#/definitions/phandle-array' Drop quotes. > + items: > + items: > + - description: phandle of AON SYSCON > + - description: register offset > + description: The register of dphy rx driver can be configured > + by AON SYSCON in this property. > + > + "#phy-cells": > + const: 0 > + > +required: > + - compatible > + - reg > + - clocks > + - clock-names > + - resets > + - starfive,aon-syscon > + - "#phy-cells" > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/clock/starfive,jh7110-crg.h> > + #include <dt-bindings/reset/starfive,jh7110-crg.h> > + > + dphy@19820000 { > + compatible = "starfive,jh7110-dphy-rx"; > + reg = <0x19820000 0x10000>; > + clocks = <&ispcrg JH7110_ISPCLK_M31DPHY_CFGCLK_IN>, > + <&ispcrg JH7110_ISPCLK_M31DPHY_REFCLK_IN>, > + <&ispcrg JH7110_ISPCLK_M31DPHY_TXCLKESC_LAN0>; > + clock-names = "cfg", "ref", "tx"; > + resets = <&ispcrg JH7110_ISPRST_M31DPHY_HW>, > + <&ispcrg JH7110_ISPRST_M31DPHY_B09_ALWAYS_ON>; > + starfive,aon-syscon = <&aon_syscon 0x00>; > + #phy-cells = <0>; > + }; > -- > 2.25.1 >
On 2023/2/10 21:58, Rob Herring wrote: > > On Thu, 09 Feb 2023 22:17:11 -0800, Changhuang Liang wrote: >> Starfive SoC like the jh7110 use a MIPI D-PHY RX controller based on >> a M31 IP. Add a binding for it. >> >> Signed-off-by: Changhuang Liang <changhuang.liang@starfivetech.com> >> --- >> .../bindings/phy/starfive,jh7110-dphy-rx.yaml | 78 +++++++++++++++++++ >> 1 file changed, 78 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/phy/starfive,jh7110-dphy-rx.yaml >> > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > Documentation/devicetree/bindings/phy/starfive,jh7110-dphy-rx.example.dts:18:18: fatal error: dt-bindings/clock/starfive,jh7110-crg.h: No such file or directory > 18 | #include <dt-bindings/clock/starfive,jh7110-crg.h> > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > compilation terminated. > make[1]: *** [scripts/Makefile.lib:434: Documentation/devicetree/bindings/phy/starfive,jh7110-dphy-rx.example.dtb] Error 1 > make[1]: *** Waiting for unfinished jobs.... > make: *** [Makefile:1508: dt_binding_check] Error 2 > > doc reference errors (make refcheckdocs): > > See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230210061713.6449-3-changhuang.liang@starfivetech.com > > The base for the series is generally the latest rc1. A different dependency > should be noted in *this* patch. > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit after running the above command yourself. Note > that DT_SCHEMA_FILES can be set to your schema file to speed up checking > your schema. However, it must be unset to test all examples with your schema. > The file dt-bindings/clock/starfive,jh7110-crg.h doesn't merge in the mailline, i will delete a reference to this file and update clocks/resets macros to the real number in the starfive,dphy-rx.yaml.
On 2023/2/11 2:29, Rob Herring wrote: > On Thu, Feb 09, 2023 at 10:17:11PM -0800, Changhuang Liang wrote: >> Starfive SoC like the jh7110 use a MIPI D-PHY RX controller based on >> a M31 IP. Add a binding for it. >> >> Signed-off-by: Changhuang Liang <changhuang.liang@starfivetech.com> >> --- >> .../bindings/phy/starfive,jh7110-dphy-rx.yaml | 78 +++++++++++++++++++ >> 1 file changed, 78 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/phy/starfive,jh7110-dphy-rx.yaml >> >> diff --git a/Documentation/devicetree/bindings/phy/starfive,jh7110-dphy-rx.yaml b/Documentation/devicetree/bindings/phy/starfive,jh7110-dphy-rx.yaml >> new file mode 100644 >> index 000000000000..1c1e5c7cbee2 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/phy/starfive,jh7110-dphy-rx.yaml >> @@ -0,0 +1,78 @@ >> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/phy/starfive,jh7110-dphy-rx.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Starfive SoC MIPI D-PHY Rx Controller >> + >> +maintainers: >> + - Jack Zhu <jack.zhu@starfivetech.com> >> + - Changhuang Liang <changhuang.liang@starfivetech.com> >> + >> +description: | > > Don't need '|' > OK, will delete it. >> + The Starfive SOC has a MIPI CSI D-PHY based on M31 IP use to transfer >> + the CSI cameras data. >> + >> +properties: >> + compatible: >> + items: >> + - const: "starfive,jh7110-dphy-rx" > > Drop quotes. > OK, will drop quotes >> + >> + reg: >> + maxItems: 1 >> + >> + clocks: >> + minItems: 3 >> + maxItems: 3 > > Just maxItems is enough. > OK, will delete minItems. >> + >> + clock-names: >> + items: >> + - const: cfg >> + - const: ref >> + - const: tx >> + >> + resets: >> + minItems: 2 >> + maxItems: 2 > > Need to define what each reset is. > OK, will define resets. >> + >> + starfive,aon-syscon: >> + $ref: '/schemas/types.yaml#/definitions/phandle-array' > > Drop quotes. > OK, will drop quote >> + items: >> + items: >> + - description: phandle of AON SYSCON >> + - description: register offset >> + description: The register of dphy rx driver can be configured >> + by AON SYSCON in this property. >> + >> + "#phy-cells": >> + const: 0 >> + >> +required: >> + - compatible >> + - reg >> + - clocks >> + - clock-names >> + - resets >> + - starfive,aon-syscon >> + - "#phy-cells" >> + >> +additionalProperties: false >> + >> +examples: >> + - | >> + #include <dt-bindings/clock/starfive,jh7110-crg.h> >> + #include <dt-bindings/reset/starfive,jh7110-crg.h> >> + >> + dphy@19820000 { >> + compatible = "starfive,jh7110-dphy-rx"; >> + reg = <0x19820000 0x10000>; >> + clocks = <&ispcrg JH7110_ISPCLK_M31DPHY_CFGCLK_IN>, >> + <&ispcrg JH7110_ISPCLK_M31DPHY_REFCLK_IN>, >> + <&ispcrg JH7110_ISPCLK_M31DPHY_TXCLKESC_LAN0>; >> + clock-names = "cfg", "ref", "tx"; >> + resets = <&ispcrg JH7110_ISPRST_M31DPHY_HW>, >> + <&ispcrg JH7110_ISPRST_M31DPHY_B09_ALWAYS_ON>; >> + starfive,aon-syscon = <&aon_syscon 0x00>; >> + #phy-cells = <0>; >> + }; >> -- >> 2.25.1 >>
On 10/02/2023 07:17, Changhuang Liang wrote: > Starfive SoC like the jh7110 use a MIPI D-PHY RX controller based on > a M31 IP. Add a binding for it. > > Signed-off-by: Changhuang Liang <changhuang.liang@starfivetech.com> > --- > .../bindings/phy/starfive,jh7110-dphy-rx.yaml | 78 +++++++++++++++++++ > 1 file changed, 78 insertions(+) > create mode 100644 Documentation/devicetree/bindings/phy/starfive,jh7110-dphy-rx.yaml > > diff --git a/Documentation/devicetree/bindings/phy/starfive,jh7110-dphy-rx.yaml b/Documentation/devicetree/bindings/phy/starfive,jh7110-dphy-rx.yaml > new file mode 100644 > index 000000000000..1c1e5c7cbee2 > --- /dev/null > +++ b/Documentation/devicetree/bindings/phy/starfive,jh7110-dphy-rx.yaml > @@ -0,0 +1,78 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/phy/starfive,jh7110-dphy-rx.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Starfive SoC MIPI D-PHY Rx Controller > + > +maintainers: > + - Jack Zhu <jack.zhu@starfivetech.com> > + - Changhuang Liang <changhuang.liang@starfivetech.com> > + > +description: | > + The Starfive SOC has a MIPI CSI D-PHY based on M31 IP use to transfer > + the CSI cameras data. > + > +properties: > + compatible: > + items: Drop items > + - const: "starfive,jh7110-dphy-rx" Drop quotes > + > + reg: > + maxItems: 1 > + > + clocks: > + minItems: 3 Drop minItems > + maxItems: 3 > + > + clock-names: > + items: > + - const: cfg > + - const: ref > + - const: tx > + > + resets: > + minItems: 2 Ditto > + maxItems: 2 > + > + starfive,aon-syscon: > + $ref: '/schemas/types.yaml#/definitions/phandle-array' Drop quotes > + items: > + items: > + - description: phandle of AON SYSCON > + - description: register offset > + description: The register of dphy rx driver can be configured > + by AON SYSCON in this property. Can be? So does not have to? But you made it a required property.... > + > + "#phy-cells": > + const: 0 > + > +required: > + - compatible > + - reg > + - clocks > + - clock-names > + - resets > + - starfive,aon-syscon > + - "#phy-cells" > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/clock/starfive,jh7110-crg.h> > + #include <dt-bindings/reset/starfive,jh7110-crg.h> > + > + dphy@19820000 { just phy@...... > + compatible = "starfive,jh7110-dphy-rx"; > + reg = <0x19820000 0x10000>; > + clocks = <&ispcrg JH7110_ISPCLK_M31DPHY_CFGCLK_IN>, > + <&ispcrg JH7110_ISPCLK_M31DPHY_REFCLK_IN>, > + <&ispcrg JH7110_ISPCLK_M31DPHY_TXCLKESC_LAN0>; > + clock-names = "cfg", "ref", "tx"; > + resets = <&ispcrg JH7110_ISPRST_M31DPHY_HW>, > + <&ispcrg JH7110_ISPRST_M31DPHY_B09_ALWAYS_ON>; > + starfive,aon-syscon = <&aon_syscon 0x00>; > + #phy-cells = <0>; > + }; Best regards, Krzysztof
On 2023/2/13 17:30, Krzysztof Kozlowski wrote: > On 10/02/2023 07:17, Changhuang Liang wrote: >> Starfive SoC like the jh7110 use a MIPI D-PHY RX controller based on >> a M31 IP. Add a binding for it. >> >> Signed-off-by: Changhuang Liang <changhuang.liang@starfivetech.com> >> --- >> .../bindings/phy/starfive,jh7110-dphy-rx.yaml | 78 +++++++++++++++++++ >> 1 file changed, 78 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/phy/starfive,jh7110-dphy-rx.yaml >> >> diff --git a/Documentation/devicetree/bindings/phy/starfive,jh7110-dphy-rx.yaml b/Documentation/devicetree/bindings/phy/starfive,jh7110-dphy-rx.yaml >> new file mode 100644 >> index 000000000000..1c1e5c7cbee2 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/phy/starfive,jh7110-dphy-rx.yaml >> @@ -0,0 +1,78 @@ >> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/phy/starfive,jh7110-dphy-rx.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Starfive SoC MIPI D-PHY Rx Controller >> + >> +maintainers: >> + - Jack Zhu <jack.zhu@starfivetech.com> >> + - Changhuang Liang <changhuang.liang@starfivetech.com> >> + >> +description: | >> + The Starfive SOC has a MIPI CSI D-PHY based on M31 IP use to transfer >> + the CSI cameras data. >> + >> +properties: >> + compatible: >> + items: > > Drop items > OK, will fix it >> + - const: "starfive,jh7110-dphy-rx" > > Drop quotes > OK, will drop quotes >> + >> + reg: >> + maxItems: 1 >> + >> + clocks: >> + minItems: 3 > > Drop minItems > OK, will drop minItems >> + maxItems: 3 >> + >> + clock-names: >> + items: >> + - const: cfg >> + - const: ref >> + - const: tx >> + >> + resets: >> + minItems: 2 > > Ditto > here i will change to define each reset is. Refer to the Rob Herring's comment. >> + maxItems: 2 >> + >> + starfive,aon-syscon: >> + $ref: '/schemas/types.yaml#/definitions/phandle-array' > > Drop quotes > OK, will drop quotes >> + items: >> + items: >> + - description: phandle of AON SYSCON >> + - description: register offset >> + description: The register of dphy rx driver can be configured >> + by AON SYSCON in this property. > > Can be? So does not have to? But you made it a required property.... > Maybe I described it wrong. I will change to: description: The power of dphy rx can be configured by AON SYSCON in this property. It is like AON SYSCON is the power switch of the dphy rx, it is necessary to configure the AON SYSCON register, so I made it a required property. >> + >> + "#phy-cells": >> + const: 0 >> + >> +required: >> + - compatible >> + - reg >> + - clocks >> + - clock-names >> + - resets >> + - starfive,aon-syscon >> + - "#phy-cells" >> + >> +additionalProperties: false >> + >> +examples: >> + - | >> + #include <dt-bindings/clock/starfive,jh7110-crg.h> >> + #include <dt-bindings/reset/starfive,jh7110-crg.h> >> + >> + dphy@19820000 { > > just phy@...... > OK, will fix it. >> + compatible = "starfive,jh7110-dphy-rx"; >> + reg = <0x19820000 0x10000>; >> + clocks = <&ispcrg JH7110_ISPCLK_M31DPHY_CFGCLK_IN>, >> + <&ispcrg JH7110_ISPCLK_M31DPHY_REFCLK_IN>, >> + <&ispcrg JH7110_ISPCLK_M31DPHY_TXCLKESC_LAN0>; >> + clock-names = "cfg", "ref", "tx"; >> + resets = <&ispcrg JH7110_ISPRST_M31DPHY_HW>, >> + <&ispcrg JH7110_ISPRST_M31DPHY_B09_ALWAYS_ON>; >> + starfive,aon-syscon = <&aon_syscon 0x00>; >> + #phy-cells = <0>; >> + }; > > Best regards, > Krzysztof >
On 14/02/2023 04:07, Changhuang Liang wrote: > > OK, will drop quotes > >>> + items: >>> + items: >>> + - description: phandle of AON SYSCON >>> + - description: register offset >>> + description: The register of dphy rx driver can be configured >>> + by AON SYSCON in this property. >> >> Can be? So does not have to? But you made it a required property.... >> > > Maybe I described it wrong. > I will change to: > description: The power of dphy rx can be configured by AON SYSCON > in this property. > It is like AON SYSCON is the power switch of the dphy rx, it is necessary to > configure the AON SYSCON register, so I made it a required property. Then do not use "can be". Can is optional: I can jump but I don't have to. :) Best regards, Krzysztof
On 2023/2/14 15:49, Krzysztof Kozlowski wrote: > On 14/02/2023 04:07, Changhuang Liang wrote: >> >> OK, will drop quotes >> >>>> + items: >>>> + items: >>>> + - description: phandle of AON SYSCON >>>> + - description: register offset >>>> + description: The register of dphy rx driver can be configured >>>> + by AON SYSCON in this property. >>> >>> Can be? So does not have to? But you made it a required property.... >>> >> >> Maybe I described it wrong. >> I will change to: >> description: The power of dphy rx can be configured by AON SYSCON >> in this property. >> It is like AON SYSCON is the power switch of the dphy rx, it is necessary to >> configure the AON SYSCON register, so I made it a required property. > > Then do not use "can be". Can is optional: I can jump but I don't have > to. :) > OK, "can be" will be changed to "is". Best Regards, Changhuang Liang
diff --git a/Documentation/devicetree/bindings/phy/starfive,jh7110-dphy-rx.yaml b/Documentation/devicetree/bindings/phy/starfive,jh7110-dphy-rx.yaml new file mode 100644 index 000000000000..1c1e5c7cbee2 --- /dev/null +++ b/Documentation/devicetree/bindings/phy/starfive,jh7110-dphy-rx.yaml @@ -0,0 +1,78 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/phy/starfive,jh7110-dphy-rx.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Starfive SoC MIPI D-PHY Rx Controller + +maintainers: + - Jack Zhu <jack.zhu@starfivetech.com> + - Changhuang Liang <changhuang.liang@starfivetech.com> + +description: | + The Starfive SOC has a MIPI CSI D-PHY based on M31 IP use to transfer + the CSI cameras data. + +properties: + compatible: + items: + - const: "starfive,jh7110-dphy-rx" + + reg: + maxItems: 1 + + clocks: + minItems: 3 + maxItems: 3 + + clock-names: + items: + - const: cfg + - const: ref + - const: tx + + resets: + minItems: 2 + maxItems: 2 + + starfive,aon-syscon: + $ref: '/schemas/types.yaml#/definitions/phandle-array' + items: + items: + - description: phandle of AON SYSCON + - description: register offset + description: The register of dphy rx driver can be configured + by AON SYSCON in this property. + + "#phy-cells": + const: 0 + +required: + - compatible + - reg + - clocks + - clock-names + - resets + - starfive,aon-syscon + - "#phy-cells" + +additionalProperties: false + +examples: + - | + #include <dt-bindings/clock/starfive,jh7110-crg.h> + #include <dt-bindings/reset/starfive,jh7110-crg.h> + + dphy@19820000 { + compatible = "starfive,jh7110-dphy-rx"; + reg = <0x19820000 0x10000>; + clocks = <&ispcrg JH7110_ISPCLK_M31DPHY_CFGCLK_IN>, + <&ispcrg JH7110_ISPCLK_M31DPHY_REFCLK_IN>, + <&ispcrg JH7110_ISPCLK_M31DPHY_TXCLKESC_LAN0>; + clock-names = "cfg", "ref", "tx"; + resets = <&ispcrg JH7110_ISPRST_M31DPHY_HW>, + <&ispcrg JH7110_ISPRST_M31DPHY_B09_ALWAYS_ON>; + starfive,aon-syscon = <&aon_syscon 0x00>; + #phy-cells = <0>; + };
Starfive SoC like the jh7110 use a MIPI D-PHY RX controller based on a M31 IP. Add a binding for it. Signed-off-by: Changhuang Liang <changhuang.liang@starfivetech.com> --- .../bindings/phy/starfive,jh7110-dphy-rx.yaml | 78 +++++++++++++++++++ 1 file changed, 78 insertions(+) create mode 100644 Documentation/devicetree/bindings/phy/starfive,jh7110-dphy-rx.yaml