From patchwork Tue Mar 7 11:58:39 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13163297 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 78ECAC6FD1E for ; Tue, 7 Mar 2023 11:59:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0plcb0vH3s3r1hu25JVTZjQg1OQvRkwKXM4zk62IB+k=; b=fFAz34jf6cMUxE 2uuSqPt9HNwL0koX0c+OIVVEUC7eXaJpPXdQYbEauD6si5WoeAJBPZAvurEzJ8Ymd/+c7bJXGtTKP aR4nnqSKP/HGmyDfdYe0MOpZ5fEO898XpCfwaEfaK3JqM+AdKZ/G1yCkGWlfIK1kz/ZDdBzGERio1 brVkb1CZjzig+orQoaRl3TuRXf6tFkGA6VsV1cRhCimMR60U2WgWecLHrrO6TU1biBAgfy+ACzjdz WRId7afxvCw/bOvHyIrJhim/6+zg7ckzs5b/wVEFPRVQ9FtyeLEnLJCHlqzqw0IEEiIld5zbEbdXG qH7ej/taWkJ5ETnrNgvg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pZVyl-00HZEp-NB; Tue, 07 Mar 2023 11:59:39 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pZVyU-00HZ0O-7w for linux-phy@lists.infradead.org; Tue, 07 Mar 2023 11:59:25 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pZVyH-0006TT-L1; Tue, 07 Mar 2023 12:59:09 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pZVyG-002TEw-Tj; Tue, 07 Mar 2023 12:59:08 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pZVyG-002yjF-1B; Tue, 07 Mar 2023 12:59:08 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Vinod Koul , Kishon Vijay Abraham I , Miaoqian Lin Cc: linux-phy@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH 10/31] phy: motorola: phy-mapphone-mdm6600: Convert to platform remove callback returning void Date: Tue, 7 Mar 2023 12:58:39 +0100 Message-Id: <20230307115900.2293120-11-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230307115900.2293120-1-u.kleine-koenig@pengutronix.de> References: <20230307115900.2293120-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1867; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=LlWCp/mrIzedCIyAGn9JbyooR4/Hi4KhcD8fvdOJsDg=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBkByaniSwgAhH0kwu8QxQtWRM6Y2iAfAS0dBhDj 6Sq6LKM95WJATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCZAcmpwAKCRDB/BR4rcrs CeffB/46mrzSpO/5JJWwfJfLxSPbtQKbxREE0ANI3idY/2mJ2020lAdSRP3/66OofLqz9tyEHCv /Z+j+GYLiTZ0lpgZD30qIq6ZdlsIoFwUW7/QW9jXkQ8N5xFYzJ5AOtsS0JGg0wt8PVTahm2DtJR xxijOF93lrLv9IRzytFJWSqgfyDFHAT3IZ6fh1PUq1tzlow0TGNFSrcmqiDNKJ8AUaNY9ZzLKW9 HglYnve1Now8fhy/zDI+QWZ7NW+Usg5/CWQVBioL09oGvGE8ppPVG53NKs2JfbWGv0GjZu36GH1 /F6KD9XxosnOVU6K6FU3AAf7d9+VCcd0xVQteTsCY0On5WID X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-phy@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230307_035922_333357_2859D916 X-CRM114-Status: GOOD ( 15.59 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/phy/motorola/phy-mapphone-mdm6600.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/phy/motorola/phy-mapphone-mdm6600.c b/drivers/phy/motorola/phy-mapphone-mdm6600.c index 3cd4d51c247c..1d567604b650 100644 --- a/drivers/phy/motorola/phy-mapphone-mdm6600.c +++ b/drivers/phy/motorola/phy-mapphone-mdm6600.c @@ -634,7 +634,7 @@ static int phy_mdm6600_probe(struct platform_device *pdev) return error; } -static int phy_mdm6600_remove(struct platform_device *pdev) +static void phy_mdm6600_remove(struct platform_device *pdev) { struct phy_mdm6600 *ddata = platform_get_drvdata(pdev); struct gpio_desc *reset_gpio = ddata->ctrl_gpios[PHY_MDM6600_RESET]; @@ -653,13 +653,11 @@ static int phy_mdm6600_remove(struct platform_device *pdev) cancel_delayed_work_sync(&ddata->modem_wake_work); cancel_delayed_work_sync(&ddata->bootup_work); cancel_delayed_work_sync(&ddata->status_work); - - return 0; } static struct platform_driver phy_mdm6600_driver = { .probe = phy_mdm6600_probe, - .remove = phy_mdm6600_remove, + .remove_new = phy_mdm6600_remove, .driver = { .name = "phy-mapphone-mdm6600", .pm = &phy_mdm6600_pm_ops,