From patchwork Tue Mar 7 11:58:42 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13163316 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1692FC678D5 for ; Tue, 7 Mar 2023 12:01:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Kg3HtY7wfcuQovkLasXf1y8KPToARrC+AGd8uv4N3ro=; b=d3Yqyy4WlAgGaL KBq+VEX1VtEMdmRmGn5tUpL+vhJfSXCLZlakX4sehR17kVkw5XJG00ztPoIUHK4GQ2llvyby94eT1 oL7PMVUZP8L9ozBbup2IbF9wuXrcS+mNBagISaf856dXauqn0M2JkT/MLxGXce6lkzvxx+8CaHZqF iNbKcNMH93d+1JXPCdYbJFrx7JL5nshooNNBOCQsnjisRPCjMaxDfBvDC+qVWAzMt/88426WYJ6ob RSEe/kyXC1fbftLAoX3ilW63a8HAdHKuDOnkeEaabqUeKbfH8QwHox5bbA7Fo2Xg5z00Iwvbn575B Ah/3V/TJERIA2ibcZSCA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pZW0F-00HaB8-HI; Tue, 07 Mar 2023 12:01:11 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pZVyl-00HZDp-0y for linux-phy@bombadil.infradead.org; Tue, 07 Mar 2023 11:59:39 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:Content-Type :MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Sender:Reply-To:Content-ID:Content-Description; bh=Sn+c8MXjyXCMTILhZQz1+wu5vaaXW1ZNuoSv4mCczkA=; b=prdJbMhV8NI8YfZF3t2qRrVlC9 oEf651RqzfiUXq3ni5cDBimfT7v6SzbylDyo2cRIqdLeGKYM5brldVzEk7cka5gw1cLja8yBGthuc VTyno4rG2b+Co5QowQHLdhdy/RB1L70rGrnOOO60KiSr3Ctw4RevnroodIHAyvgjBUJBgfTNt3mNw 56VL0dzan/ZmsqSsvUDu7JjSJZPZSEedT6dnl0Y+K66y8d9ixTQ55006rNiUmNVf7saHl+G54USDP 17JzPRXXbQQ5LzpvvxREhS5eZcpOhqRJzMPAklf+aMKPAVWCFt++fkg+QBN5YHUVvFE48t3z1vDA+ 18N0/0PA==; Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by desiato.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pZVyb-00H2AH-2h for linux-phy@lists.infradead.org; Tue, 07 Mar 2023 11:59:37 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pZVyJ-0006Vc-Bi; Tue, 07 Mar 2023 12:59:11 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pZVyI-002TFH-7W; Tue, 07 Mar 2023 12:59:10 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pZVyG-002yjO-LN; Tue, 07 Mar 2023 12:59:08 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Andy Gross , Bjorn Andersson , Vinod Koul , Kishon Vijay Abraham I Cc: Konrad Dybcio , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH 13/31] phy: qualcomm: phy-qcom-eusb2-repeater: Convert to platform remove callback returning void Date: Tue, 7 Mar 2023 12:58:42 +0100 Message-Id: <20230307115900.2293120-14-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230307115900.2293120-1-u.kleine-koenig@pengutronix.de> References: <20230307115900.2293120-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1851; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=coYW9pWrr7E2/EphPOTo9VhmqHcN1CT2RwChjTdikrY=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBkBya24P5M0wKf7HSaNgxHarPDhCEn3rBAMUmPT HuoVQ/KPWiJATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCZAcmtgAKCRDB/BR4rcrs CfqICACGmDiagBmsuLHmNtEd4ad06qzHj4o/GbYfYOn00Bxoyf0J46p/r7LKnPoGpQTUtjDvNpP LgOuE2v8R+64XG0jmMzVC5dk8GCWhKAx+G2zAoQjFbKo1CUHUeHUg1Y4s7StDUi/adbvIjnIvFh k73krBXEzl6x16MlotR7CniAUyd1UJdXzgkHJJFAEWOlMqS6LqUioALpS7VtSfATf8pB/cWBhni unti+HYKLDkce3IZsicO5YS5cRZmkZI6PBiC1HuI1w2bNeVZJrwA8VHxlQ74mUI+WvSXjBnzND0 SXAAXFMCs8CT8sz0ybxi21TJGowqwSz1MHaSAP+mAIQm8Zhl X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-phy@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230307_115931_833781_53C9ECC6 X-CRM114-Status: GOOD ( 16.29 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/phy/qualcomm/phy-qcom-eusb2-repeater.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/phy/qualcomm/phy-qcom-eusb2-repeater.c b/drivers/phy/qualcomm/phy-qcom-eusb2-repeater.c index 3f265ac2df20..90f8543ba265 100644 --- a/drivers/phy/qualcomm/phy-qcom-eusb2-repeater.c +++ b/drivers/phy/qualcomm/phy-qcom-eusb2-repeater.c @@ -223,16 +223,14 @@ static int eusb2_repeater_probe(struct platform_device *pdev) return 0; } -static int eusb2_repeater_remove(struct platform_device *pdev) +static void eusb2_repeater_remove(struct platform_device *pdev) { struct eusb2_repeater *rptr = platform_get_drvdata(pdev); if (!rptr) - return 0; + return; eusb2_repeater_exit(rptr->phy); - - return 0; } static const struct of_device_id eusb2_repeater_of_match_table[] = { @@ -246,7 +244,7 @@ MODULE_DEVICE_TABLE(of, eusb2_repeater_of_match_table); static struct platform_driver eusb2_repeater_driver = { .probe = eusb2_repeater_probe, - .remove = eusb2_repeater_remove, + .remove_new = eusb2_repeater_remove, .driver = { .name = "qcom-eusb2-repeater", .of_match_table = eusb2_repeater_of_match_table,