From patchwork Tue Mar 7 11:58:30 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13163315 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D4AD8C6FA99 for ; Tue, 7 Mar 2023 12:00:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2luGPtmf6uDUjF7E4ya6Jwsa+J003KWBGzaVzwbPVI8=; b=T2mAo5yn3yYNqc Ziz0E4N9XYd3d7ap2GuRDyw+NgtUtWCm4H9sA849drDR89d+h40u1CdYYMRM8lK8ko2agXc9VbgWS Zewvy7JDSApUaMA10CR6UTR3we8L6nlnDDXxMCnaXGwaruJP+YzgMJuKKPe3A1fRs9RZNLbnaSvYQ r8VFCjcMYJtL7QDMBHB7/MFPFtjEEsOFsKhnTBey/tVmSiScBEZDpx8i9heQ5FyEQmae/RmMC8t2c vBPIDcnO9/hH8A1p1DoHEZ7lbP0cmoVi8vbYQA4VPVoGXVucLf4aW6IEdW5Cu7WKPeaALP5r6YGj8 9/3Yhh1vEdWzU1blNaIg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pZVzw-00HZzE-9Q; Tue, 07 Mar 2023 12:00:52 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pZVyj-00HZD8-DZ for linux-phy@bombadil.infradead.org; Tue, 07 Mar 2023 11:59:37 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:Content-Type :MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Sender:Reply-To:Content-ID:Content-Description; bh=Xn2FWRD6rtMGAg/F68bObA8/ElnGWU23kOhgdyhavDw=; b=PpSeTMM1Ux8yLOt3fA7MWhghnO iGYVZWDUL78kI04ZIWbIp8V3Reh83o0CiMRLridZ5TwMC1+3lZDsvthROLsHxyMHpsdBlfyvCdaRU PxoW9nyjp+GzDT7OhU5DgHkfXON5nSuDEbx9SpxUM96gmrZSjraXPX4pKSmb1A6BXOyF9SB85ay7G Tx/GwxOKzUnufdpvRAR8M/CVFrw93S+wOCrveQCk4mspQKKLCBHAcvHt99EifiIFIVgRNNbI8qjW7 4/yeV4Ip2st2imnmJ1ahBfAvk8ai8dOV9FPKToKXJZel3GbXAJzOjqZ+hleXMXXHskySOFJidpMnS VfLkDacQ==; Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by desiato.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pZVyb-00H2AG-2g for linux-phy@lists.infradead.org; Tue, 07 Mar 2023 11:59:36 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pZVyI-0006T5-3W; Tue, 07 Mar 2023 12:59:10 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pZVyE-002TES-Vg; Tue, 07 Mar 2023 12:59:06 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pZVyE-002yij-Bb; Tue, 07 Mar 2023 12:59:06 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Vinod Koul , Kishon Vijay Abraham I , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Andre Przywara , Wolfram Sang , Icenowy Zheng Cc: linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, kernel@pengutronix.de Subject: [PATCH 01/31] phy: allwinner: phy-sun4i-usb: Convert to platform remove callback returning void Date: Tue, 7 Mar 2023 12:58:30 +0100 Message-Id: <20230307115900.2293120-2-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230307115900.2293120-1-u.kleine-koenig@pengutronix.de> References: <20230307115900.2293120-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1919; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=A5l2lPoT4HwDDiKEGOetfLehy9xFEfoPwry6wSlMEIE=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBkByZ+ndr34KC6+DU92fWTYCRBx4D/esBgsXBP8 fUFnd0kDF2JATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCZAcmfgAKCRDB/BR4rcrs Cd8FB/4sVyrd21Uvk3d9LFOA2z189btbrMjnjrgUaePBHfcLUhL4vOXbmh+Hm3zHVUXOPC5m4yd jvMxSaA2GokI/ztFBvHqe/3g6A2f4MsZktdk/T8OdYbnkm9b2aCeRmGKATFJcwTDz0DtWugU1QY RUxpwCRvXpBDxH+tkajVez4tK+ohcLarFEnQu+PjVZEvdOUobkPjgLxPuL1CwBnKj3xK04xpngu zBe6pG6tGfclP6hDb9j02r40kb6Ozk9jpCMz41gW0r7WP6mtBxGsPRVPnIaBNUdH+grYMZoTvoo WrVr7zHRDhP96xKjTwk/3OMViaZHUio00HXlgMtvddUi756R X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-phy@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230307_115931_666127_6C2F131F X-CRM114-Status: GOOD ( 17.06 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König Acked-by: Jernej Skrabec --- drivers/phy/allwinner/phy-sun4i-usb.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/phy/allwinner/phy-sun4i-usb.c b/drivers/phy/allwinner/phy-sun4i-usb.c index fbcd7014ab43..6a74e5ce180a 100644 --- a/drivers/phy/allwinner/phy-sun4i-usb.c +++ b/drivers/phy/allwinner/phy-sun4i-usb.c @@ -698,7 +698,7 @@ static struct phy *sun4i_usb_phy_xlate(struct device *dev, return data->phys[args->args[0]].phy; } -static int sun4i_usb_phy_remove(struct platform_device *pdev) +static void sun4i_usb_phy_remove(struct platform_device *pdev) { struct device *dev = &pdev->dev; struct sun4i_usb_phy_data *data = dev_get_drvdata(dev); @@ -711,8 +711,6 @@ static int sun4i_usb_phy_remove(struct platform_device *pdev) devm_free_irq(dev, data->vbus_det_irq, data); cancel_delayed_work_sync(&data->detect); - - return 0; } static const unsigned int sun4i_usb_phy0_cable[] = { @@ -1054,7 +1052,7 @@ MODULE_DEVICE_TABLE(of, sun4i_usb_phy_of_match); static struct platform_driver sun4i_usb_phy_driver = { .probe = sun4i_usb_phy_probe, - .remove = sun4i_usb_phy_remove, + .remove_new = sun4i_usb_phy_remove, .driver = { .of_match_table = sun4i_usb_phy_of_match, .name = "sun4i-usb-phy",