From patchwork Tue Mar 7 11:58:53 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13163306 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DF15CC678D4 for ; Tue, 7 Mar 2023 12:00:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=rDYxse1+obDgDpTCdE2V3/QUfh+uUwFtU03Y0+L9YG8=; b=bJLPL63ApTDeJp x+HocYHB/A4D0DCz7mlS4idz5iEtA5b6xmNqUOibEBucFuvspOfz9h3pHl5PqFQoRUv9vQk1euSYw kJ93ZTftLtzJB4Kwig8faCRzI0cyjFTQ5gxR5p9s18ik5funNqRf0Kx67xC0cr36q367C+QdaUypf suNh5pZvxqw0c05+0ec4594weVl18l+uuDXz8idcsqENPn6XpHkma3rd8cIyyy4AvI/QvVWR+89s0 NmWvIgc7vF13WtXf+K8AtAlGMXejgpvIhIeXegx1rnb6dT2VJ68wwhl8vq49U/fr/bxo0MsUk1EoN 6/TNrP/172ZNnDBDleMw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pZVz8-00HZRm-Bd; Tue, 07 Mar 2023 12:00:02 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pZVyY-00HZ5w-OD for linux-phy@lists.infradead.org; Tue, 07 Mar 2023 11:59:29 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pZVyL-0006bk-F0; Tue, 07 Mar 2023 12:59:13 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pZVyK-002TGM-Cw; Tue, 07 Mar 2023 12:59:12 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pZVyJ-002yk8-11; Tue, 07 Mar 2023 12:59:11 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: JC Kuo , Vinod Koul , Kishon Vijay Abraham I , Thierry Reding , Jonathan Hunter Cc: linux-phy@lists.infradead.org, linux-tegra@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH 24/31] phy: tegra: xusb: Convert to platform remove callback returning void Date: Tue, 7 Mar 2023 12:58:53 +0100 Message-Id: <20230307115900.2293120-25-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230307115900.2293120-1-u.kleine-koenig@pengutronix.de> References: <20230307115900.2293120-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1837; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=E3uo38jywnktvSNvAGRANsI8kEJhkfQ9Ly00U4vBCFY=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBkBybhMO4YTx5uCCpzSiO56pIYF4a85pRbL/tYG WkTAGgRW+CJATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCZAcm4QAKCRDB/BR4rcrs CRSdB/94UtxtudX+pBQ3YkBMzxE5Ip8dBJfer2GWIFb6V8yJcGdVWaKYm43IuF+0Es5Bp6vg0Ig yxI7dfHdogkmACUNUfKWQLZp4it5ry39d8DjtA2nNjO7rDkGQXvymmzNisOayVmB/UpOuage/Am CBiREKl3y1lnrlUcWN+NdSZ2kJTEiIha6HN3fgSOgmG2on75mWlnyG+DXgs/ew551npdRwlUdqA 7GmfSJcy01zov8C2JQZe3aK4+fVT7S++FCUesI+rMGAY/w4GoMf0G9lowbOSD/ztvk5vaNwNeDo GM+Ghpj2OzBHVyP+1q1OfZJJMlLKWfolKyWEeD7plyA56FSB X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-phy@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230307_035926_844385_3666D739 X-CRM114-Status: GOOD ( 15.01 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/phy/tegra/xusb.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/phy/tegra/xusb.c b/drivers/phy/tegra/xusb.c index 78045bd6c214..ec335668563d 100644 --- a/drivers/phy/tegra/xusb.c +++ b/drivers/phy/tegra/xusb.c @@ -1267,7 +1267,7 @@ static int tegra_xusb_padctl_probe(struct platform_device *pdev) return err; } -static int tegra_xusb_padctl_remove(struct platform_device *pdev) +static void tegra_xusb_padctl_remove(struct platform_device *pdev) { struct tegra_xusb_padctl *padctl = platform_get_drvdata(pdev); int err; @@ -1285,8 +1285,6 @@ static int tegra_xusb_padctl_remove(struct platform_device *pdev) dev_err(&pdev->dev, "failed to assert reset: %d\n", err); padctl->soc->ops->remove(padctl); - - return 0; } static __maybe_unused int tegra_xusb_padctl_suspend_noirq(struct device *dev) @@ -1321,7 +1319,7 @@ static struct platform_driver tegra_xusb_padctl_driver = { .pm = &tegra_xusb_padctl_pm_ops, }, .probe = tegra_xusb_padctl_probe, - .remove = tegra_xusb_padctl_remove, + .remove_new = tegra_xusb_padctl_remove, }; module_platform_driver(tegra_xusb_padctl_driver);