From patchwork Tue Mar 7 11:58:59 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13163298 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 343DDC678D4 for ; Tue, 7 Mar 2023 11:59:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Xo0Hm3RtvMcZ6jdM6Y063XQ1vschXwXJpniOmNIbPdk=; b=csfbXTO8QdNqOQ JDPnKQvBvws6E4g4PhAVOQxxy91KjMvS4AeMRwJ5uu/Nb30x+e2BhALhbAIBxeLwG1mvw+zy6v98G x80pj4kAnrNDyI4znUAh2+nvXr24Y9MgdEa47C8XcCBDbXsTrhQkuH26pr3uCfGyEFLd90Z3zHZAA vwp6upinB4S83OfLDbwIyvygSoIAKiP9HNzfcQus1b7KNeb9iOqb0xyzocyzGp7i8V1KO5RLWVkS5 oyUT88ctW6S6TwL/mgckqRIVeKu9ZlJd9IT7uTke+Yr7rNbEMLCdq7ls4UMHJwfxd/YyLSfEopM8D 8EOCJOwowzPO3saM6KTA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pZVyl-00HZEK-BL; Tue, 07 Mar 2023 11:59:39 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pZVyU-00HZ0W-1X for linux-phy@lists.infradead.org; Tue, 07 Mar 2023 11:59:25 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pZVyN-0006g5-GZ; Tue, 07 Mar 2023 12:59:15 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pZVyL-002TGm-1Y; Tue, 07 Mar 2023 12:59:13 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pZVyK-002ykX-8B; Tue, 07 Mar 2023 12:59:12 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Vinod Koul , Kishon Vijay Abraham I , Lv Ruyi Cc: linux-phy@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH 30/31] phy: ti: phy-ti-pipe3: Convert to platform remove callback returning void Date: Tue, 7 Mar 2023 12:58:59 +0100 Message-Id: <20230307115900.2293120-31-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230307115900.2293120-1-u.kleine-koenig@pengutronix.de> References: <20230307115900.2293120-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1772; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=wgMZPGUgw8h17S+52a9JdTMDYMZqnuWu4i4fHW8hpDo=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBkByb5wImGA2u4Kdye+5pE2RO89nR8WLiKNsSdl hGQO3lBN+aJATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCZAcm+QAKCRDB/BR4rcrs CcILCACW+Yd1Uo1sIG2LKdlCQ77E/x88IcHgDR9kjXujT6iSjK9RkJ3HHbv4COexLCaKrNug96+ g5dZF2yfwOrqDCstCUht3VOyfmaWjMSLc5zjjv/yC2mLouH7ir+xitVVanXV9ubUjjn8j+29oo7 IeHL4kHMWzFrbPZZIXPVRn1rWhLPoKqvcXXOFNrdHmwfrf4A4czPW5pnApx/WhBFXZI98W3vxcU l+NcCOZbY1hLC+zz05nE5TJ2AplXCFMzEiOPJTVKmcTx5UUlj/LPooaht7nmo/Cd5dKY10dMkPN wqxT8zbMEvAD8EV9CloCG90NbC1nL4XV+HsV0ggNAMBGB7Yy X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-phy@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230307_035922_157027_2502EC80 X-CRM114-Status: GOOD ( 15.54 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/phy/ti/phy-ti-pipe3.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/phy/ti/phy-ti-pipe3.c b/drivers/phy/ti/phy-ti-pipe3.c index f502c36f3be5..507e1552db5e 100644 --- a/drivers/phy/ti/phy-ti-pipe3.c +++ b/drivers/phy/ti/phy-ti-pipe3.c @@ -841,7 +841,7 @@ static int ti_pipe3_probe(struct platform_device *pdev) return PTR_ERR_OR_ZERO(phy_provider); } -static int ti_pipe3_remove(struct platform_device *pdev) +static void ti_pipe3_remove(struct platform_device *pdev) { struct ti_pipe3 *phy = platform_get_drvdata(pdev); @@ -850,8 +850,6 @@ static int ti_pipe3_remove(struct platform_device *pdev) phy->sata_refclk_enabled = false; } pm_runtime_disable(&pdev->dev); - - return 0; } static int ti_pipe3_enable_clocks(struct ti_pipe3 *phy) @@ -928,7 +926,7 @@ MODULE_DEVICE_TABLE(of, ti_pipe3_id_table); static struct platform_driver ti_pipe3_driver = { .probe = ti_pipe3_probe, - .remove = ti_pipe3_remove, + .remove_new = ti_pipe3_remove, .driver = { .name = "ti-pipe3", .of_match_table = ti_pipe3_id_table,