From patchwork Tue Mar 7 11:58:32 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13163294 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A5809C678D5 for ; Tue, 7 Mar 2023 11:59:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=L8ailSE94+ZM2FQ2VsEpVmMTHn5pG34aMXET1+sCXqE=; b=0NAB8761ehEQGO Mn6zOe8WhgJTQvw0F2Y1p75BnYr5DPNTzT5M80E/l8E4tfZi9SeXQSMbfQRrY9KnRp2MOxF013aGE YhfgLV1kTCr3l2/AfDCud56c6YI9LtienTbl1TvB9cX+gkVvFPISeevn9ELDCmgNf9Q5KGi3I+l/O I1+YW/UtuV3H8uC3ItXR1W/502DLzfnnx6exPHFMjj9CJTE1Fz6WjAIH1uLd41eiuILQm6cRtxKFr 9NyW2Hq90igBbSFvG++7IiHrKJ0g4qH6OeYvNa8Hev1pgOLE1RmqEWi/Q6VNeMq89fzFuSxxiUcVv HR3Z4Dc6wh4ohM4Khvng==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pZVyl-00HZE6-3R; Tue, 07 Mar 2023 11:59:39 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pZVyT-00HZ08-TE for linux-phy@lists.infradead.org; Tue, 07 Mar 2023 11:59:23 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pZVyG-0006T8-JN; Tue, 07 Mar 2023 12:59:08 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pZVyF-002TEf-MC; Tue, 07 Mar 2023 12:59:07 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pZVyE-002yip-Ov; Tue, 07 Mar 2023 12:59:06 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Vinod Koul , Kishon Vijay Abraham I , Pratyush Yadav , Rahul T R Cc: linux-phy@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH 03/31] phy: cadence: cdns-dphy: Convert to platform remove callback returning void Date: Tue, 7 Mar 2023 12:58:32 +0100 Message-Id: <20230307115900.2293120-4-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230307115900.2293120-1-u.kleine-koenig@pengutronix.de> References: <20230307115900.2293120-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1713; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=w2w5giaK7bwvJRoPlNMu5LvcGIcgJWo9wnyDOxq3IM8=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBkByaHAsMeoi8Nnpmb8NHkJotjflnd1UhnjWMU/ /U6HtJzkRKJATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCZAcmhwAKCRDB/BR4rcrs Cb1MCACH3q4K5GY5Q20eJh6vxUthniaS7L/KjzI+Pkymd7L3mSnpB9NGSeigcVp8sZKj02Dq4WZ cGp9HJE/ovyxSj7eBMTpTUCUmmTjUInO1ajlabDNOrCM5DRCrLP7ZEtq/SBXPyoiqomHBrR52O8 XShmwWr/nl+G/wdNLIKnmQlPLRdPB+7PKSJ2uIUcuAUOGV82gMghqbCNNlk9t+L54MciYS4j0TN o97Icm4u5VN+qxS/S+MRL6cTLy/x8Fzzhr18kcPRsOjhZHeDulvv+4fbITmZshAw9IJzYKQZjRJ X7yvPnCBr86ARfBf8iQ9vS5eFgTHi/6F2P1WH1LEMAOn9DbA X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-phy@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230307_035921_960743_6C56BEB6 X-CRM114-Status: GOOD ( 15.97 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/phy/cadence/cdns-dphy.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/phy/cadence/cdns-dphy.c b/drivers/phy/cadence/cdns-dphy.c index 3dfdfb33cd0a..6e58012b6488 100644 --- a/drivers/phy/cadence/cdns-dphy.c +++ b/drivers/phy/cadence/cdns-dphy.c @@ -456,14 +456,12 @@ static int cdns_dphy_probe(struct platform_device *pdev) return PTR_ERR_OR_ZERO(phy_provider); } -static int cdns_dphy_remove(struct platform_device *pdev) +static void cdns_dphy_remove(struct platform_device *pdev) { struct cdns_dphy *dphy = dev_get_drvdata(&pdev->dev); if (dphy->ops->remove) dphy->ops->remove(dphy); - - return 0; } static const struct of_device_id cdns_dphy_of_match[] = { @@ -475,7 +473,7 @@ MODULE_DEVICE_TABLE(of, cdns_dphy_of_match); static struct platform_driver cdns_dphy_platform_driver = { .probe = cdns_dphy_probe, - .remove = cdns_dphy_remove, + .remove_new = cdns_dphy_remove, .driver = { .name = "cdns-mipi-dphy", .of_match_table = cdns_dphy_of_match,