From patchwork Tue Mar 7 11:58:33 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13163302 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D99E2C6FD20 for ; Tue, 7 Mar 2023 11:59:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xOG6v7opFU+Qok48XsJZmkoCMsolzM2IL19N3j5phKk=; b=lYeQR6XJiX7VyY I0RHQhA9iUnZhekDh20MHdfTqAIyD05oml4nro6BCe0yQ6f5pEmtUPvVfRxnJDuP2PPo0Ij9oZreg QVu5PFUwHmchru0JO4+D8AYGM8M7NJdA5K2AvOmQ633/Ebmbz63O2/tbGbgxGZvJDHQ4cmjKOlU1O BICMcFx9vQ7e2ZZ/RATGtui1CcF7NrFWRn1ic7lCf8lwIbf2NcjrCoK/Sz2xRcG1RC1vXJUjUlCBT suSMVikkjHp0ohwWKgoVqjBYjNCaeAmfaq1W1oQ4x4KOrCHLOrCUIjBccRuPbhoMIgLecbgd7vyH8 WHnxURrh76QxX9MtQQpA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pZVyp-00HZH3-85; Tue, 07 Mar 2023 11:59:43 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pZVyU-00HZ0s-HT for linux-phy@lists.infradead.org; Tue, 07 Mar 2023 11:59:27 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pZVyH-0006T9-6w; Tue, 07 Mar 2023 12:59:09 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pZVyF-002TEi-OG; Tue, 07 Mar 2023 12:59:07 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pZVyE-002yis-Vc; Tue, 07 Mar 2023 12:59:06 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Vinod Koul , Kishon Vijay Abraham I , Swapnil Jakhade , Lars-Peter Clausen Cc: linux-phy@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH 04/31] phy: cadence: phy-cadence-sierra: Convert to platform remove callback returning void Date: Tue, 7 Mar 2023 12:58:33 +0100 Message-Id: <20230307115900.2293120-5-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230307115900.2293120-1-u.kleine-koenig@pengutronix.de> References: <20230307115900.2293120-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1836; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=AXV1XLtUqhQ1dvqpqsNePUWHHlGGT+GIGa0Ixk5r/60=; b=owGbwMvMwMV48I9IxdpTbzgZT6slMaSwq3UzrOCbtETx29KNnunRQfVneQQVq2/Z2SYpuZRYR NUx3DPuZDRmYWDkYpAVU2SpK9ISmyCx5r9dyRJumEGsTGBTuDgFYCLL/rL/0+iOMvdfrxclZDq5 udTs6bqFRf6PHS89Lfo2eYXfj8+m3s/e+DM/mj1xR2+F2Imcj5PCz/0qbpP+ZCxsP6vmtuzjO7n /fe5ddKyaNZv33J0LO4pfCxrpOEpnnd71NeVOYvsP78jH8W8tHx8QsDP32LgstE9NN0VJu+DhGc MLKRO1hfW3lByK1134VvFP3+q0N2987aszRM26DFcEhmU71DKqvnj9y7at0TdEeIL1I7G0L+rHc xYXOZ+3V3gl6V/aMmPZw3lvncQOmkWwrT/3Z2ntmxCfM7pyfnzq7AvfczvdSq22S12dprpYKLnS 58hULZOugyYZdeFGGZnlJyQLX7EtTfv5dtIbOR1d3ikA X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-phy@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230307_035922_597205_EE538B65 X-CRM114-Status: GOOD ( 15.76 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/phy/cadence/phy-cadence-sierra.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/phy/cadence/phy-cadence-sierra.c b/drivers/phy/cadence/phy-cadence-sierra.c index 6e86a6517f37..294d59b9eaed 100644 --- a/drivers/phy/cadence/phy-cadence-sierra.c +++ b/drivers/phy/cadence/phy-cadence-sierra.c @@ -1513,7 +1513,7 @@ static int cdns_sierra_phy_probe(struct platform_device *pdev) return ret; } -static int cdns_sierra_phy_remove(struct platform_device *pdev) +static void cdns_sierra_phy_remove(struct platform_device *pdev) { struct cdns_sierra_phy *phy = platform_get_drvdata(pdev); int i; @@ -1533,8 +1533,6 @@ static int cdns_sierra_phy_remove(struct platform_device *pdev) } cdns_sierra_clk_unregister(phy); - - return 0; } /* QSGMII PHY PMA lane configuration */ @@ -2520,7 +2518,7 @@ MODULE_DEVICE_TABLE(of, cdns_sierra_id_table); static struct platform_driver cdns_sierra_driver = { .probe = cdns_sierra_phy_probe, - .remove = cdns_sierra_phy_remove, + .remove_new = cdns_sierra_phy_remove, .driver = { .name = "cdns-sierra-phy", .of_match_table = cdns_sierra_id_table,