From patchwork Tue Mar 7 11:58:34 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13163301 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9E8F3C678D5 for ; Tue, 7 Mar 2023 11:59:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=pOfw0I+FOHYBRunv48VlUjoQJQtwjXKx7F8b/aHRutw=; b=jiiqLMekKAo4eA ViizH1iitt7RksgvsDrVGLJ2hh/JcfCdyE32X0HTH/o781ZF/bFukXepLujeGesUlnfrLlWKOtXlj FMWz0DxNWmzsJD+e3k2KRkybb601o8iUcMQ+1izXnr4kS0JnZCm2lCpZCbIk1Bhxwu6t7XcKtOzg9 zTUdCglugePf6ie1sHiWSA/He6KcZHMwOvn+KK9f3WdkTZSfPfOG9N926kt5sZR7cWcSy6nQrKcOu gy8IXsRb8es1/KkC0wiEFQ3Fm4TjcBRdBen1A3TFSbcwqWrZFqxrmLbqk8sc0nhbk+VY4wBCeC+rw OFcqP9kHIy7wBmhKuBNQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pZVyp-00HZGp-2J; Tue, 07 Mar 2023 11:59:43 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pZVyU-00HZ0j-7s for linux-phy@lists.infradead.org; Tue, 07 Mar 2023 11:59:27 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pZVyI-0006Tu-I3; Tue, 07 Mar 2023 12:59:10 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pZVyH-002TFB-Qh; Tue, 07 Mar 2023 12:59:09 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pZVyF-002yiw-4v; Tue, 07 Mar 2023 12:59:07 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Vinod Koul , Kishon Vijay Abraham I , Lars-Peter Clausen Cc: linux-phy@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH 05/31] phy: cadence: phy-cadence-torrent: Convert to platform remove callback returning void Date: Tue, 7 Mar 2023 12:58:34 +0100 Message-Id: <20230307115900.2293120-6-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230307115900.2293120-1-u.kleine-koenig@pengutronix.de> References: <20230307115900.2293120-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1914; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=1GRRyDR85Pj5BAv2kHwpd70U0CmKvfL6izY6Oa0xqBI=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBkByaPssiuLDX0F8hVfepEpm/U7vF3yeXgob/uO MKtdvcUt1mJATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCZAcmjwAKCRDB/BR4rcrs CZCaB/4x58m9q9HoC0njSyJnb3YowwDRSh5zlXsyS2Vly6kcrplPUoTne8tjHsRUG7PUxhpo41g MgOUTFrUEkDYTvwiZWzK1Q6flxEyZRcvNQaRPJ+9TQOGtdx/VOjsInN4p2TQX/sy5ZQPQkmhRY7 74T+fIvJyNHmM+k9p5VZOV2taGWLAQaUdMW/TvJz8OuP8KQgfiJV4aK0KoF6Oqs+tt00nHhlcgB 9XHoEyZBTHMZTdUZ8ybd6rlYJ55Q/Mp3PpG+vFivZqlY1uLjJbhFrErYLWT6uTVj4q8yylCJmpn tx+sYrA45aPpjDK9a8+kI2uy/s+EZLTHaAd8X6ZGNL+t46/L X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-phy@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230307_035922_334066_A7D2C375 X-CRM114-Status: GOOD ( 15.66 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/phy/cadence/phy-cadence-torrent.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/phy/cadence/phy-cadence-torrent.c b/drivers/phy/cadence/phy-cadence-torrent.c index f099053c583c..3831f596d50c 100644 --- a/drivers/phy/cadence/phy-cadence-torrent.c +++ b/drivers/phy/cadence/phy-cadence-torrent.c @@ -2777,7 +2777,7 @@ static int cdns_torrent_phy_probe(struct platform_device *pdev) return ret; } -static int cdns_torrent_phy_remove(struct platform_device *pdev) +static void cdns_torrent_phy_remove(struct platform_device *pdev) { struct cdns_torrent_phy *cdns_phy = platform_get_drvdata(pdev); int i; @@ -2791,8 +2791,6 @@ static int cdns_torrent_phy_remove(struct platform_device *pdev) clk_disable_unprepare(cdns_phy->clk); cdns_torrent_clk_cleanup(cdns_phy); - - return 0; } /* Single DisplayPort(DP) link configuration */ @@ -4708,7 +4706,7 @@ MODULE_DEVICE_TABLE(of, cdns_torrent_phy_of_match); static struct platform_driver cdns_torrent_phy_driver = { .probe = cdns_torrent_phy_probe, - .remove = cdns_torrent_phy_remove, + .remove_new = cdns_torrent_phy_remove, .driver = { .name = "cdns-torrent-phy", .of_match_table = cdns_torrent_phy_of_match,