From patchwork Tue Mar 7 11:58:35 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13163314 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6E2D2C678D5 for ; Tue, 7 Mar 2023 12:00:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=cRA31/lbS8vyVNT+lqANikV8vKk+WHvJJ3mFvjrzlS8=; b=KY2QIYC7p+M6A6 RTV7I1LTM7a61DtA27Zg0/ROyAty4/zFOp8sZJCEqN8JwJV7RGdkap/+hmhnEskqZ5UAZNehc8Omo RpEyya+Mu0xgML4XnH71aa7Txuu8cqgiaalehCTnHCEvadFWTw852YGIDfW2IPKMLk08DypSphTbk S2SGF82hD0AvvQ14mbXDXorL94zCZ9zelFBQR1qLUPmZao8TFR3LyfO542jAq+RTxG3d01rorAnAD MLzsAyXcwnfmy/KRdboIMoXEQ83lYMqfgFD9T5UleLqarPzt74SqFAMfY21M5EB+uvUeU6HEStplV bITRTIf7jRwarCvMN1Iw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pZVze-00HZnQ-TN; Tue, 07 Mar 2023 12:00:34 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pZVyh-00HZCP-IL for linux-phy@bombadil.infradead.org; Tue, 07 Mar 2023 11:59:35 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:Content-Type :MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Sender:Reply-To:Content-ID:Content-Description; bh=pv1Kzd5+N+jA6CZ98VqCMtJ36LJsWXt0hzxwgSM3DZg=; b=UiXf5fYHEWKqMPNz4Z+HWuPV7o OPsxx6efI7gjmuSJXKSVl0Oo/tTIJDu2jUbB/+U3i02qVWmBX6peEBQxWAt3iN1ygne5N4jWXw8Z4 5c1/g8p4em1TLHLbNAfS+j80Edc0SmL6WbpHxbSVBHNk9fB1FYAYi2GewFpQA0H9As0ddTm1mLfL+ eC54CHLSJK3euRVY/sf+6+ppqICm4szNagpf61vhKPPwKW5fl2t4iZwbmJ0G5nJ+a1b1Ypx2YmT4Z vXO4kMWQbmUMFThSRJ5kG/dOog0bTAU6KrvKzNosEec1xGAW0gi61Bnwsd1Sja+W8EHu0+eexlpsj XNfzgPlg==; Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by desiato.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pZVyZ-00H2AA-2w for linux-phy@lists.infradead.org; Tue, 07 Mar 2023 11:59:34 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pZVyI-0006Ts-J7; Tue, 07 Mar 2023 12:59:10 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pZVyH-002TF7-Nd; Tue, 07 Mar 2023 12:59:09 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pZVyF-002yiz-9t; Tue, 07 Mar 2023 12:59:07 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Vinod Koul , Kishon Vijay Abraham I , Shawn Guo , Sascha Hauer , Liu Ying Cc: Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH 06/31] phy: freescale: phy-fsl-imx8qm-lvds-phy: Convert to platform remove callback returning void Date: Tue, 7 Mar 2023 12:58:35 +0100 Message-Id: <20230307115900.2293120-7-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230307115900.2293120-1-u.kleine-koenig@pengutronix.de> References: <20230307115900.2293120-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1724; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=9gpHIEckggYTyZ3HIlCaCJikgQAfbCSp+a63y0MDM4Y=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBkByaTAkC2kNUdjAdrmyObSMkjKoxMDh66rcgMA bw14mHjebSJATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCZAcmkwAKCRDB/BR4rcrs Cb0OB/wJwSxUlUSpn3/T4nIet5SaQGCH0dLdgUpAW6AZMoVY+j56u0cwQXr5Ue49CMVwK4LJyeA UDS35Sw9KxsXcaMeH/UW8BkZRYtkWvFYgqCrEZj4SABoIgaRyezaOphHK52HInzGQhXauoufqkO YSl9500uH1FdnbqWH3aXlfHocGZ6gIGeUDRM/5Ptfa+Y242jJVx7EjOm6Zkrjp8RZ2QOb2pF1yW PeFXUq/e5Kc1FfRFioMtTE0hsnMyR6M+esB66Qm6kAFAIk6dGXOjTiKkYzPSqvWvlXb8firVMwf uoEszAA4QtjXQRwq+dKIYzrCOccPZLQ9GJYstbFusqh1IeNX X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-phy@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230307_115929_444075_FC262F39 X-CRM114-Status: GOOD ( 14.86 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/phy/freescale/phy-fsl-imx8qm-lvds-phy.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/phy/freescale/phy-fsl-imx8qm-lvds-phy.c b/drivers/phy/freescale/phy-fsl-imx8qm-lvds-phy.c index e514b64bfdab..0ae052df3765 100644 --- a/drivers/phy/freescale/phy-fsl-imx8qm-lvds-phy.c +++ b/drivers/phy/freescale/phy-fsl-imx8qm-lvds-phy.c @@ -391,11 +391,9 @@ static int mixel_lvds_phy_probe(struct platform_device *pdev) return ret; } -static int mixel_lvds_phy_remove(struct platform_device *pdev) +static void mixel_lvds_phy_remove(struct platform_device *pdev) { pm_runtime_disable(&pdev->dev); - - return 0; } static int __maybe_unused mixel_lvds_phy_runtime_suspend(struct device *dev) @@ -436,7 +434,7 @@ MODULE_DEVICE_TABLE(of, mixel_lvds_phy_of_match); static struct platform_driver mixel_lvds_phy_driver = { .probe = mixel_lvds_phy_probe, - .remove = mixel_lvds_phy_remove, + .remove_new = mixel_lvds_phy_remove, .driver = { .pm = &mixel_lvds_phy_pm_ops, .name = "mixel-lvds-phy",