| Message ID | 20230413182345.92557-4-sebastian.reichel@collabora.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Add RK3588 SATA support | expand |
On Thu, Apr 13, 2023 at 08:23:43PM +0200, Sebastian Reichel wrote: > The RK3588 has two reset lines for the combphy. One for the > APB interface and one for the actual PHY. > > Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com> > --- > .../bindings/phy/phy-rockchip-naneng-combphy.yaml | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/phy/phy-rockchip-naneng-combphy.yaml b/Documentation/devicetree/bindings/phy/phy-rockchip-naneng-combphy.yaml > index 9ae514fa7533..bac1aae07555 100644 > --- a/Documentation/devicetree/bindings/phy/phy-rockchip-naneng-combphy.yaml > +++ b/Documentation/devicetree/bindings/phy/phy-rockchip-naneng-combphy.yaml > @@ -31,8 +31,13 @@ properties: > - const: pipe > > resets: > + minItems: 1 > + maxItems: 2 > + > + reset-names: > items: > - - description: exclusive PHY reset line > + - const: phy > + - const: apb This will fail on any existing users with single entry. You need to add 'minItems: 1' here. It also fails if they didn't use 'phy' as the name, but names should be defined. Rob
Hello Rob, On Tue, Apr 18, 2023 at 03:41:36PM -0500, Rob Herring wrote: > On Thu, Apr 13, 2023 at 08:23:43PM +0200, Sebastian Reichel wrote: > > The RK3588 has two reset lines for the combphy. One for the > > APB interface and one for the actual PHY. > > > > Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com> > > --- > > .../bindings/phy/phy-rockchip-naneng-combphy.yaml | 7 ++++++- > > 1 file changed, 6 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/phy/phy-rockchip-naneng-combphy.yaml b/Documentation/devicetree/bindings/phy/phy-rockchip-naneng-combphy.yaml > > index 9ae514fa7533..bac1aae07555 100644 > > --- a/Documentation/devicetree/bindings/phy/phy-rockchip-naneng-combphy.yaml > > +++ b/Documentation/devicetree/bindings/phy/phy-rockchip-naneng-combphy.yaml > > @@ -31,8 +31,13 @@ properties: > > - const: pipe > > > > resets: > > + minItems: 1 > > + maxItems: 2 > > + > > + reset-names: > > items: > > - - description: exclusive PHY reset line > > + - const: phy > > + - const: apb > > This will fail on any existing users with single entry. You need to add > 'minItems: 1' here. > > It also fails if they didn't use 'phy' as the name, but names should be > defined. My understanding is, there there currently are users with one entry and no reset-names. I suppose its sensible not to provide a reset-name, iff there is only one line. As far as I can tell that should still work after my changes. -- Sebastian
diff --git a/Documentation/devicetree/bindings/phy/phy-rockchip-naneng-combphy.yaml b/Documentation/devicetree/bindings/phy/phy-rockchip-naneng-combphy.yaml index 9ae514fa7533..bac1aae07555 100644 --- a/Documentation/devicetree/bindings/phy/phy-rockchip-naneng-combphy.yaml +++ b/Documentation/devicetree/bindings/phy/phy-rockchip-naneng-combphy.yaml @@ -31,8 +31,13 @@ properties: - const: pipe resets: + minItems: 1 + maxItems: 2 + + reset-names: items: - - description: exclusive PHY reset line + - const: phy + - const: apb rockchip,enable-ssc: type: boolean
The RK3588 has two reset lines for the combphy. One for the APB interface and one for the actual PHY. Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com> --- .../bindings/phy/phy-rockchip-naneng-combphy.yaml | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)