| Message ID | 20230505185247.1854677-2-Frank.Li@nxp.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [1/2] phy: cadence: salvo: Add usb2-disconnect-threshold-microvolt property | expand |
On Fri, 05 May 2023 14:52:47 -0400, Frank Li wrote: > Add usb2-disconnect-threshold-microvolt property to address fake USB > disconnection issue during enumeration or suspend state for difference > platform. > > Signed-off-by: Frank Li <Frank.Li@nxp.com> > --- > Documentation/devicetree/bindings/phy/cdns,salvo-phy.yaml | 7 +++++++ > 1 file changed, 7 insertions(+) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/phy/cdns,salvo-phy.yaml: properties:usb2-disconnect-threshold-microvolt: '$ref' should not be valid under {'const': '$ref'} hint: Standard unit suffix properties don't need a type $ref from schema $id: http://devicetree.org/meta-schemas/core.yaml# doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230505185247.1854677-2-Frank.Li@nxp.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
On 05/05/2023 20:52, Frank Li wrote: > Add usb2-disconnect-threshold-microvolt property to address fake USB > disconnection issue during enumeration or suspend state for difference > platform. Use subject prefixes matching the subsystem (which you can get for example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory your patch is touching). Two prefixes got wrong... It's not doc but it is dt-bindings. > > Signed-off-by: Frank Li <Frank.Li@nxp.com> > --- > Documentation/devicetree/bindings/phy/cdns,salvo-phy.yaml | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/Documentation/devicetree/bindings/phy/cdns,salvo-phy.yaml b/Documentation/devicetree/bindings/phy/cdns,salvo-phy.yaml > index 3a07285b5470..3c7f5b3f9211 100644 > --- a/Documentation/devicetree/bindings/phy/cdns,salvo-phy.yaml > +++ b/Documentation/devicetree/bindings/phy/cdns,salvo-phy.yaml > @@ -31,6 +31,13 @@ properties: > "#phy-cells": > const: 0 > > + usb2-disconnect-threshold-microvolt: > + description: The microvolt threshold value utilized for detecting > + USB disconnection event. > + $ref: /schemas/types.yaml#/definitions/uint32 Does not look like you tested the bindings. Please run `make dt_binding_check` (see Documentation/devicetree/bindings/writing-schema.rst for instructions). Drop ref. Add vendor prefix. > + enum: [575, 610, 645] > + default: 575 > + > required: > - compatible > - reg Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/phy/cdns,salvo-phy.yaml b/Documentation/devicetree/bindings/phy/cdns,salvo-phy.yaml index 3a07285b5470..3c7f5b3f9211 100644 --- a/Documentation/devicetree/bindings/phy/cdns,salvo-phy.yaml +++ b/Documentation/devicetree/bindings/phy/cdns,salvo-phy.yaml @@ -31,6 +31,13 @@ properties: "#phy-cells": const: 0 + usb2-disconnect-threshold-microvolt: + description: The microvolt threshold value utilized for detecting + USB disconnection event. + $ref: /schemas/types.yaml#/definitions/uint32 + enum: [575, 610, 645] + default: 575 + required: - compatible - reg
Add usb2-disconnect-threshold-microvolt property to address fake USB disconnection issue during enumeration or suspend state for difference platform. Signed-off-by: Frank Li <Frank.Li@nxp.com> --- Documentation/devicetree/bindings/phy/cdns,salvo-phy.yaml | 7 +++++++ 1 file changed, 7 insertions(+)