| Message ID | 20230808083243.3113192-3-Sandor.yu@nxp.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Initial support Cadence MHDP8501(HDMI/DP) for i.MX8MQ | expand |
On 08/08/2023 11:32, Sandor Yu wrote: > Allow HDMI PHYs to be configured through the generic > functions through a custom structure added to the generic union. > > The parameters added here are based on HDMI PHY > implementation practices. The current set of parameters > should cover the potential users. > > Signed-off-by: Sandor Yu <Sandor.yu@nxp.com> > --- > include/linux/phy/phy-hdmi.h | 24 ++++++++++++++++++++++++ > include/linux/phy/phy.h | 7 ++++++- > 2 files changed, 30 insertions(+), 1 deletion(-) > create mode 100644 include/linux/phy/phy-hdmi.h I think this looks good now, thank you! Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
On 17-08-23, 13:05, Dmitry Baryshkov wrote: > On 08/08/2023 11:32, Sandor Yu wrote: > > Allow HDMI PHYs to be configured through the generic > > functions through a custom structure added to the generic union. > > > > The parameters added here are based on HDMI PHY > > implementation practices. The current set of parameters > > should cover the potential users. > > > > Signed-off-by: Sandor Yu <Sandor.yu@nxp.com> > > --- > > include/linux/phy/phy-hdmi.h | 24 ++++++++++++++++++++++++ > > include/linux/phy/phy.h | 7 ++++++- > > 2 files changed, 30 insertions(+), 1 deletion(-) > > create mode 100644 include/linux/phy/phy-hdmi.h > > I think this looks good now, thank you! > > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Should this go thru drm or phy...? > > -- > With best wishes > Dmitry
On 22/08/2023 16:54, Vinod Koul wrote: > On 17-08-23, 13:05, Dmitry Baryshkov wrote: >> On 08/08/2023 11:32, Sandor Yu wrote: >>> Allow HDMI PHYs to be configured through the generic >>> functions through a custom structure added to the generic union. >>> >>> The parameters added here are based on HDMI PHY >>> implementation practices. The current set of parameters >>> should cover the potential users. >>> >>> Signed-off-by: Sandor Yu <Sandor.yu@nxp.com> >>> --- >>> include/linux/phy/phy-hdmi.h | 24 ++++++++++++++++++++++++ >>> include/linux/phy/phy.h | 7 ++++++- >>> 2 files changed, 30 insertions(+), 1 deletion(-) >>> create mode 100644 include/linux/phy/phy-hdmi.h >> >> I think this looks good now, thank you! >> >> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > > Should this go thru drm or phy...? I'd say, PHY, together with the other PHY patches. If you can merge them into an immutable branch, then it can also be merged into drm-misc (?) to provide the dependency between drm and phy parts. -- With best wishes Dmitry
On 22-08-23, 20:22, Dmitry Baryshkov wrote: > On 22/08/2023 16:54, Vinod Koul wrote: > > On 17-08-23, 13:05, Dmitry Baryshkov wrote: > >> On 08/08/2023 11:32, Sandor Yu wrote: > >>> Allow HDMI PHYs to be configured through the generic > >>> functions through a custom structure added to the generic union. > >>> > >>> The parameters added here are based on HDMI PHY > >>> implementation practices. The current set of parameters > >>> should cover the potential users. > >>> > >>> Signed-off-by: Sandor Yu <Sandor.yu@nxp.com> > >>> --- > >>> include/linux/phy/phy-hdmi.h | 24 ++++++++++++++++++++++++ > >>> include/linux/phy/phy.h | 7 ++++++- > >>> 2 files changed, 30 insertions(+), 1 deletion(-) > >>> create mode 100644 include/linux/phy/phy-hdmi.h > >> > >> I think this looks good now, thank you! > >> > >> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > > > > Should this go thru drm or phy...? > > I'd say, PHY, together with the other PHY patches. If you can merge > them into an immutable branch, then it can also be merged into > drm-misc (?) to provide the dependency between drm and phy parts. phy/topic/hdmi should be pushed out in a bit for that
On 21-09-23, 16:01, Vinod Koul wrote: > On 22-08-23, 20:22, Dmitry Baryshkov wrote: > > On 22/08/2023 16:54, Vinod Koul wrote: > > > On 17-08-23, 13:05, Dmitry Baryshkov wrote: > > >> On 08/08/2023 11:32, Sandor Yu wrote: > > >>> Allow HDMI PHYs to be configured through the generic > > >>> functions through a custom structure added to the generic union. > > >>> > > >>> The parameters added here are based on HDMI PHY > > >>> implementation practices. The current set of parameters > > >>> should cover the potential users. > > >>> > > >>> Signed-off-by: Sandor Yu <Sandor.yu@nxp.com> > > >>> --- > > >>> include/linux/phy/phy-hdmi.h | 24 ++++++++++++++++++++++++ > > >>> include/linux/phy/phy.h | 7 ++++++- > > >>> 2 files changed, 30 insertions(+), 1 deletion(-) > > >>> create mode 100644 include/linux/phy/phy-hdmi.h > > >> > > >> I think this looks good now, thank you! > > >> > > >> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > > > > > > Should this go thru drm or phy...? > > > > I'd say, PHY, together with the other PHY patches. If you can merge > > them into an immutable branch, then it can also be merged into > > drm-misc (?) to provide the dependency between drm and phy parts. > > phy/topic/hdmi should be pushed out in a bit for that Sorry we need the drm header, so best to merge thru drm tree: Acked-by: Vinod Koul <vkoul@kernel.org>
diff --git a/include/linux/phy/phy-hdmi.h b/include/linux/phy/phy-hdmi.h new file mode 100644 index 000000000000..b7de88e9090f --- /dev/null +++ b/include/linux/phy/phy-hdmi.h @@ -0,0 +1,24 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +/* + * Copyright 2022 NXP + */ + +#ifndef __PHY_HDMI_H_ +#define __PHY_HDMI_H_ + +#include <linux/hdmi.h> +/** + * struct phy_configure_opts_hdmi - HDMI configuration set + * @pixel_clk_rate: Pixel clock of video modes in KHz. + * @bpc: Maximum bits per color channel. + * @color_space: Colorspace in enum hdmi_colorspace. + * + * This structure is used to represent the configuration state of a HDMI phy. + */ +struct phy_configure_opts_hdmi { + unsigned int pixel_clk_rate; + unsigned int bpc; + enum hdmi_colorspace color_space; +}; + +#endif /* __PHY_HDMI_H_ */ diff --git a/include/linux/phy/phy.h b/include/linux/phy/phy.h index f6d607ef0e80..94d489a8a163 100644 --- a/include/linux/phy/phy.h +++ b/include/linux/phy/phy.h @@ -17,6 +17,7 @@ #include <linux/regulator/consumer.h> #include <linux/phy/phy-dp.h> +#include <linux/phy/phy-hdmi.h> #include <linux/phy/phy-lvds.h> #include <linux/phy/phy-mipi-dphy.h> @@ -42,7 +43,8 @@ enum phy_mode { PHY_MODE_MIPI_DPHY, PHY_MODE_SATA, PHY_MODE_LVDS, - PHY_MODE_DP + PHY_MODE_DP, + PHY_MODE_HDMI, }; enum phy_media { @@ -60,11 +62,14 @@ enum phy_media { * the DisplayPort protocol. * @lvds: Configuration set applicable for phys supporting * the LVDS phy mode. + * @hdmi: Configuration set applicable for phys supporting + * the HDMI phy mode. */ union phy_configure_opts { struct phy_configure_opts_mipi_dphy mipi_dphy; struct phy_configure_opts_dp dp; struct phy_configure_opts_lvds lvds; + struct phy_configure_opts_hdmi hdmi; }; /**
Allow HDMI PHYs to be configured through the generic functions through a custom structure added to the generic union. The parameters added here are based on HDMI PHY implementation practices. The current set of parameters should cover the potential users. Signed-off-by: Sandor Yu <Sandor.yu@nxp.com> --- include/linux/phy/phy-hdmi.h | 24 ++++++++++++++++++++++++ include/linux/phy/phy.h | 7 ++++++- 2 files changed, 30 insertions(+), 1 deletion(-) create mode 100644 include/linux/phy/phy-hdmi.h