From patchwork Mon Sep 11 03:54:56 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tony Lindgren X-Patchwork-Id: 13378710 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E5558EE801F for ; Mon, 11 Sep 2023 03:55:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=SIxo9ArBwqKF+MWK7zd5Z77LLnpGQvUoPgRI5vwb8LI=; b=QGa4OqVjtPspNb QTvGP5iOKJ2AEHQ4mxhFDarud8XymHjFAVZphGDb4U913tYxXP9QGerJsFJgZWbxg/rcm+zL7k7hs 2E87E01UDhJMTYLDH6bFAGwS4kQ+cQi+PDcIhytvvefVozan0s1CIAdhrgkbUDIeuizg1k3ur7sNM 9rsWiHJ7hzzsdmTWlfZlh47NbJgvQ72lVTTt85azSFDUUAGrq1RrXtPVfeN2U0URkPFx65enUuQSI H4Se4/3dWH/yQEWtjoAJ+wX0GZ+rFMBa5t8HUU2iflQqVA1buRA5h+Nmspog5n5BgwJ02D6JWRQoL 5eN3kaq5Y4BBaRttdRAA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qfY1D-00HBpw-1F; Mon, 11 Sep 2023 03:55:23 +0000 Received: from muru.com ([72.249.23.125]) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qfY1A-00HBpY-1W for linux-phy@lists.infradead.org; Mon, 11 Sep 2023 03:55:21 +0000 Received: from hillo.muru.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTP id 8C00E80CC; Mon, 11 Sep 2023 03:55:18 +0000 (UTC) From: Tony Lindgren To: Vinod Koul , Kishon Vijay Abraham I Cc: Ivaylo Dimitrov , Merlijn Wajer , Miaoqian Lin , Pavel Machek , Sebastian Reichel , linux-phy@lists.infradead.org, Kishon Vijay Abraham I Subject: [PATCH 2/3] phy: mapphone-mdm6600: Fix runtime PM for remove Date: Mon, 11 Sep 2023 06:54:56 +0300 Message-ID: <20230911035501.36706-2-tony@atomide.com> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20230911035501.36706-1-tony@atomide.com> References: <20230911035501.36706-1-tony@atomide.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230910_205520_549970_3666D9A8 X-CRM114-Status: UNSURE ( 8.70 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org Otherwise we will get an underflow on remove. Cc: Ivaylo Dimitrov Cc: Merlijn Wajer Cc: Pavel Machek Cc: Sebastian Reichel Fixes: f7f50b2a7b05 ("phy: mapphone-mdm6600: Add runtime PM support for n_gsm on USB suspend") Signed-off-by: Tony Lindgren --- drivers/phy/motorola/phy-mapphone-mdm6600.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/phy/motorola/phy-mapphone-mdm6600.c b/drivers/phy/motorola/phy-mapphone-mdm6600.c --- a/drivers/phy/motorola/phy-mapphone-mdm6600.c +++ b/drivers/phy/motorola/phy-mapphone-mdm6600.c @@ -640,6 +640,11 @@ static void phy_mdm6600_remove(struct platform_device *pdev) { struct phy_mdm6600 *ddata = platform_get_drvdata(pdev); struct gpio_desc *reset_gpio = ddata->ctrl_gpios[PHY_MDM6600_RESET]; + int error; + + error = pm_runtime_resume_and_get(ddata->dev); + if (error) + return; pm_runtime_dont_use_autosuspend(ddata->dev); pm_runtime_put_sync(ddata->dev);